linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8
Date: Fri, 6 Dec 2019 16:55:24 +0100	[thread overview]
Message-ID: <20191206155524.GI28879@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20191206133254.23800-1-geert+renesas@glider.be>

Hi Geert,

Thanks for your work.

On 2019-12-06 14:32:54 +0100, Geert Uytterhoeven wrote:
> All multipliers and dividers are small.
> Storing them in u8 instead of unsigned int reduces kernel size for a
> generic kernel by ca. 0.5 KiB.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in clk-renesas-for-v5.6.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
>  drivers/clk/renesas/rcar-gen2-cpg.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/renesas/rcar-gen2-cpg.h b/drivers/clk/renesas/rcar-gen2-cpg.h
> index db2f57ef2f9984e4..bdcd4a38d48d01bd 100644
> --- a/drivers/clk/renesas/rcar-gen2-cpg.h
> +++ b/drivers/clk/renesas/rcar-gen2-cpg.h
> @@ -24,10 +24,10 @@ enum rcar_gen2_clk_types {
>  };
>  
>  struct rcar_gen2_cpg_pll_config {
> -	unsigned int extal_div;
> -	unsigned int pll1_mult;
> -	unsigned int pll3_mult;
> -	unsigned int pll0_mult;		/* leave as zero if PLL0CR exists */
> +	u8 extal_div;
> +	u8 pll1_mult;
> +	u8 pll3_mult;
> +	u8 pll0_mult;		/* leave as zero if PLL0CR exists */
>  };
>  
>  struct clk *rcar_gen2_cpg_clk_register(struct device *dev,
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

      reply	other threads:[~2019-12-06 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 13:32 [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8 Geert Uytterhoeven
2019-12-06 15:55 ` Niklas Söderlund [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206155524.GI28879@bigcity.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=geert+renesas@glider.be \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).