linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8
@ 2019-12-06 13:32 Geert Uytterhoeven
  2019-12-06 15:55 ` Niklas Söderlund
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-06 13:32 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: linux-renesas-soc, linux-clk, Geert Uytterhoeven

All multipliers and dividers are small.
Storing them in u8 instead of unsigned int reduces kernel size for a
generic kernel by ca. 0.5 KiB.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in clk-renesas-for-v5.6.

 drivers/clk/renesas/rcar-gen2-cpg.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/renesas/rcar-gen2-cpg.h b/drivers/clk/renesas/rcar-gen2-cpg.h
index db2f57ef2f9984e4..bdcd4a38d48d01bd 100644
--- a/drivers/clk/renesas/rcar-gen2-cpg.h
+++ b/drivers/clk/renesas/rcar-gen2-cpg.h
@@ -24,10 +24,10 @@ enum rcar_gen2_clk_types {
 };
 
 struct rcar_gen2_cpg_pll_config {
-	unsigned int extal_div;
-	unsigned int pll1_mult;
-	unsigned int pll3_mult;
-	unsigned int pll0_mult;		/* leave as zero if PLL0CR exists */
+	u8 extal_div;
+	u8 pll1_mult;
+	u8 pll3_mult;
+	u8 pll0_mult;		/* leave as zero if PLL0CR exists */
 };
 
 struct clk *rcar_gen2_cpg_clk_register(struct device *dev,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8
  2019-12-06 13:32 [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8 Geert Uytterhoeven
@ 2019-12-06 15:55 ` Niklas Söderlund
  0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2019-12-06 15:55 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Michael Turquette, Stephen Boyd, linux-renesas-soc, linux-clk

Hi Geert,

Thanks for your work.

On 2019-12-06 14:32:54 +0100, Geert Uytterhoeven wrote:
> All multipliers and dividers are small.
> Storing them in u8 instead of unsigned int reduces kernel size for a
> generic kernel by ca. 0.5 KiB.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in clk-renesas-for-v5.6.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
>  drivers/clk/renesas/rcar-gen2-cpg.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/renesas/rcar-gen2-cpg.h b/drivers/clk/renesas/rcar-gen2-cpg.h
> index db2f57ef2f9984e4..bdcd4a38d48d01bd 100644
> --- a/drivers/clk/renesas/rcar-gen2-cpg.h
> +++ b/drivers/clk/renesas/rcar-gen2-cpg.h
> @@ -24,10 +24,10 @@ enum rcar_gen2_clk_types {
>  };
>  
>  struct rcar_gen2_cpg_pll_config {
> -	unsigned int extal_div;
> -	unsigned int pll1_mult;
> -	unsigned int pll3_mult;
> -	unsigned int pll0_mult;		/* leave as zero if PLL0CR exists */
> +	u8 extal_div;
> +	u8 pll1_mult;
> +	u8 pll3_mult;
> +	u8 pll0_mult;		/* leave as zero if PLL0CR exists */
>  };
>  
>  struct clk *rcar_gen2_cpg_clk_register(struct device *dev,
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-06 15:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 13:32 [PATCH] clk: renesas: rcar-gen2: Change multipliers and dividers to u8 Geert Uytterhoeven
2019-12-06 15:55 ` Niklas Söderlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).