linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()
Date: Mon, 9 Dec 2019 08:14:24 +0000	[thread overview]
Message-ID: <20191209081424.GE3468@dell> (raw)
In-Reply-To: <20191206133414.23925-1-geert+renesas@glider.be>

On Fri, 06 Dec 2019, Geert Uytterhoeven wrote:

> The second line of the of_clk_detect_critical() function signature is
> not indented according to coding style.
> 
> Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")

This is not suitable for Stable.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/clk/clk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 9c5b9419e585f845..06ea776830473c2a 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4799,8 +4799,8 @@ static int parent_ready(struct device_node *np)
>   *
>   * Return: error code or zero on success
>   */
> -int of_clk_detect_critical(struct device_node *np,
> -					  int index, unsigned long *flags)

Not sure what happened here.

> +int of_clk_detect_critical(struct device_node *np, int index,
> +			   unsigned long *flags)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2019-12-09  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 13:34 Geert Uytterhoeven
2019-12-09  8:14 ` Lee Jones [this message]
2020-02-12 23:39 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209081424.GE3468@dell \
    --to=lee.jones@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --subject='Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).