[PATCH] clk: Fix continuation of of_clk_detect_critical()

[PATCH] clk: Fix continuation of of_clk_detect_critical()

[Geert Uytterhoeven]

The second line of the of_clk_detect_critical() function signature is
not indented according to coding style.

Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/clk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 9c5b9419e585f845..06ea776830473c2a 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4799,8 +4799,8 @@ static int parent_ready(struct device_node *np)
  *
  * Return: error code or zero on success
  */
-int of_clk_detect_critical(struct device_node *np,
-					  int index, unsigned long *flags)
+int of_clk_detect_critical(struct device_node *np, int index,
+			   unsigned long *flags)
 {
 	struct property *prop;
 	const __be32 *cur;
-- 
2.17.1

Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()

[Lee Jones]

On Fri, 06 Dec 2019, Geert Uytterhoeven wrote:

> The second line of the of_clk_detect_critical() function signature is
> not indented according to coding style.
> 
> Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")

This is not suitable for Stable.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/clk/clk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 9c5b9419e585f845..06ea776830473c2a 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4799,8 +4799,8 @@ static int parent_ready(struct device_node *np)
>   *
>   * Return: error code or zero on success
>   */
> -int of_clk_detect_critical(struct device_node *np,
> -					  int index, unsigned long *flags)

Not sure what happened here.

> +int of_clk_detect_critical(struct device_node *np, int index,
> +			   unsigned long *flags)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] clk: Fix continuation of of_clk_detect_critical()

[Stephen Boyd]

Quoting Geert Uytterhoeven (2019-12-06 05:34:14)
> The second line of the of_clk_detect_critical() function signature is
> not indented according to coding style.
> 
> Fixes: d56f8994b6fb928f ("clk: Provide OF helper to mark clocks as CRITICAL")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied to clk-next