linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Stephan Gerhold <stephan@gerhold.net>
Subject: [PATCH] clk: ux500: Initialize DSI clocks before registering
Date: Sun, 22 Dec 2019 21:29:28 +0100	[thread overview]
Message-ID: <20191222202928.14142-1-linus.walleij@linaro.org> (raw)

The DSI clocks need to be initialized properly and cannot
rely on boot defaults, this is especially important for the
U8420 SYSCLK variant of the PRCMU firmware which requires
that you poke these registers right before trying to use
the HS DSI clock. Some vital setup such as the PRCM_TVCLK_MGT
register will not happen unless we call this making some
displays fail to work on the U8420.

Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clk/ux500/u8500_of_clk.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
index 0aedd42fad52..c1043a6b383f 100644
--- a/drivers/clk/ux500/u8500_of_clk.c
+++ b/drivers/clk/ux500/u8500_of_clk.c
@@ -65,6 +65,9 @@ static void u8500_clk_init(struct device_node *np)
 	u32 bases[CLKRST_MAX];
 	int i;
 
+	/* Initialize display clocks */
+	prcmu_set_display_clocks();
+
 	for (i = 0; i < ARRAY_SIZE(bases); i++) {
 		struct resource r;
 
-- 
2.21.0


             reply	other threads:[~2019-12-22 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-22 20:29 Linus Walleij [this message]
2019-12-22 21:46 ` [PATCH] clk: ux500: Initialize DSI clocks before registering Linus Walleij
2019-12-23  9:16   ` Ulf Hansson
2019-12-23  9:28     ` Viresh Kumar
2019-12-23  9:33       ` Ulf Hansson
2019-12-23 16:25     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191222202928.14142-1-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).