linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH] clk: ux500: Initialize DSI clocks before registering
Date: Sun, 22 Dec 2019 22:46:03 +0100	[thread overview]
Message-ID: <CACRpkdaE1T6yt4u5uO+SZB18KjrVp2_4Qd9gr_aN0v5GTJ2VGw@mail.gmail.com> (raw)
In-Reply-To: <20191222202928.14142-1-linus.walleij@linaro.org>

On Sun, Dec 22, 2019 at 9:29 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> The DSI clocks need to be initialized properly and cannot
> rely on boot defaults, this is especially important for the
> U8420 SYSCLK variant of the PRCMU firmware which requires
> that you poke these registers right before trying to use
> the HS DSI clock. Some vital setup such as the PRCM_TVCLK_MGT
> register will not happen unless we call this making some
> displays fail to work on the U8420.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Sorry I got lost in the macros for CLK_MGT_ENTRY
that does poke these registers including PRCM_TVCLK_MGT.

I need to figure out what is actually going wrong with the
DSI clocks here.

Yours,
Linus Walleij

  reply	other threads:[~2019-12-22 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-22 20:29 [PATCH] clk: ux500: Initialize DSI clocks before registering Linus Walleij
2019-12-22 21:46 ` Linus Walleij [this message]
2019-12-23  9:16   ` Ulf Hansson
2019-12-23  9:28     ` Viresh Kumar
2019-12-23  9:33       ` Ulf Hansson
2019-12-23 16:25     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdaE1T6yt4u5uO+SZB18KjrVp2_4Qd9gr_aN0v5GTJ2VGw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).