Re: [PATCH 2/2] clk: qcom: Add ipq6018 Global Clock Controller support

Re: [PATCH 2/2] clk: qcom: Add ipq6018 Global Clock Controller support

[kbuild test robot]

Hi Sricharan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.5-rc4 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sricharan-R/Add-Global-clock-controller-support-for-IPQ6018/20200104-133041
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/clk/qcom/gcc-ipq6018.c:2623:17: sparse: sparse: symbol 'lpass_core_axim_clk_src' was not declared. Should it be static?
>> drivers/clk/qcom/gcc-ipq6018.c:2642:17: sparse: sparse: symbol 'lpass_snoc_cfg_clk_src' was not declared. Should it be static?
>> drivers/clk/qcom/gcc-ipq6018.c:2661:17: sparse: sparse: symbol 'lpass_q6_axim_clk_src' was not declared. Should it be static?
>> drivers/clk/qcom/gcc-ipq6018.c:2674:17: sparse: sparse: symbol 'ftbl_rbcpr_wcss_clk_src' was not declared. Should it be static?
>> drivers/clk/qcom/gcc-ipq6018.c:2680:17: sparse: sparse: symbol 'rbcpr_wcss_clk_src' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[RFC PATCH] clk: qcom: lpass_core_axim_clk_src can be static

[kbuild test robot]

Fixes: ac86608aeb82 ("clk: qcom: Add ipq6018 Global Clock Controller support")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 gcc-ipq6018.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
index a3597f46ad017..3f9c2f61a5d93 100644
--- a/drivers/clk/qcom/gcc-ipq6018.c
+++ b/drivers/clk/qcom/gcc-ipq6018.c
@@ -2620,7 +2620,7 @@ static const struct freq_tbl ftbl_lpass_core_axim_clk_src[] = {
 	{ }
 };
 
-struct clk_rcg2 lpass_core_axim_clk_src = {
+static struct clk_rcg2 lpass_core_axim_clk_src = {
 	.cmd_rcgr = 0x1F020,
 	.freq_tbl = ftbl_lpass_core_axim_clk_src,
 	.hid_width = 5,
@@ -2639,7 +2639,7 @@ static const struct freq_tbl ftbl_lpass_snoc_cfg_clk_src[] = {
 	{ }
 };
 
-struct clk_rcg2 lpass_snoc_cfg_clk_src = {
+static struct clk_rcg2 lpass_snoc_cfg_clk_src = {
 	.cmd_rcgr = 0x1F040,
 	.freq_tbl = ftbl_lpass_snoc_cfg_clk_src,
 	.hid_width = 5,
@@ -2658,7 +2658,7 @@ static const struct freq_tbl ftbl_lpass_q6_axim_clk_src[] = {
 	{ }
 };
 
-struct clk_rcg2 lpass_q6_axim_clk_src = {
+static struct clk_rcg2 lpass_q6_axim_clk_src = {
 	.cmd_rcgr = 0x1F008,
 	.freq_tbl = ftbl_lpass_q6_axim_clk_src,
 	.hid_width = 5,
@@ -2671,13 +2671,13 @@ struct clk_rcg2 lpass_q6_axim_clk_src = {
 	},
 };
 
-struct freq_tbl ftbl_rbcpr_wcss_clk_src[] = {
+static struct freq_tbl ftbl_rbcpr_wcss_clk_src[] = {
 	F(24000000, P_XO, 1, 0, 0),
 	F(50000000, P_GPLL0, 16, 0, 0),
 	{ }
 };
 
-struct clk_rcg2 rbcpr_wcss_clk_src = {
+static struct clk_rcg2 rbcpr_wcss_clk_src = {
 	.cmd_rcgr = 0x3a00c,
 	.freq_tbl = ftbl_rbcpr_wcss_clk_src,
 	.hid_width = 5,