[PATCH v2 0/3] clk: imx8mn: add snvs clock

[PATCH v2 0/3] clk: imx8mn: add snvs clock

[Horia Geantă]

v2: add commmit message for trivial patch 1/3

This patch set adds the clock for snvs module on imx8mn.
DT bindings, clk driver are updated accordingly.
DT for imx8mn (snvs-rtc-lp node) is also updated.

Horia Geantă (3):
  dt-bindings: clock: imx8mn: add SNVS clock
  clk: imx8mn: add SNVS clock to clock tree
  arm64: dts: imx8mn: add clock for snvs rtc node

 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 +
 drivers/clk/imx/clk-imx8mn.c              | 1 +
 include/dt-bindings/clock/imx8mn-clock.h  | 4 +++-
 3 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.17.1

[PATCH v2 1/3] dt-bindings: clock: imx8mn: add SNVS clock

[Horia Geantă]

Add macro for the SNVS clock of the i.MX8MN.

Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
 include/dt-bindings/clock/imx8mn-clock.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx8mn-clock.h b/include/dt-bindings/clock/imx8mn-clock.h
index 0f2b8423ce1d..43883fe65db5 100644
--- a/include/dt-bindings/clock/imx8mn-clock.h
+++ b/include/dt-bindings/clock/imx8mn-clock.h
@@ -228,6 +228,8 @@
 #define IMX8MN_SYS_PLL2_333M_CG			209
 #define IMX8MN_SYS_PLL2_500M_CG			210
 
-#define IMX8MN_CLK_END				211
+#define IMX8MN_CLK_SNVS_ROOT			211
+
+#define IMX8MN_CLK_END				212
 
 #endif
-- 
2.17.1

Re: [PATCH v2 1/3] dt-bindings: clock: imx8mn: add SNVS clock

[Rob Herring]

On Thu, 16 Jan 2020 09:37:16 +0200, =?UTF-8?q?Horia=20Geant=C4=83?= wrote:
> Add macro for the SNVS clock of the i.MX8MN.
> 
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> ---
>  include/dt-bindings/clock/imx8mn-clock.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH v2 2/3] clk: imx8mn: add SNVS clock to clock tree

[Horia Geantă]

i.mx8mn has support for clock gating the snvs module.
Add it into clock tree so that rtc-snvs driver could use it.

Note this will also be required in the snvs_pwrkey driver,
once support for clock management will be added.

Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
 drivers/clk/imx/clk-imx8mn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index ce2ba3dce483..6a50b59968f5 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -519,6 +519,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 	hws[IMX8MN_CLK_SAI5_IPG] = imx_clk_hw_gate2_shared2("sai5_ipg_clk", "ipg_audio_root", base + 0x4370, 0, &share_count_sai5);
 	hws[IMX8MN_CLK_SAI6_ROOT] = imx_clk_hw_gate2_shared2("sai6_root_clk", "sai6", base + 0x4380, 0, &share_count_sai6);
 	hws[IMX8MN_CLK_SAI6_IPG] = imx_clk_hw_gate2_shared2("sai6_ipg_clk", "ipg_audio_root", base + 0x4380, 0, &share_count_sai6);
+	hws[IMX8MN_CLK_SNVS_ROOT] = imx_clk_hw_gate4("snvs_root_clk", "ipg_root", base + 0x4470, 0);
 	hws[IMX8MN_CLK_UART1_ROOT] = imx_clk_hw_gate4("uart1_root_clk", "uart1", base + 0x4490, 0);
 	hws[IMX8MN_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk", "uart2", base + 0x44a0, 0);
 	hws[IMX8MN_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk", "uart3", base + 0x44b0, 0);
-- 
2.17.1

[PATCH v2 3/3] arm64: dts: imx8mn: add clock for snvs rtc node

[Horia Geantă]

Initial commit adding imx8mn support:
6c3debcbae47 ("arm64: dts: freescale: Add i.MX8MN dtsi support")
added the "clock-names" property for the snvs rtc node,
however it missed adding the clock.

Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index a44b5438e842..d23347aaedda 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -358,6 +358,7 @@
 					offset = <0x34>;
 					interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
 						     <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MN_CLK_SNVS_ROOT>;
 					clock-names = "snvs-rtc";
 				};
 
-- 
2.17.1

Re: [PATCH v2 0/3] clk: imx8mn: add snvs clock

[Horia Geanta]

On 1/16/2020 9:37 AM, Horia Geantă wrote:
> v2: add commmit message for trivial patch 1/3
> 
> This patch set adds the clock for snvs module on imx8mn.
> DT bindings, clk driver are updated accordingly.
> DT for imx8mn (snvs-rtc-lp node) is also updated.
> 
> Horia Geantă (3):
>   dt-bindings: clock: imx8mn: add SNVS clock
>   clk: imx8mn: add SNVS clock to clock tree
>   arm64: dts: imx8mn: add clock for snvs rtc node
> 
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 +
>  drivers/clk/imx/clk-imx8mn.c              | 1 +
>  include/dt-bindings/clock/imx8mn-clock.h  | 4 +++-
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
Kind reminder.

Patch set is here:
https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=229047&archive=both&state=*
Let me know if I should resend it.

Thanks,
Horia

Re: [PATCH v2 0/3] clk: imx8mn: add snvs clock

[Shawn Guo]

On Thu, Jan 16, 2020 at 09:37:15AM +0200, Horia Geantă wrote:
> v2: add commmit message for trivial patch 1/3
> 
> This patch set adds the clock for snvs module on imx8mn.
> DT bindings, clk driver are updated accordingly.
> DT for imx8mn (snvs-rtc-lp node) is also updated.
> 
> Horia Geantă (3):
>   dt-bindings: clock: imx8mn: add SNVS clock
>   clk: imx8mn: add SNVS clock to clock tree
>   arm64: dts: imx8mn: add clock for snvs rtc node

Applied all, thanks.