clk: imx: clock driver for imx8qm?

clk: imx: clock driver for imx8qm?

[Oliver Graute]

Hello Favio,
Hello Anson,

is someone working on clock driver for imx8qm? I miss at least a
clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are
working in this area and perhaps you can give me some insights what is
needed here.

Best regards,

Oliver

RE: clk: imx: clock driver for imx8qm?

[Aisheng Dong]

Hi Oliver,

> From: Oliver Graute <oliver.graute@gmail.com>
> Sent: Thursday, February 13, 2020 11:32 PM
>
> Hello Favio,
> Hello Anson,
> 
> is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c
> in the drivers/imx/clk/ directory. I saw that you are working in this area and
> perhaps you can give me some insights what is needed here.
> 

MX8QM/QXP are using the same clock driver clk-imx8qxp.c

[PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm support
https://www.spinics.net/lists/arm-kernel/msg781687.html
The review of that patch series is pending for a couple of months.

Stephen,
Would you help it?

Regards
Aisheng

> Best regards,
> 
> Oliver

Re: clk: imx: clock driver for imx8qm?

[Oliver Graute]

On 13/02/20, Aisheng Dong wrote:
> Hi Oliver,
> 
> > 
> > is someone working on clock driver for imx8qm? I miss at least a clk-imx8qm.c
> > in the drivers/imx/clk/ directory. I saw that you are working in this area and
> > perhaps you can give me some insights what is needed here.
> > 
> 
> MX8QM/QXP are using the same clock driver clk-imx8qxp.c

ok thx, for that clarification.

> 
> [PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm support
> https://www.spinics.net/lists/arm-kernel/msg781687.html
> The review of that patch series is pending for a couple of months.

yes that is what I currently use. So further imx8qm development can
happen if this is integrated?

Best regards,

Oliver

RE: clk: imx: clock driver for imx8qm?

[Aisheng Dong]

> From: Oliver Graute <oliver.graute@gmail.com>
> Sent: Friday, February 14, 2020 1:42 AM
> 
> On 13/02/20, Aisheng Dong wrote:
> > Hi Oliver,
> >
> > >
> > > is someone working on clock driver for imx8qm? I miss at least a
> > > clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are
> > > working in this area and perhaps you can give me some insights what is
> needed here.
> > >
> >
> > MX8QM/QXP are using the same clock driver clk-imx8qxp.c
> 
> ok thx, for that clarification.
> 
> >
> > [PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm
> > The review of that patch series is pending for a couple of months.
> 
> yes that is what I currently use. So further imx8qm development can happen if
> this is integrated?

Yes, it blocks the most following MX8QXP/QM work.
Let me loop in Shawn to see if any suggestions.

Shawn,
Any ideas?

Regards
Aisheng

> 
> Best regards,
> 
> Oliver

Re: clk: imx: clock driver for imx8qm?

[Shawn Guo]

On Fri, Feb 14, 2020 at 05:50:48AM +0000, Aisheng Dong wrote:
> > From: Oliver Graute <oliver.graute@gmail.com>
> > Sent: Friday, February 14, 2020 1:42 AM
> > 
> > On 13/02/20, Aisheng Dong wrote:
> > > Hi Oliver,
> > >
> > > >
> > > > is someone working on clock driver for imx8qm? I miss at least a
> > > > clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you are
> > > > working in this area and perhaps you can give me some insights what is
> > needed here.
> > > >
> > >
> > > MX8QM/QXP are using the same clock driver clk-imx8qxp.c
> > 
> > ok thx, for that clarification.
> > 
> > >
> > > [PATCH RESEND V5 00/11] clk: imx8: add new clock binding for better pm
> > > The review of that patch series is pending for a couple of months.
> > 
> > yes that is what I currently use. So further imx8qm development can happen if
> > this is integrated?
> 
> Yes, it blocks the most following MX8QXP/QM work.
> Let me loop in Shawn to see if any suggestions.
> 
> Shawn,
> Any ideas?

I guess there are still something Stephen is unhappy about, as we
haven't got a nod from him.  Do we really addressed all his comments
and concerns already?

Shawn

RE: clk: imx: clock driver for imx8qm?

[Aisheng Dong]

> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Monday, February 17, 2020 3:05 PM
> 
> On Fri, Feb 14, 2020 at 05:50:48AM +0000, Aisheng Dong wrote:
> > > From: Oliver Graute <oliver.graute@gmail.com>
> > > Sent: Friday, February 14, 2020 1:42 AM
> > >
> > > On 13/02/20, Aisheng Dong wrote:
> > > > Hi Oliver,
> > > >
> > > > >
> > > > > is someone working on clock driver for imx8qm? I miss at least a
> > > > > clk-imx8qm.c in the drivers/imx/clk/ directory. I saw that you
> > > > > are working in this area and perhaps you can give me some
> > > > > insights what is
> > > needed here.
> > > > >
> > > >
> > > > MX8QM/QXP are using the same clock driver clk-imx8qxp.c
> > >
> > > ok thx, for that clarification.
> > >
> > > >
> > > > [PATCH RESEND V5 00/11] clk: imx8: add new clock binding for
> > > > better pm The review of that patch series is pending for a couple of
> months.
> > >
> > > yes that is what I currently use. So further imx8qm development can
> > > happen if this is integrated?
> >
> > Yes, it blocks the most following MX8QXP/QM work.
> > Let me loop in Shawn to see if any suggestions.
> >
> > Shawn,
> > Any ideas?
> 
> I guess there are still something Stephen is unhappy about, as we haven't got a
> nod from him.  Do we really addressed all his comments and concerns already?
> 

I remember I addressed all Stephen's comments in the last round of review
which is marked in the V5 resend change log.
https://www.spinics.net/lists/arm-kernel/msg769365.html

But I can double check it.
Should I re-send after a checking or wait for Stephen's feedback?

As this does block a lot of following qm/qxp work for a long time, hopefully we
can get some feedback/guidance from Stephen.

BTW, this patchset is already used in NXP internal 5.4 release although it's missed
5.4 LTS kernel.

Regards
Aisheng

> Shawn

Re: clk: imx: clock driver for imx8qm?

[Fabio Estevam]

Hi Aisheng,

On Mon, Feb 17, 2020 at 4:31 AM Aisheng Dong <aisheng.dong@nxp.com> wrote:

> I remember I addressed all Stephen's comments in the last round of review
> which is marked in the V5 resend change log.
> https://www.spinics.net/lists/arm-kernel/msg769365.html
>
> But I can double check it.
> Should I re-send after a checking or wait for Stephen's feedback?

I think it is a good idea to resend the series.

Thanks