linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: Specify IOMEM dependency for HSDK pll driver
@ 2020-06-30  4:32 David Gow
  2020-07-11 16:28 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: David Gow @ 2020-06-30  4:32 UTC (permalink / raw)
  To: Eugeniy Paltsev, Michael Turquette, Stephen Boyd
  Cc: Brendan Higgins, linux-clk, linux-kernel, David Gow

The HSDK pll driver uses the devm_ioremap_resource function, but does
not specify a dependency on IOMEM in Kconfig. This causes a build
failure on architectures without IOMEM, for example, UML (notably with
make allyesconfig).

Fix this by making CONFIG_CLK_HSDK depend on CONFIG_IOMEM.

Signed-off-by: David Gow <davidgow@google.com>
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 69934c0c3dd8..326f91b2dda9 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -50,6 +50,7 @@ source "drivers/clk/versatile/Kconfig"
 config CLK_HSDK
 	bool "PLL Driver for HSDK platform"
 	depends on OF || COMPILE_TEST
+	depends on IOMEM
 	help
 	  This driver supports the HSDK core, system, ddr, tunnel and hdmi PLLs
 	  control.
-- 
2.27.0.212.ge8ba1cc988-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: Specify IOMEM dependency for HSDK pll driver
  2020-06-30  4:32 [PATCH] clk: Specify IOMEM dependency for HSDK pll driver David Gow
@ 2020-07-11 16:28 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2020-07-11 16:28 UTC (permalink / raw)
  To: David Gow, Eugeniy Paltsev, Michael Turquette
  Cc: Brendan Higgins, linux-clk, linux-kernel, David Gow

Quoting David Gow (2020-06-29 21:32:14)
> The HSDK pll driver uses the devm_ioremap_resource function, but does
> not specify a dependency on IOMEM in Kconfig. This causes a build
> failure on architectures without IOMEM, for example, UML (notably with
> make allyesconfig).
> 
> Fix this by making CONFIG_CLK_HSDK depend on CONFIG_IOMEM.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---

Applied to clk-fixes

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-11 16:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30  4:32 [PATCH] clk: Specify IOMEM dependency for HSDK pll driver David Gow
2020-07-11 16:28 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).