[PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

[PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

[David Gow]

The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
function, but does not specify a dependency on IOMEM in Kconfig. This
causes a build failure on architectures without IOMEM, for example, UML
(notably with make allyesconfig).

Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.

Signed-off-by: David Gow <davidgow@google.com>
---
 drivers/staging/clocking-wizard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/clocking-wizard/Kconfig b/drivers/staging/clocking-wizard/Kconfig
index 04be22dca9b6..69cf51445f08 100644
--- a/drivers/staging/clocking-wizard/Kconfig
+++ b/drivers/staging/clocking-wizard/Kconfig
@@ -5,6 +5,6 @@
 
 config COMMON_CLK_XLNX_CLKWZRD
 	tristate "Xilinx Clocking Wizard"
-	depends on COMMON_CLK && OF
+	depends on COMMON_CLK && OF && IOMEM
 	help
 	  Support for the Xilinx Clocking Wizard IP core clock generator.
-- 
2.27.0.212.ge8ba1cc988-goog

Re: [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

[Stephen Boyd]

Quoting David Gow (2020-06-29 21:45:17)
> The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
> function, but does not specify a dependency on IOMEM in Kconfig. This
> causes a build failure on architectures without IOMEM, for example, UML
> (notably with make allyesconfig).
> 
> Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---

This driver is in the process of being destaged to drivers/clk/

Greg, should I pick this one up?

>  drivers/staging/clocking-wizard/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Re: [PATCH] clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver

[Greg Kroah-Hartman]

On Sat, Jul 11, 2020 at 09:30:10AM -0700, Stephen Boyd wrote:
> Quoting David Gow (2020-06-29 21:45:17)
> > The Xilinx Clocking Wizard driver uses the devm_ioremap_resource
> > function, but does not specify a dependency on IOMEM in Kconfig. This
> > causes a build failure on architectures without IOMEM, for example, UML
> > (notably with make allyesconfig).
> > 
> > Fix this by making CONFIG_COMMON_CLK_XLNX_CLKWZRD depend on CONFIG_IOMEM.
> > 
> > Signed-off-by: David Gow <davidgow@google.com>
> > ---
> 
> This driver is in the process of being destaged to drivers/clk/
> 
> Greg, should I pick this one up?

Sure, if I haven't already.

thanks,

greg k-h