From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Edgar Bernardi Righi" <edgar.righi@lsitec.org.br>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] clk: actions: Fix AHPPREDIV-H-AHB clock chain on Owl S500 SoC
Date: Tue, 16 Mar 2021 20:50:14 +0200 [thread overview]
Message-ID: <20210316185014.GD1111731@BV030612LT> (raw)
In-Reply-To: <20210316054547.GD1798@thinkpad>
On Tue, Mar 16, 2021 at 11:15:47AM +0530, Manivannan Sadhasivam wrote:
> On Mon, Mar 08, 2021 at 07:18:29PM +0200, Cristian Ciocaltea wrote:
> > There are a few issues with the setup of the Actions Semi Owl S500 SoC's
> > clock chain involving AHPPREDIV, H and AHB clocks:
> >
> > * AHBPREDIV clock is defined as a muxer only, although it also acts as
> > a divider.
> > * H clock is defined as a standard divider, although the raw value zero
> > is not supported.
>
> What do you mean by not supported? The datasheet lists "0" as the valid divisor
> value for divide by 1.
Unfortunately CMU_BUSCLK1 is not documented in my S500 Datasheet
(Version: 1.6, 2016-03-07). Do you have a newer (or a more official)
one?
The reference xapp-le code snipped is:
static struct owl_div divider_H_CLK = {
.type = DIV_T_NATURE,
.range_from = 1, /* reserve H_CLK divsor 1 */
.range_to = 3,
.reg = &divbit_H_CLK,
};
Not sure why divisor 1 has been reserved..
Thanks,
Cristi
> Rest looks good to me.
>
> Thanks,
> Mani
>
[...]
next prev parent reply other threads:[~2021-03-16 18:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 17:18 [PATCH 0/6] Improve clock support for Actions S500 SoC Cristian Ciocaltea
2021-03-08 17:18 ` [PATCH 1/6] clk: actions: Fix UART clock dividers on Owl " Cristian Ciocaltea
2021-03-16 3:50 ` Manivannan Sadhasivam
2021-03-08 17:18 ` [PATCH 2/6] clk: actions: Fix SD clocks factor table " Cristian Ciocaltea
2021-03-16 3:58 ` Manivannan Sadhasivam
2021-03-16 18:14 ` Cristian Ciocaltea
2021-05-26 10:07 ` Manivannan Sadhasivam
2021-05-27 13:27 ` Cristian Ciocaltea
2021-03-08 17:18 ` [PATCH 3/6] clk: actions: Fix bisp_factor_table based clocks " Cristian Ciocaltea
2021-03-16 4:17 ` Manivannan Sadhasivam
2021-03-16 18:37 ` Cristian Ciocaltea
2021-05-26 10:18 ` Manivannan Sadhasivam
2021-05-27 13:34 ` Cristian Ciocaltea
2021-03-08 17:18 ` [PATCH 4/6] clk: actions: Fix AHPPREDIV-H-AHB clock chain " Cristian Ciocaltea
2021-03-16 5:45 ` Manivannan Sadhasivam
2021-03-16 18:50 ` Cristian Ciocaltea [this message]
2021-05-26 10:12 ` Manivannan Sadhasivam
2021-05-27 13:45 ` Cristian Ciocaltea
2021-03-08 17:18 ` [PATCH 5/6] dt-bindings: clock: Add NIC and ETHERNET bindings for Actions " Cristian Ciocaltea
2021-03-16 22:00 ` Rob Herring
2021-03-08 17:18 ` [PATCH 6/6] clk: actions: Add NIC and ETHERNET clock support " Cristian Ciocaltea
2021-03-16 5:52 ` Manivannan Sadhasivam
2021-03-16 19:02 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316185014.GD1111731@BV030612LT \
--to=cristian.ciocaltea@gmail.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).