From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: <neil.armstrong@linaro.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<jbrunet@baylibre.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <khilman@baylibre.com>,
<conor+dt@kernel.org>, <kernel@sberdevices.ru>,
<sdfw_system_team@sberdevices.ru>, <rockosov@gmail.com>,
<linux-amlogic@lists.infradead.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Oleg Lyovin <ovlevin@sberdevices.ru>
Subject: Re: [PATCH v1 5/6] arm64: dts: meson: a1: introduce UART_AO mux definitions
Date: Wed, 28 Jun 2023 17:51:10 +0300 [thread overview]
Message-ID: <20230628145110.a7igezu7ts2aymkd@CAB-WSD-L081021> (raw)
In-Reply-To: <c41d2d9f-7ddd-160d-d455-ba4fece7ff93@linaro.org>
Neil, Martin,
On Mon, Jun 26, 2023 at 03:34:38PM +0200, neil.armstrong@linaro.org wrote:
> Hi,
>
> On 25/06/2023 23:07, Martin Blumenstingl wrote:
> > On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
> > >
> > > From: Oleg Lyovin <ovlevin@sberdevices.ru>
> > >
> > > The Amlogic A1 has a UART_AO port, which can be used, for example, for
> > > BT HCI H4 connection.
> > >
> > > This patch adds mux definitions for it.
> > In the past we've only taken the pinctrl definitions if we have a
> > board that uses them.
> > Neil, do we still have the same policy in place? If so this patch
> > should be sent with the series that adds support for your A1 board.
>
> Yes and no, if the work is done I'll take it, but yeah since upstream linux
> hates dead code, let's only define what's necessary.
>
I'll prepare the patches for ad401 reference board, and share the in the
next patch series version.
> >
> > > Signed-off-by: Oleg Lyovin <ovlevin@sberdevices.ru>
> > > Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> > > ---
> > > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > > index 0efd922ca7e1..3eb6aa9c00e0 100644
> > > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > > @@ -118,6 +118,22 @@ gpio: bank@400 {
> > > gpio-ranges = <&periphs_pinctrl 0 0 62>;
> > > };
> > >
> > > + uart_a_pins: uart_a {
> > Only our newer .dtsi (e.g. meson-g12-common.dtsi) are following the
> > pattern where node names should use dashes instead of underscores.
> > So please use: uart_a_pins: uart-a { ...
>
> The new scheme which should be use should be:
>
> uart_a_pins: uart-a-pins-state {
>
> but it wasn't enforced in the pinctrl yaml pushed by heiner, but for sure
> no underscores in the node name.
>
Okay, got it
> >
> > [...]
> > > + uart_a_cts_rts_pins: uart_a_cts_rts {
> > similar to the comment from above:
> > uart_a_cts_rts_pins: uart-a-cts-rts { ...
> >
> > > + mux {
> > > + groups = "uart_a_cts",
> > > + "uart_a_rts";
> > > + function = "uart_a";
> > > + bias-pull-down;
> > Out of curiosity: is this pull down needed on all boards or just specific ones?
> > It seems like all other SoCs use bias-disable for the RTS/CTS pins.
> >
> >
> > Best regards,
> > Martin
>
--
Thank you,
Dmitry
next prev parent reply other threads:[~2023-06-28 14:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 20:16 [PATCH v1 0/6] arm64: dts: meson: a1: introduce several peripheral IPs Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 1/6] arm64: dts: meson: a1: introduce PLL and Peripherals clk controllers Dmitry Rokosov
2023-06-25 21:00 ` Martin Blumenstingl
2023-06-28 14:18 ` Dmitry Rokosov
2023-06-28 20:51 ` Martin Blumenstingl
2023-06-07 20:16 ` [PATCH v1 2/6] arm64: dts: meson: a1: support USB controller in OTG mode Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk Dmitry Rokosov
2023-06-25 20:50 ` Martin Blumenstingl
2023-06-28 14:20 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 4/6] arm64: dts: meson: a1: introduce SPI Flash Controller Dmitry Rokosov
2023-06-25 21:03 ` Martin Blumenstingl
2023-06-28 14:23 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 5/6] arm64: dts: meson: a1: introduce UART_AO mux definitions Dmitry Rokosov
2023-06-25 21:07 ` Martin Blumenstingl
2023-06-26 13:34 ` neil.armstrong
2023-06-28 14:51 ` Dmitry Rokosov [this message]
2023-06-28 14:49 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 6/6] arm64: dts: meson: a1: add eMMC controller and its pins Dmitry Rokosov
2023-06-25 21:11 ` Martin Blumenstingl
2023-06-26 13:36 ` neil.armstrong
2023-06-28 14:28 ` Dmitry Rokosov
2023-06-23 8:22 ` [PATCH v1 0/6] arm64: dts: meson: a1: introduce several peripheral IPs Dmitry Rokosov
2023-06-23 8:49 ` Krzysztof Kozlowski
2023-06-23 11:23 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628145110.a7igezu7ts2aymkd@CAB-WSD-L081021 \
--to=ddrokosov@sberdevices.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=ovlevin@sberdevices.ru \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=sboyd@kernel.org \
--cc=sdfw_system_team@sberdevices.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).