linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Tero Kristo <t-kristo@ti.com>
Cc: <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	"H . Nikolaus Schaller" <hns@goldelico.com>,
	Matthijs van Duin <matthijsvanduin@gmail.com>
Subject: Re: [PATCH] clk: ti: omap5: Add missing AESS clock
Date: Wed, 15 Jan 2020 10:56:08 +0200	[thread overview]
Message-ID: <23f9723b-cb9e-8737-92c5-4c20bed55cf5@ti.com> (raw)
In-Reply-To: <20200114150607.18092-1-tony@atomide.com>



On 14/01/2020 17.06, Tony Lindgren wrote:
> Looks like we're missing AESS clock for omap5. This is similar to what
> omap4 has.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> Cc: Matthijs van Duin <matthijsvanduin@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  drivers/clk/ti/clk-54xx.c         | 15 +++++++++++++++
>  include/dt-bindings/clock/omap5.h |  1 +
>  2 files changed, 16 insertions(+)
> 
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -35,6 +35,20 @@ static const struct omap_clkctrl_reg_data omap5_dsp_clkctrl_regs[] __initconst =
>  	{ 0 },
>  };
>  
> +static const char * const omap5_aess_fclk_parents[] __initconst = {
> +	"abe_clk",
> +	NULL,
> +};
> +
> +static const struct omap_clkctrl_div_data omap5_aess_fclk_data __initconst = {
> +	.max_div = 2,
> +};
> +
> +static const struct omap_clkctrl_bit_data omap5_aess_bit_data[] __initconst = {
> +	{ 24, TI_CLK_DIVIDER, omap5_aess_fclk_parents, &omap5_aess_fclk_data },
> +	{ 0 },
> +};
> +
>  static const char * const omap5_dmic_gfclk_parents[] __initconst = {
>  	"abe_cm:clk:0018:26",
>  	"pad_clks_ck",
> @@ -122,6 +136,7 @@ static const struct omap_clkctrl_bit_data omap5_timer8_bit_data[] __initconst =
>  
>  static const struct omap_clkctrl_reg_data omap5_abe_clkctrl_regs[] __initconst = {
>  	{ OMAP5_L4_ABE_CLKCTRL, NULL, 0, "abe_iclk" },
> +	{ OMAP5_AESS_CLKCTRL, omap5_aess_bit_data, CLKF_SW_SUP, "abe_cm:clk:0008:24" },
>  	{ OMAP5_MCPDM_CLKCTRL, NULL, CLKF_SW_SUP, "pad_clks_ck" },
>  	{ OMAP5_DMIC_CLKCTRL, omap5_dmic_bit_data, CLKF_SW_SUP, "abe_cm:clk:0018:24" },
>  	{ OMAP5_MCBSP1_CLKCTRL, omap5_mcbsp1_bit_data, CLKF_SW_SUP, "abe_cm:clk:0028:24" },
> diff --git a/include/dt-bindings/clock/omap5.h b/include/dt-bindings/clock/omap5.h
> --- a/include/dt-bindings/clock/omap5.h
> +++ b/include/dt-bindings/clock/omap5.h
> @@ -16,6 +16,7 @@
>  
>  /* abe clocks */
>  #define OMAP5_L4_ABE_CLKCTRL	OMAP5_CLKCTRL_INDEX(0x20)
> +#define OMAP5_AESS_CLKCTRL	OMAP5_CLKCTRL_INDEX(0x28)
>  #define OMAP5_MCPDM_CLKCTRL	OMAP5_CLKCTRL_INDEX(0x30)
>  #define OMAP5_DMIC_CLKCTRL	OMAP5_CLKCTRL_INDEX(0x38)
>  #define OMAP5_MCBSP1_CLKCTRL	OMAP5_CLKCTRL_INDEX(0x48)
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-01-15  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 15:06 [PATCH] clk: ti: omap5: Add missing AESS clock Tony Lindgren
2020-01-15  8:56 ` Peter Ujfalusi [this message]
2020-01-21  7:33   ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23f9723b-cb9e-8737-92c5-4c20bed55cf5@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthijsvanduin@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).