[PATCH 0/2] clk: renesas: cpg-mssr: Small cleaups

[PATCH 0/2] clk: renesas: cpg-mssr: Small cleaups

[Geert Uytterhoeven]

	Hi Mike, Stephen,

Here are two small cleanups for the Renesas CPG/MSSR driver.
I plan to queue these in renesas-clk for v5.14.

Thanks!

Geert Uytterhoeven (2):
  clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions
  clk: renesas: cpg-mssr: Make srstclr[] comment block consistent

 drivers/clk/renesas/renesas-cpg-mssr.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions

[Geert Uytterhoeven]

The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are
incorrect for i >= 8 on R-Car Gen2 and Gen3.

As these are unused, and not planned to be used, just like the
corresponding Modem Module Stop Control Register definitions (MMSTPCR())
on R-Mobile APE6 (they are intended for the software running on the
Real-Time and Modem CPU cores), they can just be removed.

Reported-by: Hai Nguyen Pham <hai.pham.ud@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/renesas-cpg-mssr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index fc531d35b269d3cd..c3230398e1c1b596 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -100,12 +100,6 @@ static const u16 srcr_for_v3u[] = {
 	0x2C20, 0x2C24, 0x2C28, 0x2C2C, 0x2C30, 0x2C34, 0x2C38,
 };
 
-/* Realtime Module Stop Control Register offsets */
-#define RMSTPCR(i)	(smstpcr[i] - 0x20)
-
-/* Modem Module Stop Control Register offsets (r8a73a4) */
-#define MMSTPCR(i)	(smstpcr[i] + 0x20)
-
 /* Software Reset Clearing Register offsets */
 
 static const u16 srstclr[] = {
-- 
2.25.1

Re: [PATCH 1/2] clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions

[Stephen Boyd]

Quoting Geert Uytterhoeven (2021-05-04 02:17:21)
> The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are
> incorrect for i >= 8 on R-Car Gen2 and Gen3.
> 
> As these are unused, and not planned to be used, just like the
> corresponding Modem Module Stop Control Register definitions (MMSTPCR())
> on R-Mobile APE6 (they are intended for the software running on the
> Real-Time and Modem CPU cores), they can just be removed.
> 
> Reported-by: Hai Nguyen Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>

[PATCH 2/2] clk: renesas: cpg-mssr: Make srstclr[] comment block consistent

[Geert Uytterhoeven]

Make the style of the comment block for the Software Reset Clearing
Register offsets consistent with the comment blocks for the other
register offsets.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/renesas-cpg-mssr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index c3230398e1c1b596..21f762aa213135d4 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -100,7 +100,9 @@ static const u16 srcr_for_v3u[] = {
 	0x2C20, 0x2C24, 0x2C28, 0x2C2C, 0x2C30, 0x2C34, 0x2C38,
 };
 
-/* Software Reset Clearing Register offsets */
+/*
+ * Software Reset Clearing Register offsets
+ */
 
 static const u16 srstclr[] = {
 	0x940, 0x944, 0x948, 0x94C, 0x950, 0x954, 0x958, 0x95C,
-- 
2.25.1

Re: [PATCH 2/2] clk: renesas: cpg-mssr: Make srstclr[] comment block consistent

[Stephen Boyd]

Quoting Geert Uytterhoeven (2021-05-04 02:17:22)
> Make the style of the comment block for the Software Reset Clearing
> Register offsets consistent with the comment blocks for the other
> register offsets.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>