clk: bcm2835: Checking a clk_register() call in bcm2835_clk_probe()

* clk: bcm2835: Checking a clk_register() call in bcm2835_clk_probe()
@ 2019-10-18 18:42 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2019-10-18 18:42 UTC (permalink / raw)
  To: linux-clk, linux-rpi-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, Eric Anholt, Florian Fainelli,
	Matthias Brugger, Maxime Ripard, Michael Turquette,
	Nicolas Saenz Julienne, Scott Branden, Stefan Wahren,
	Stephen Boyd, Ray Jui
  Cc: LKML, kernel-janitors, Aditya Pakki, Kangjie Lu, Navid Emamdoost,
	Stephen McCamant

Hello,

I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “bcm2835_clk_probe” contains still
an unchecked call of the member function “clk_register”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/bcm/clk-bcm2835.c?id=7571438a4868e7cb09d698ab52e54f9722020eef#n2243
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/clk/bcm/clk-bcm2835.c#L2243

How do you think about to improve it?

* Which error code would you like to return for a failed
  clock registration at this place?

* Will it be needed to delete any information about clocks
  as exception handling?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread