From: <Nicolas.Ferre@microchip.com>
To: <Eugen.Hristev@microchip.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <alexandre.belloni@bootlin.com>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH] clk: at91: sam9x60-pll: adapt PMC_PLL_ACR default value
Date: Tue, 12 Nov 2019 10:38:35 +0000 [thread overview]
Message-ID: <67fc1d0b-5280-3bd6-10ba-0a303b4dc064@microchip.com> (raw)
In-Reply-To: <1573478913-19737-1-git-send-email-eugen.hristev@microchip.com>
On 11/11/2019 at 14:28, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Product datasheet recommends different values for UPLL and PLLA analog control
> register.
> Adapt accordingly.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Best regards,
Nicolas
> ---
>
> datasheet link http://ww1.microchip.com/downloads/en/DeviceDoc/SAM9X60-Data-Sheet-DS60001579A.pdf
> chapter 57.7.10 optimal setting of the PLLA and PLLUTMI
>
> drivers/clk/at91/clk-sam9x60-pll.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c
> index 34b8178..dfb354a 100644
> --- a/drivers/clk/at91/clk-sam9x60-pll.c
> +++ b/drivers/clk/at91/clk-sam9x60-pll.c
> @@ -25,7 +25,8 @@
> #define PMC_PLL_CTRL1_MUL_MSK GENMASK(30, 24)
>
> #define PMC_PLL_ACR 0x18
> -#define PMC_PLL_ACR_DEFAULT 0x1b040010UL
> +#define PMC_PLL_ACR_DEFAULT_UPLL 0x12020010UL
> +#define PMC_PLL_ACR_DEFAULT_PLLA 0x00020010UL
> #define PMC_PLL_ACR_UTMIVR BIT(12)
> #define PMC_PLL_ACR_UTMIBG BIT(13)
> #define PMC_PLL_ACR_LOOP_FILTER_MSK GENMASK(31, 24)
> @@ -88,7 +89,10 @@ static int sam9x60_pll_prepare(struct clk_hw *hw)
> }
>
> /* Recommended value for PMC_PLL_ACR */
> - val = PMC_PLL_ACR_DEFAULT;
> + if (pll->characteristics->upll)
> + val = PMC_PLL_ACR_DEFAULT_UPLL;
> + else
> + val = PMC_PLL_ACR_DEFAULT_PLLA;
> regmap_write(regmap, PMC_PLL_ACR, val);
>
> regmap_write(regmap, PMC_PLL_CTRL1,
>
--
Nicolas Ferre
next prev parent reply other threads:[~2019-11-12 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 13:28 [PATCH] clk: at91: sam9x60-pll: adapt PMC_PLL_ACR default value Eugen.Hristev
2019-11-12 10:38 ` Nicolas.Ferre [this message]
2020-01-06 3:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fc1d0b-5280-3bd6-10ba-0a303b4dc064@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).