* [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call
@ 2019-09-26 10:45 Peter Ujfalusi
2019-10-02 8:21 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2019-09-26 10:45 UTC (permalink / raw)
To: t-kristo, mturquette; +Cc: sboyd, linux-omap, linux-clk, linux-kernel
ti_clk_register() calls it already so the driver should not create
duplicated alias.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/clk/ti/clk-dra7-atl.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index a01ca9395179..c0e0ee974151 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -207,11 +207,6 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
clk = ti_clk_register(NULL, &clk_hw->hw, node->name);
if (!IS_ERR(clk)) {
- ret = ti_clk_add_alias(NULL, clk, node->name);
- if (ret) {
- clk_unregister(clk);
- goto cleanup;
- }
of_clk_add_provider(node, of_clk_src_simple_get, clk);
kfree(parent_names);
return;
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call
2019-09-26 10:45 [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call Peter Ujfalusi
@ 2019-10-02 8:21 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2019-10-02 8:21 UTC (permalink / raw)
To: t-kristo, mturquette; +Cc: sboyd, linux-omap, linux-clk, linux-kernel
On 26/09/2019 13.45, Peter Ujfalusi wrote:
> ti_clk_register() calls it already so the driver should not create
> duplicated alias.
This patch will leave 'ret' as unused in of_dra7_atl_clock_setup(), I'll
send v2 in a minute or so.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/clk/ti/clk-dra7-atl.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index a01ca9395179..c0e0ee974151 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -207,11 +207,6 @@ static void __init of_dra7_atl_clock_setup(struct device_node *node)
> clk = ti_clk_register(NULL, &clk_hw->hw, node->name);
>
> if (!IS_ERR(clk)) {
> - ret = ti_clk_add_alias(NULL, clk, node->name);
> - if (ret) {
> - clk_unregister(clk);
> - goto cleanup;
> - }
> of_clk_add_provider(node, of_clk_src_simple_get, clk);
> kfree(parent_names);
> return;
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-02 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 10:45 [PATCH] clk: ti: dra7-atl-clock: Remove ti_clk_add_alias call Peter Ujfalusi
2019-10-02 8:21 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).