From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>, Andreas Kemnade <andreas@kemnade.info>
Cc: Stephen Boyd <sboyd@kernel.org>, <bcousson@baylibre.com>,
<letux-kernel@openphoenux.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<mturquette@baylibre.com>, <paul@pwsan.com>
Subject: Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops
Date: Mon, 31 Dec 2018 09:23:01 +0200 [thread overview]
Message-ID: <76d9fc57-898b-53ba-1dca-78e5b5c9b2be@ti.com> (raw)
In-Reply-To: <20181228200229.GY6707@atomide.com>
On 28/12/2018 22:02, Tony Lindgren wrote:
> * Andreas Kemnade <andreas@kemnade.info> [181227 20:13]:
>> Hi,
>>
>> On Tue, 4 Dec 2018 08:45:57 -0800
>> Tony Lindgren <tony@atomide.com> wrote:
>>
>>> * Andreas Kemnade <andreas@kemnade.info> [181204 06:17]:
>>>> On Mon, 3 Dec 2018 07:39:10 -0800
>>>> Tony Lindgren <tony@atomide.com> wrote:
>>>>> The consumer device stays active just fine with PM runtime
>>>>> calls. So yes, the problem is keeping a clock controller forced
>>>>> active for the period of consumer device reset. Other than
>>>>> that typically autoidle can be just kept enabled.
>>>>>
>>>> Are we still talking about the same problem? Maybe I am losing track
>>>> here. Just to make sure.
>>>> The patch series was about disabling autoidle for devices which cannot
>>>> work with it during normal operation. Not during reset or something
>>>> like that.
>>>> Or is the keep-clock-active-during-reset just a requirement for bigger
>>>> restructuring ideas?
>>>
>>> Yeah there are two issues: The fix needed for the issue you brought up,
>>> and also how to let a reset driver to block autoidle for reset.
>>>
>> Hmm, is this set now waiting for the famous "somebody" fixing all
>> the stuff?
>
> Well I think we're still waiting on Tero to comment on this.
The only item requiring immediate fixing is the point Stephen made out,
removing the usage of CLK_IS_BASIC from this patch.
Afaics, the reset related concerns Tony has can be handled later.
-Tero
>
>> What are currently visible symptoms for the driver not blocking
>> autoidle for reset? Maybe I can at least test something there. I have
>> also omap5 here.
>
> Oh that's just for making drivers/reset drivers to work in
> the long run. Let's keep that separate from these fixes..
>
> Regards,
>
> Tony
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-12-31 7:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 20:31 [PATCH v2 0/3] mach-omap2: handle autoidle denial Andreas Kemnade
2018-11-10 20:31 ` [PATCH v2 1/3] clk: ti: add a usecount for autoidle Andreas Kemnade
2018-11-10 20:31 ` [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops Andreas Kemnade
2018-11-30 0:25 ` Stephen Boyd
2018-11-30 6:15 ` Andreas Kemnade
2018-11-30 7:20 ` Stephen Boyd
2018-11-30 7:35 ` Tero Kristo
2018-11-30 7:57 ` Stephen Boyd
2018-11-30 9:20 ` Tero Kristo
2018-11-30 12:17 ` Andreas Kemnade
2018-11-30 15:37 ` Tony Lindgren
2018-11-30 23:51 ` Stephen Boyd
2018-12-03 15:39 ` Tony Lindgren
2018-12-03 16:22 ` Andreas Kemnade
2018-12-04 16:45 ` Tony Lindgren
2018-12-27 20:12 ` Andreas Kemnade
2018-12-28 20:02 ` Tony Lindgren
2018-12-31 7:23 ` Tero Kristo [this message]
2018-12-31 8:30 ` Andreas Kemnade
2019-01-03 23:39 ` Stephen Boyd
2019-01-04 7:28 ` Tero Kristo
2019-01-11 22:49 ` Stephen Boyd
2019-01-14 8:25 ` Tero Kristo
2018-12-03 17:06 ` Stephen Boyd
2018-11-10 20:31 ` [PATCH v2 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that Andreas Kemnade
2018-11-30 0:26 ` [PATCH v2 0/3] mach-omap2: handle autoidle denial Stephen Boyd
2018-11-30 7:37 ` Tero Kristo
2018-11-30 7:57 ` Stephen Boyd
2018-11-30 9:21 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76d9fc57-898b-53ba-1dca-78e5b5c9b2be@ti.com \
--to=t-kristo@ti.com \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).