From: "A.s. Dong" <aisheng.dong@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH V4 02/11] clk: imx: scu: add scu clock common part
Date: Wed, 17 Oct 2018 15:27:57 +0000 [thread overview]
Message-ID: <AM0PR04MB4211F83EBE8EA339185C75BC80FF0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <153978883132.5275.17975663103503100871@swboyd.mtv.corp.google.com>
> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@kernel.org]
> Sent: Wednesday, October 17, 2018 11:07 PM
> Quoting A.s. Dong (2018-10-17 02:11:03)
> > > -----Original Message-----
> > > From: Stephen Boyd [mailto:sboyd@kernel.org]
> > > Sent: Wednesday, October 17, 2018 5:32 AM Quoting A.s. Dong
> > > (2018-10-14 01:07:45)
> > > > Add scu clock common part which will be used by client clock drivers.
> > > >
> > > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > > Cc: Sascha Hauer <kernel@pengutronix.de>
> > > > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > > > Cc: Stephen Boyd <sboyd@kernel.org>
> > > > Cc: Michael Turquette <mturquette@baylibre.com>
> > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > > ---
> > > > ChangeLog:
> > > > v3->v4:
> > > > * scu headfile path change
> > > > v2->v3:
> > > > * no changes
> > > > v1->v2:
> > > > * update function call name
> > > > ---
> > > > drivers/clk/imx/Kconfig | 2 ++
> > > > drivers/clk/imx/Makefile | 2 ++
> > > > drivers/clk/imx/scu/Kconfig | 5 +++++
> > > > drivers/clk/imx/scu/Makefile | 4 ++++
> > > > drivers/clk/imx/scu/clk-scu.c | 17 +++++++++++++++++
> > > > drivers/clk/imx/scu/clk-scu.h | 18 ++++++++++++++++++
> > >
> > > Why is scu nested one level deeper in the imx directory? Can't we
> > > just keep them all within imx toplevel directory?
> > >
> >
> > Mostly because SCU clocks are totally different from the legacy clocks.
> > (No much legacy things can be reused) So organized them together in a
> > deeper folder for clear separation and better maintenance
> >
> > Do you think we still should put them within imx toplevel directory
> > and mix them with Legacy clocks?
> >
>
> Yes. Or make a new imx-foo directory for your new fangled SoC clk driver code
> in drivers/clk/.
Okay, then let's still put them in the same imx directory.
Regards
Dong Aisheng
next prev parent reply other threads:[~2018-10-17 15:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 8:07 [PATCH V4 00/11] clk: imx: add imx8qxp clock support A.s. Dong
2018-10-14 8:07 ` [PATCH V4 01/11] clk: imx: add configuration option for mmio clks A.s. Dong
2018-10-14 8:07 ` [PATCH V4 02/11] clk: imx: scu: add scu clock common part A.s. Dong
2018-10-16 21:31 ` Stephen Boyd
2018-10-17 9:11 ` A.s. Dong
2018-10-17 15:07 ` Stephen Boyd
2018-10-17 15:27 ` A.s. Dong [this message]
2018-10-14 8:07 ` [PATCH V4 03/11] clk: imx: scu: add scu clock divider A.s. Dong
2018-10-16 21:26 ` Stephen Boyd
2018-10-17 8:56 ` A.s. Dong
2018-10-17 15:17 ` Stephen Boyd
2018-10-17 15:45 ` A.s. Dong
2018-10-17 16:05 ` Stephen Boyd
2018-10-18 2:35 ` A.s. Dong
2018-10-14 8:07 ` [PATCH V4 04/11] clk: imx: scu: add scu clock gpr divider A.s. Dong
2018-10-16 21:27 ` Stephen Boyd
2018-10-17 9:03 ` A.s. Dong
2018-10-17 15:17 ` Stephen Boyd
2018-10-14 8:07 ` [PATCH V4 05/11] clk: imx: scu: add scu clock gate A.s. Dong
2018-10-15 7:32 ` Sascha Hauer
2018-10-15 9:17 ` A.s. Dong
2018-10-15 9:53 ` Sascha Hauer
2018-10-15 15:30 ` A.s. Dong
2018-10-16 21:18 ` Stephen Boyd
2018-10-17 7:28 ` A.s. Dong
2018-10-14 8:07 ` [PATCH V4 06/11] clk: imx: scu: add scu clock gpr gate A.s. Dong
2018-10-14 8:08 ` [PATCH V4 07/11] clk: imx: scu: add scu clock mux A.s. Dong
2018-10-14 8:08 ` [PATCH V4 08/11] clk: imx: scu: add scu clock gpr mux A.s. Dong
2018-10-16 21:30 ` Stephen Boyd
2018-10-17 9:07 ` A.s. Dong
2018-10-17 15:18 ` Stephen Boyd
2018-10-14 8:08 ` [PATCH V4 09/11] clk: imx: add common imx_clk_hw_fixed functions A.s. Dong
2018-10-16 21:32 ` Stephen Boyd
2018-10-17 9:21 ` A.s. Dong
2018-10-17 15:18 ` Stephen Boyd
2018-10-14 8:08 ` [PATCH V4 10/11] clk: imx: add imx_check_clk_hws helper function A.s. Dong
2018-10-16 21:34 ` Stephen Boyd
2018-10-17 9:24 ` A.s. Dong
2018-10-14 8:08 ` [PATCH V4 11/11] clk: imx: add imx8qxp clk driver A.s. Dong
2018-10-16 21:38 ` Stephen Boyd
2018-10-17 9:43 ` A.s. Dong
2018-10-17 15:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4211F83EBE8EA339185C75BC80FF0@AM0PR04MB4211.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).