From: Peng Fan <peng.fan@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
Anson Huang <anson.huang@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>
Subject: RE: [PATCH V2 1/4] clk: imx: pll14xx: avoid glitch when set rate
Date: Mon, 9 Sep 2019 03:40:10 +0000 [thread overview]
Message-ID: <AM0PR04MB4481BCB4A02FC868F5B442E288B70@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190906172145.CAD3C20838@mail.kernel.org>
Hi Stephen,
> Subject: Re: [PATCH V2 1/4] clk: imx: pll14xx: avoid glitch when set rate
>
> Quoting Peng Fan (2019-08-26 02:42:14)
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to PLL1443XA and PLL1416X spec, "When BYPASS is 0 and RESETB
> > is changed from 0 to 1, FOUT starts to output unstable clock until
> > lock time passes. PLL1416X/PLL1443XA may generate a glitch at FOUT."
> >
> > So set BYPASS when RESETB is changed from 0 to 1 to avoid glitch.
> > In the end of set rate, BYPASS will be cleared.
> >
> > When prepare clock, also need to take care to avoid glitch. So we also
> > follow Spec to set BYPASS before RESETB changed from 0 to 1.
> > And add a check if the RESETB is already 0, directly return 0;
> >
> > Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc")
> > Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
>
> Please make cover letters for multi-patch series.
Just sent out v3 to include cover-letter, no other changes.
Thanks,
Peng.
prev parent reply other threads:[~2019-09-09 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 9:42 [PATCH V2 1/4] clk: imx: pll14xx: avoid glitch when set rate Peng Fan
2019-08-26 9:42 ` [PATCH V2 2/4] clk: imx: clk-pll14xx: unbypass PLL by default Peng Fan
2019-08-26 9:42 ` [PATCH V2 3/4] clk: imx: imx8mm: fix pll mux bit Peng Fan
2019-08-26 9:42 ` [PATCH V2 4/4] clk: imx: imx8mn: " Peng Fan
2019-09-06 17:21 ` [PATCH V2 1/4] clk: imx: pll14xx: avoid glitch when set rate Stephen Boyd
2019-09-09 3:40 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4481BCB4A02FC868F5B442E288B70@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).