* Re: [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks
[not found] <20190728152040.15323-1-daniel.baluta@nxp.com>
@ 2019-08-21 20:39 ` Leonard Crestez
[not found] ` <1571812158.5953.2.camel@nxp.com>
0 siblings, 1 reply; 2+ messages in thread
From: Leonard Crestez @ 2019-08-21 20:39 UTC (permalink / raw)
To: Daniel Baluta, shawnguo, Abel Vesa
Cc: s.hauer, festevam, dl-linux-imx, l.stach, ccaione, baruch,
andrew.smirnov, devicetree, linux-arm-kernel, linux-kernel,
S.j. Wang, angus, agx, Anson Huang, Peng Fan, Jacky Bai,
Stephen Boyd, linux-clk
On 28.07.2019 18:20, Daniel Baluta wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
>
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather then using clock
> consumer API in a clock provider driver.
>
> Note that by adding the initial rate setting for audio_pll1/audio_pll
> setting we need to remove it from imx8mq-librem5-devkit.dts
Setting default rates for audio_pll1 and audio_pll2 in soc dtsi makes a
lot of sense to me; the intention is for one to run at a multiple of
44.1k and another at a multiple of 48k.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 02fbd0625318..a55d72ba2e05 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -494,6 +494,25 @@
> clock-names = "ckil", "osc_25m", "osc_27m",
> "clk_ext1", "clk_ext2",
> "clk_ext3", "clk_ext4";
> + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL1>,
> + <&clk IMX8MQ_AUDIO_PLL2>,
> + <&clk IMX8MQ_CLK_AHB>,
> + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> + <&clk IMX8MQ_CLK_NOC>;
> + assigned-clock-parents = <0>,
> + <0>,
> + <0> > + <&clk IMX8MQ_SYS1_PLL_133M>,
> + <&clk IMX8MQ_SYS1_PLL_266M>,
> + <&clk IMX8MQ_SYS2_PLL_500M>,
> + <&clk IMX8MQ_CLK_27M>,
> + <&clk IMX8MQ_SYS1_PLL_800M>;
> + assigned-clock-rates = <593999999>,
> + <786432000>,
> + <722534400>;
The audio PLLs should run below 650 mHz so please use 393216000 and
361267200 instead of 786432000 and 722534400. For the 8mm equivalent see
commit 053a4ffe2988 ("clk: imx: imx8mm: fix audio pll setting").
You should also move the unbypassing of AUDIO_PLL1 and AUDIO_PLL2 here
just add two more assigned-clocks and assigned-clock-parents.
--
Regards,
Leonard
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks
[not found] ` <1571812158.5953.2.camel@nxp.com>
@ 2019-10-23 8:38 ` Leonard Crestez
0 siblings, 0 replies; 2+ messages in thread
From: Leonard Crestez @ 2019-10-23 8:38 UTC (permalink / raw)
To: Viorel Suman, Abel Vesa, Peng Fan
Cc: Daniel Baluta, shawnguo, dl-linux-imx, linux-kernel, ccaione,
devicetree, angus, festevam, agx, Jacky Bai, baruch,
andrew.smirnov, linux-arm-kernel, S.j. Wang, linux-clk, l.stach,
sboyd, Anson Huang, s.hauer
On 2019-10-23 9:29 AM, Viorel Suman wrote:
> On Mi, 2019-08-21 at 20:39 +0000, Leonard Crestez wrote:
>> The audio PLLs should run below 650 mHz so please use 393216000 and
>> 361267200 instead of 786432000 and 722534400. For the 8mm equivalent see
>> commit 053a4ffe2988 ("clk: imx: imx8mm: fix audio pll setting").
>
> Hi Leonard,
>
> Audio PLL IP on 8mm and 8mn is different than the Audio PLL IP on 8mq,
> so the requirement to run below 650 MHZ may not apply to 8mq.
This "max 650mHz" limit is from internal ADD and is also mentioned for
imx8mq.
Peng: you made the change in our internal tree, can you confirm this
requirement also applies to 8mq?
Viorel: Is there any impact from 393216000 vs 786432000 on PLL on audio?
As far as I can know this rate goes through various dividers anyway.
--
Regards,
Leonard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-23 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190728152040.15323-1-daniel.baluta@nxp.com>
2019-08-21 20:39 ` [PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks Leonard Crestez
[not found] ` <1571812158.5953.2.camel@nxp.com>
2019-10-23 8:38 ` Leonard Crestez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).