From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] clk: qcom: Add support for QDU1000 and QRU1000 RPMh clocks
Date: Sat, 1 Oct 2022 10:03:00 +0300 [thread overview]
Message-ID: <CAA8EJppBfYST2VQrv6-LZBvtLcNUMkpLgXcic-fSUzFXhiYbaA@mail.gmail.com> (raw)
In-Reply-To: <20221001030403.27659-5-quic_molvera@quicinc.com>
On Sat, 1 Oct 2022 at 06:05, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
> Add support for RMPh clocks for QDU1000 and QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> drivers/clk/qcom/clk-rpmh.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index c07cab6905cb..27d11ffac71e 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -628,6 +628,18 @@ static const struct clk_rpmh_desc clk_rpmh_sdx65 = {
> .num_clks = ARRAY_SIZE(sdx65_rpmh_clocks),
> };
>
> +DEFINE_CLK_RPMH_ARC(qdru1000, bi_tcxo, bi_tcxo_ao, "xo.lvl", 0x3, 1);
> +
> +static struct clk_hw *qdru1000_rpmh_clocks[] = {
> + [RPMH_CXO_CLK] = &qdru1000_bi_tcxo.hw,
> + [RPMH_CXO_CLK_A] = &qdru1000_bi_tcxo_ao.hw,
> +};
> +
> +static const struct clk_rpmh_desc clk_rpmh_qdru1000 = {
> + .clks = qdru1000_rpmh_clocks,
> + .num_clks = ARRAY_SIZE(qdru1000_rpmh_clocks),
> +};
> +
> static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec,
> void *data)
> {
> @@ -723,6 +735,8 @@ static const struct of_device_id clk_rpmh_match_table[] = {
> { .compatible = "qcom,sm8350-rpmh-clk", .data = &clk_rpmh_sm8350},
> { .compatible = "qcom,sm8450-rpmh-clk", .data = &clk_rpmh_sm8450},
> { .compatible = "qcom,sc7280-rpmh-clk", .data = &clk_rpmh_sc7280},
> + { .compatible = "qcom,qdu1000-rpmh-clk", .data = &clk_rpmh_qdru1000},
> + { .compatible = "qcom,qru1000-rpmh-clk", .data = &clk_rpmh_qdru1000},
Also the list isn't fully sorted, let's target that. Please move your
compat strings into the beginning.
> { }
> };
> MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
> --
> 2.37.3
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-10-01 7:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 3:03 [PATCH 0/5] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs Melody Olvera
2022-10-01 3:03 ` [PATCH 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings Melody Olvera
2022-10-01 9:24 ` Krzysztof Kozlowski
2022-10-03 18:47 ` Melody Olvera
2022-10-03 21:32 ` Dmitry Baryshkov
2022-10-11 22:11 ` Melody Olvera
2022-10-04 6:55 ` Krzysztof Kozlowski
2022-10-03 13:24 ` Rob Herring
2022-10-03 13:24 ` Rob Herring
2022-10-01 3:04 ` [PATCH 2/5] dt-bindings: clock: Add RPMHCC bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-01 6:59 ` Dmitry Baryshkov
2022-10-03 18:55 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 3/5] clk: qcom: Add QDU1000 and QRU1000 GCC support Melody Olvera
2022-10-01 7:10 ` Dmitry Baryshkov
2022-10-03 19:37 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 4/5] clk: qcom: Add support for QDU1000 and QRU1000 RPMh clocks Melody Olvera
2022-10-01 7:03 ` Dmitry Baryshkov [this message]
2022-10-03 19:40 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 5/5] dt-bindings: clock: Introduce pdc bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-01 6:58 ` Dmitry Baryshkov
2022-10-03 19:46 ` Melody Olvera
2022-10-01 9:22 ` Marc Zyngier
2022-10-03 19:47 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJppBfYST2VQrv6-LZBvtLcNUMkpLgXcic-fSUzFXhiYbaA@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).