From: Melody Olvera <quic_molvera@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings
Date: Mon, 3 Oct 2022 13:47:05 -0500 [thread overview]
Message-ID: <bb241d46-6f90-8604-e79d-30a1f3527ce4@quicinc.com> (raw)
In-Reply-To: <37926f0f-e176-929e-939a-cd43a031e224@linaro.org>
On 10/1/2022 4:24 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:03, Melody Olvera wrote:
>> Add device tree bindings for global clock controller on QDU1000 and
>> QRU1000 SoCs.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> .../bindings/clock/qcom,gcc-qdru1000.yaml | 74 ++++++++
>> include/dt-bindings/clock/qcom,gcc-qdru1000.h | 170 ++++++++++++++++++
>> 2 files changed, 244 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml
>> create mode 100644 include/dt-bindings/clock/qcom,gcc-qdru1000.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml
>> new file mode 100644
>> index 000000000000..d92f558d547c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-qdru.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller Binding for QDU1000 and QRU1000
> Drop "Binding"
Will do in v2.
>
>> +
>> +maintainers:
>> + - Melody Olvera <quic_molvera@quicinc.com>
>> +
>> +description: |
>> + Qualcomm global clock control module which supports the clocks, resets and
>> + power domains on QDU1000 and QRU1000
>> +
>> + See also:
>> + - dt-bindings/clock/qcom,gcc-qdru1000.h
> Full path
Understood.
>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,gcc-qdu1000
>> + - qcom,gcc-qru1000
>> +
>> + clocks:
>> + items:
>> + - description: Board XO source
>> + - description: Sleep clock source
>> + - description: PCIE 0 Pipe clock source (Optional clock)
> Skip "Optional clock"
>
>> + - description: PCIE 0 Phy Auxiliary clock source (Optional clock)
>> + - description: USB3 Phy wrapper pipe clock source (Optional clock)
>> + minItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: bi_tcxo
>> + - const: sleep_clk
>> + - const: pcie_0_pipe_clk # Optional clock
> Skip "Optional clock"
Will remove all optional clock instances.
>
>> + - const: pcie_0_phy_aux_clk # Optional clock
>> + - const: usb3_phy_wrapper_gcc_usb30_pipe_clk # Optional clock
>> + minItems: 2
>> +
>> + '#clock-cells':
>> + const: 1
>> +
>> + '#reset-cells':
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - '#clock-cells'
>> + - '#reset-cells'
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/qcom,rpmh.h>
>> + clock-controller@100000 {
>> + compatible = "qcom,gcc-qdu1000";
>> + reg = <0x00100000 0x001f4200>;
>> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&sleep_clk>;
>> + clock-names = "bi_tcxo", "sleep_clk";
>> + #clock-cells = <1>;
>> + #reset-cells = <1>;
>> + };
>> +
>> +...
>> diff --git a/include/dt-bindings/clock/qcom,gcc-qdru1000.h b/include/dt-bindings/clock/qcom,gcc-qdru1000.h
>> new file mode 100644
>> index 000000000000..cdc5d1a6a007
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/qcom,gcc-qdru1000.h
>> @@ -0,0 +1,170 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
> Dual license.
Good catch; will remove.
>
>
> Best regards,
> Krzysztof
Thanks,
Melody
next prev parent reply other threads:[~2022-10-03 18:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 3:03 [PATCH 0/5] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs Melody Olvera
2022-10-01 3:03 ` [PATCH 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings Melody Olvera
2022-10-01 9:24 ` Krzysztof Kozlowski
2022-10-03 18:47 ` Melody Olvera [this message]
2022-10-03 21:32 ` Dmitry Baryshkov
2022-10-11 22:11 ` Melody Olvera
2022-10-04 6:55 ` Krzysztof Kozlowski
2022-10-03 13:24 ` Rob Herring
2022-10-03 13:24 ` Rob Herring
2022-10-01 3:04 ` [PATCH 2/5] dt-bindings: clock: Add RPMHCC bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-01 6:59 ` Dmitry Baryshkov
2022-10-03 18:55 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 3/5] clk: qcom: Add QDU1000 and QRU1000 GCC support Melody Olvera
2022-10-01 7:10 ` Dmitry Baryshkov
2022-10-03 19:37 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 4/5] clk: qcom: Add support for QDU1000 and QRU1000 RPMh clocks Melody Olvera
2022-10-01 7:03 ` Dmitry Baryshkov
2022-10-03 19:40 ` Melody Olvera
2022-10-01 3:04 ` [PATCH 5/5] dt-bindings: clock: Introduce pdc bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-01 6:58 ` Dmitry Baryshkov
2022-10-03 19:46 ` Melody Olvera
2022-10-01 9:22 ` Marc Zyngier
2022-10-03 19:47 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb241d46-6f90-8604-e79d-30a1f3527ce4@quicinc.com \
--to=quic_molvera@quicinc.com \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).