linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
@ 2020-02-12 10:16 Geert Uytterhoeven
  2020-02-12 10:51 ` Greentime Hu
  2020-02-12 17:07 ` Stephen Boyd
  0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-02-12 10:16 UTC (permalink / raw)
  To: Nick Hu, Greentime Hu, Vincent Chen
  Cc: linux-clk, linux-kernel, Geert Uytterhoeven

The Andes platform code is not a clock provider, and just needs to call
of_clk_init().

Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/nds32/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
index ac9d78ce3a818926..574a3d0a853980a9 100644
--- a/arch/nds32/kernel/time.c
+++ b/arch/nds32/kernel/time.c
@@ -2,7 +2,7 @@
 // Copyright (C) 2005-2017 Andes Technology Corporation
 
 #include <linux/clocksource.h>
-#include <linux/clk-provider.h>
+#include <linux/of_clk.h>
 
 void __init time_init(void)
 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
  2020-02-12 10:16 [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h> Geert Uytterhoeven
@ 2020-02-12 10:51 ` Greentime Hu
  2020-02-12 12:25   ` Geert Uytterhoeven
  2020-02-12 17:07 ` Stephen Boyd
  1 sibling, 1 reply; 6+ messages in thread
From: Greentime Hu @ 2020-02-12 10:51 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Nick Hu, Vincent Chen, linux-clk, Linux Kernel Mailing List

Geert Uytterhoeven <geert+renesas@glider.be> 於 2020年2月12日 週三 下午6:16寫道：
>
> The Andes platform code is not a clock provider, and just needs to call
> of_clk_init().
>
> Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/nds32/kernel/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
> index ac9d78ce3a818926..574a3d0a853980a9 100644
> --- a/arch/nds32/kernel/time.c
> +++ b/arch/nds32/kernel/time.c
> @@ -2,7 +2,7 @@
>  // Copyright (C) 2005-2017 Andes Technology Corporation
>
>  #include <linux/clocksource.h>
> -#include <linux/clk-provider.h>
> +#include <linux/of_clk.h>
>
>  void __init time_init(void)
>  {

Thank you, Geert.

Let me know if you like to put in your tree or nds32's.
Acked-by: Greentime Hu <green.hu@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
  2020-02-12 10:51 ` Greentime Hu
@ 2020-02-12 12:25   ` Geert Uytterhoeven
  2020-06-23  8:49     ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-02-12 12:25 UTC (permalink / raw)
  To: Greentime Hu
  Cc: Geert Uytterhoeven, Nick Hu, Vincent Chen, linux-clk,
	Linux Kernel Mailing List

Hi Greentime,

On Wed, Feb 12, 2020 at 11:52 AM Greentime Hu <green.hu@gmail.com> wrote:
> Geert Uytterhoeven <geert+renesas@glider.be> 於 2020年2月12日 週三 下午6:16寫道：
> > The Andes platform code is not a clock provider, and just needs to call
> > of_clk_init().
> >
> > Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  arch/nds32/kernel/time.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
> > index ac9d78ce3a818926..574a3d0a853980a9 100644
> > --- a/arch/nds32/kernel/time.c
> > +++ b/arch/nds32/kernel/time.c
> > @@ -2,7 +2,7 @@
> >  // Copyright (C) 2005-2017 Andes Technology Corporation
> >
> >  #include <linux/clocksource.h>
> > -#include <linux/clk-provider.h>
> > +#include <linux/of_clk.h>
> >
> >  void __init time_init(void)
> >  {
>
> Thank you, Geert.
>
> Let me know if you like to put in your tree or nds32's.
> Acked-by: Greentime Hu <green.hu@gmail.com>

Please take it in the nds32 tree.
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
  2020-02-12 10:16 [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h> Geert Uytterhoeven
  2020-02-12 10:51 ` Greentime Hu
@ 2020-02-12 17:07 ` Stephen Boyd
  1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2020-02-12 17:07 UTC (permalink / raw)
  To: Geert Uytterhoeven, Greentime Hu, Nick Hu, Vincent Chen
  Cc: linux-clk, linux-kernel, Geert Uytterhoeven

Quoting Geert Uytterhoeven (2020-02-12 02:16:51)
> The Andes platform code is not a clock provider, and just needs to call
> of_clk_init().
> 
> Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
  2020-02-12 12:25   ` Geert Uytterhoeven
@ 2020-06-23  8:49     ` Geert Uytterhoeven
  2020-06-23 12:29       ` Greentime Hu
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-06-23  8:49 UTC (permalink / raw)
  To: Greentime Hu
  Cc: Nick Hu, Vincent Chen, linux-clk, Linux Kernel Mailing List,
	Krzysztof Kozlowski

Hi Greentime,

On Wed, Feb 12, 2020 at 1:25 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Feb 12, 2020 at 11:52 AM Greentime Hu <green.hu@gmail.com> wrote:
> > Geert Uytterhoeven <geert+renesas@glider.be> 於 2020年2月12日 週三 下午6:16寫道：
> > > The Andes platform code is not a clock provider, and just needs to call
> > > of_clk_init().
> > >
> > > Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  arch/nds32/kernel/time.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
> > > index ac9d78ce3a818926..574a3d0a853980a9 100644
> > > --- a/arch/nds32/kernel/time.c
> > > +++ b/arch/nds32/kernel/time.c
> > > @@ -2,7 +2,7 @@
> > >  // Copyright (C) 2005-2017 Andes Technology Corporation
> > >
> > >  #include <linux/clocksource.h>
> > > -#include <linux/clk-provider.h>
> > > +#include <linux/of_clk.h>
> > >
> > >  void __init time_init(void)
> > >  {
> >
> > Thank you, Geert.
> >
> > Let me know if you like to put in your tree or nds32's.
> > Acked-by: Greentime Hu <green.hu@gmail.com>
>
> Please take it in the nds32 tree.
> Thanks!

And so you did. But it disappeared after June 12, when the nds32 tree
was reset to v5.7, losing the following 2 commits:

de9a5650b611014c52b1ad994f63253593d8eddf nds32: Replace
<linux/clk-provider.h> by <linux/of_clk.h>
d785c5a324cd8812720a409dc85050558281a567 nds32: configs: Cleanup
CONFIG_CROSS_COMPILE

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h>
  2020-06-23  8:49     ` Geert Uytterhoeven
@ 2020-06-23 12:29       ` Greentime Hu
  0 siblings, 0 replies; 6+ messages in thread
From: Greentime Hu @ 2020-06-23 12:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Nick Hu, Vincent Chen, linux-clk, Linux Kernel Mailing List,
	Krzysztof Kozlowski

Geert Uytterhoeven <geert@linux-m68k.org> 於 2020年6月23日 週二 下午4:49寫道：
>
> Hi Greentime,
>
> On Wed, Feb 12, 2020 at 1:25 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Feb 12, 2020 at 11:52 AM Greentime Hu <green.hu@gmail.com> wrote:
> > > Geert Uytterhoeven <geert+renesas@glider.be> 於 2020年2月12日 週三 下午6:16寫道：
> > > > The Andes platform code is not a clock provider, and just needs to call
> > > > of_clk_init().
> > > >
> > > > Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > >  arch/nds32/kernel/time.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/nds32/kernel/time.c b/arch/nds32/kernel/time.c
> > > > index ac9d78ce3a818926..574a3d0a853980a9 100644
> > > > --- a/arch/nds32/kernel/time.c
> > > > +++ b/arch/nds32/kernel/time.c
> > > > @@ -2,7 +2,7 @@
> > > >  // Copyright (C) 2005-2017 Andes Technology Corporation
> > > >
> > > >  #include <linux/clocksource.h>
> > > > -#include <linux/clk-provider.h>
> > > > +#include <linux/of_clk.h>
> > > >
> > > >  void __init time_init(void)
> > > >  {
> > >
> > > Thank you, Geert.
> > >
> > > Let me know if you like to put in your tree or nds32's.
> > > Acked-by: Greentime Hu <green.hu@gmail.com>
> >
> > Please take it in the nds32 tree.
> > Thanks!
>
> And so you did. But it disappeared after June 12, when the nds32 tree
> was reset to v5.7, losing the following 2 commits:
>
> de9a5650b611014c52b1ad994f63253593d8eddf nds32: Replace
> <linux/clk-provider.h> by <linux/of_clk.h>
> d785c5a324cd8812720a409dc85050558281a567 nds32: configs: Cleanup
> CONFIG_CROSS_COMPILE
>

Thank you, Geert. It must be my mistake when I try to clean the next branch.
I just put these 2 commits back.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-23 12:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 10:16 [PATCH] nds32: Replace <linux/clk-provider.h> by <linux/of_clk.h> Geert Uytterhoeven
2020-02-12 10:51 ` Greentime Hu
2020-02-12 12:25   ` Geert Uytterhoeven
2020-06-23  8:49     ` Geert Uytterhoeven
2020-06-23 12:29       ` Greentime Hu
2020-02-12 17:07 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).