From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained
Date: Thu, 6 Feb 2020 09:06:53 +0100 [thread overview]
Message-ID: <CAMuHMdXLFq+Ebtmfsw45=08U7X5Fv9ZvsHO=q-PcNON51HjqaQ@mail.gmail.com> (raw)
In-Reply-To: <20200205225145.5486220730@mail.kernel.org>
Hi Stephen,
On Wed, Feb 5, 2020 at 11:51 PM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> > Depending on include order:
> >
> > include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > unsigned int of_clk_get_parent_count(struct device_node *np);
> > ^~~~~~~~~~~
> > include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > const char *of_clk_get_parent_name(struct device_node *np, int index);
> > ^~~~~~~~~~~
> > include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> > void of_clk_init(const struct of_device_id *matches);
> > ^~~~~~~~~~~~
> >
> > Fix this by adding forward declarations for struct device_node and
> > struct of_device_id.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Noticed when cleaning up some platform code.
> > I am not aware of this being triggered in upstream, but this will become a
> > dependency for these cleanups.
>
> So apply for fixes? I'll just throw it in now.
Yep.
> Applied to clk-next.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2020-02-06 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:46 [PATCH] of: clk: Make <linux/of_clk.h> self-contained Geert Uytterhoeven
2020-02-05 22:51 ` Stephen Boyd
2020-02-06 8:06 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXLFq+Ebtmfsw45=08U7X5Fv9ZvsHO=q-PcNON51HjqaQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).