From: Michael Stapelberg <michael@stapelberg.ch>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2
Date: Thu, 23 Sep 2021 09:05:40 +0200 [thread overview]
Message-ID: <CANnVG6mEL+Lzir=K7zBTWVV5zXsdokWCHvsTkM2McGHTO3HEfQ@mail.gmail.com> (raw)
In-Reply-To: <CANnVG6kFC7q_dDDp4rRZsJz=paHKy2STn9127LE=JJOf2kW2TA@mail.gmail.com>
I can confirm that this patch series (applied to linux commit
58e2cf5d794616b84f591d4d1276c8953278ce24) works for me — my Raspberry
Pi 3 still boots fine (without HDMI connected).
Thanks!
On Wed, 22 Sept 2021 at 23:18, Michael Stapelberg <michael@stapelberg.ch> wrote:
>
>
> On Wed, 22 Sept 2021 at 14:54, Maxime Ripard <maxime@cerno.tech> wrote:
>>
>> Hi,
>>
>> Here's another attempt at fixing the complete CPU stall while retrieving the
>> HDMI connector status when the connector is disabled.
>>
>> This was fixed already, but eventually got reverted by Linus due to the same
>> symptom happening in another situation. This was likely (but not confirmed by
>> the reporter) due to the kernel being booted without an HDMI display connected,
>> in which case the firmware won't initialise the HDMI State Machine clock.
>
>
> Sorry for the lack of confirmation: yes, this problem was encountered when no HDMI display was connected.
>
> I’ll try testing your patch series tomorrow.
>
> Thanks for taking care of this!
>
>>
>>
>> This is fixed by patch 3. However, further changes in the clock drivers were
>> needed for clk_set_min_rate to be used, which are patches 1 and 2.
>>
>> Finally, patches 4 and 5 are the original patches that were reverted. Patch 4
>> got a small modification to move the clk_set_min_rate() call before the HSM
>> clock is enabled.
>>
>> Let me know what you think,
>> Maxime
>>
>> Maxime Ripard (5):
>> clk: bcm-2835: Pick the closest clock rate
>> clk: bcm-2835: Remove rounding up the dividers
>> drm/vc4: hdmi: Set a default HSM rate
>> drm/vc4: hdmi: Move the HSM clock enable to runtime_pm
>> drm/vc4: hdmi: Make sure the controller is powered in detect
>>
>> drivers/clk/bcm/clk-bcm2835.c | 13 ++---
>> drivers/gpu/drm/vc4/vc4_hdmi.c | 90 ++++++++++++++++++++++++----------
>> 2 files changed, 68 insertions(+), 35 deletions(-)
>>
>> --
>> 2.31.1
>>
>
>
> --
> Best regards,
> Michael
--
Best regards,
Michael
next prev parent reply other threads:[~2021-09-23 7:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:54 [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Maxime Ripard
2021-09-22 12:54 ` [PATCH 1/5] clk: bcm-2835: Pick the closest clock rate Maxime Ripard
2021-09-28 16:26 ` nicolas saenz julienne
2021-09-30 18:08 ` Stephen Boyd
2021-10-13 12:59 ` (subset) " Maxime Ripard
2021-09-22 12:54 ` [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Maxime Ripard
2021-09-28 16:26 ` nicolas saenz julienne
2021-09-29 13:27 ` Maxime Ripard
2021-09-30 18:09 ` Stephen Boyd
2021-10-13 12:59 ` (subset) " Maxime Ripard
2021-09-22 12:54 ` [PATCH 3/5] drm/vc4: hdmi: Set a default HSM rate Maxime Ripard
2021-09-30 15:51 ` nicolas saenz julienne
2021-10-13 12:59 ` (subset) " Maxime Ripard
2021-09-22 12:54 ` [PATCH 4/5] drm/vc4: hdmi: Move the HSM clock enable to runtime_pm Maxime Ripard
2021-09-30 15:54 ` nicolas saenz julienne
2021-10-13 12:59 ` (subset) " Maxime Ripard
2021-09-22 12:54 ` [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect Maxime Ripard
2021-09-30 15:55 ` nicolas saenz julienne
2021-10-13 12:59 ` (subset) " Maxime Ripard
[not found] ` <CANnVG6kFC7q_dDDp4rRZsJz=paHKy2STn9127LE=JJOf2kW2TA@mail.gmail.com>
2021-09-23 7:05 ` Michael Stapelberg [this message]
2021-09-24 7:40 ` [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Maxime Ripard
2021-09-28 13:05 ` Maxime Ripard
2021-09-30 18:09 ` Stephen Boyd
2021-09-30 18:39 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANnVG6mEL+Lzir=K7zBTWVV5zXsdokWCHvsTkM2McGHTO3HEfQ@mail.gmail.com' \
--to=michael@stapelberg.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=nsaenz@kernel.org \
--cc=sboyd@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).