[PATCH 0/4] clk: renesas: Clock Domain fixes

[PATCH 0/4] clk: renesas: Clock Domain fixes

[Geert Uytterhoeven]

	Hi Mike, Stephen,

This patch series contains fixes for the Renesas CPG/MSTP and CPG/MSSR
Clock Domains:
  1. Postpone calls to pm_genpd_init(), as all local setup of the
     generic_pm_domain structure should have been completed before
     calling pm_genpd_init(),
  2. Use always-on governor for Clock Domains, to prevent their status
     from being shown as "off-0" in
     /sys/kernel/debug/pm_genpd/pm_genpd_summary.

I plan to queue these up with other clock updates in
clk-renesas-for-v4.7, and send a pull request later.

Thanks for your comments!

Geert Uytterhoeven (4):
  clk: renesas: mstp: Postpone call to pm_genpd_init()
  clk: renesas: mstp: Use always-on governor for Clock Domain
  clk: renesas: cpg-mssr: Postpone call to pm_genpd_init()
  clk: renesas: cpg-mssr: Use always-on governor for Clock Domain

 drivers/clk/renesas/clk-mstp.c         | 3 +--
 drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/4] clk: renesas: mstp: Postpone call to pm_genpd_init()

[Geert Uytterhoeven]

All local setup of the generic_pm_domain structure should have been
completed before calling pm_genpd_init().

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/clk-mstp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
index 8b597b9a380442e8..969fbb61ab07b9b8 100644
--- a/drivers/clk/renesas/clk-mstp.c
+++ b/drivers/clk/renesas/clk-mstp.c
@@ -316,11 +316,10 @@ void __init cpg_mstp_add_clk_domain(struct device_node *np)
 		return;
 
 	pd->name = np->name;
-
 	pd->flags = GENPD_FLAG_PM_CLK;
-	pm_genpd_init(pd, &simple_qos_governor, false);
 	pd->attach_dev = cpg_mstp_attach_dev;
 	pd->detach_dev = cpg_mstp_detach_dev;
+	pm_genpd_init(pd, &simple_qos_governor, false);
 
 	of_genpd_add_provider_simple(np, pd);
 }
-- 
1.9.1

[PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain

[Geert Uytterhoeven]

As a pure Clock Domain does not have the concept of powering the domain
itself, the CPG/MSTP driver does not provide power_off() and power_on()
callbacks.
However, the genpd core may still perform a dummy power down, causing
/sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
status being "off-0".

Use the always-on governor to make sure the domain is never powered
down, and always shows up as "on" in pm_genpd_summary.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/clk-mstp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
index 969fbb61ab07b9b8..5093a250650dad6d 100644
--- a/drivers/clk/renesas/clk-mstp.c
+++ b/drivers/clk/renesas/clk-mstp.c
@@ -319,7 +319,7 @@ void __init cpg_mstp_add_clk_domain(struct device_node *np)
 	pd->flags = GENPD_FLAG_PM_CLK;
 	pd->attach_dev = cpg_mstp_attach_dev;
 	pd->detach_dev = cpg_mstp_detach_dev;
-	pm_genpd_init(pd, &simple_qos_governor, false);
+	pm_genpd_init(pd, &pm_domain_always_on_gov, false);
 
 	of_genpd_add_provider_simple(np, pd);
 }
-- 
1.9.1

[PATCH 3/4] clk: renesas: cpg-mssr: Postpone call to pm_genpd_init()

[Geert Uytterhoeven]

All local setup of the generic_pm_domain structure should have been
completed before calling pm_genpd_init().

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 1f2dc3629f0e02a0..0d595311c659a741 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -493,9 +493,9 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev,
 	genpd = &pd->genpd;
 	genpd->name = np->name;
 	genpd->flags = GENPD_FLAG_PM_CLK;
-	pm_genpd_init(genpd, &simple_qos_governor, false);
 	genpd->attach_dev = cpg_mssr_attach_dev;
 	genpd->detach_dev = cpg_mssr_detach_dev;
+	pm_genpd_init(genpd, &simple_qos_governor, false);
 	cpg_mssr_clk_domain = pd;
 
 	of_genpd_add_provider_simple(np, genpd);
-- 
1.9.1

[PATCH 4/4] clk: renesas: cpg-mssr: Use always-on governor for Clock Domain

[Geert Uytterhoeven]

As a pure Clock Domain does not have the concept of powering the domain
itself, the CPG/MSTP driver does not provide power_off() and power_on()
callbacks.
However, the genpd core may still perform a dummy power down, causing
/sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
status being "off-0".

Use the always-on governor to make sure the domain is never powered
down, and always shows up as "on" in pm_genpd_summary.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 0d595311c659a741..210cd744a7a97bbd 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -495,7 +495,7 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev,
 	genpd->flags = GENPD_FLAG_PM_CLK;
 	genpd->attach_dev = cpg_mssr_attach_dev;
 	genpd->detach_dev = cpg_mssr_detach_dev;
-	pm_genpd_init(genpd, &simple_qos_governor, false);
+	pm_genpd_init(genpd, &pm_domain_always_on_gov, false);
 	cpg_mssr_clk_domain = pd;
 
 	of_genpd_add_provider_simple(np, genpd);
-- 
1.9.1

Re: [PATCH 0/4] clk: renesas: Clock Domain fixes

[Laurent Pinchart]

Hi Geert,

Thank you for the patches.

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

On Tuesday 26 Apr 2016 09:09:38 Geert Uytterhoeven wrote:
> 	Hi Mike, Stephen,
> 
> This patch series contains fixes for the Renesas CPG/MSTP and CPG/MSSR
> Clock Domains:
>   1. Postpone calls to pm_genpd_init(), as all local setup of the
>      generic_pm_domain structure should have been completed before
>      calling pm_genpd_init(),
>   2. Use always-on governor for Clock Domains, to prevent their status
>      from being shown as "off-0" in
>      /sys/kernel/debug/pm_genpd/pm_genpd_summary.
> 
> I plan to queue these up with other clock updates in
> clk-renesas-for-v4.7, and send a pull request later.
> 
> Thanks for your comments!
> 
> Geert Uytterhoeven (4):
>   clk: renesas: mstp: Postpone call to pm_genpd_init()
>   clk: renesas: mstp: Use always-on governor for Clock Domain
>   clk: renesas: cpg-mssr: Postpone call to pm_genpd_init()
>   clk: renesas: cpg-mssr: Use always-on governor for Clock Domain
> 
>  drivers/clk/renesas/clk-mstp.c         | 3 +--
>  drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain

[Ulf Hansson]

On 26 April 2016 at 09:09, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> As a pure Clock Domain does not have the concept of powering the domain
> itself, the CPG/MSTP driver does not provide power_off() and power_on()
> callbacks.
> However, the genpd core may still perform a dummy power down, causing
> /sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
> status being "off-0".
>
> Use the always-on governor to make sure the domain is never powered
> down, and always shows up as "on" in pm_genpd_summary.

Hmm.

Hypothetically, what if the clock domain would be a subdomain, where
its master is able to power down? Using the always on governor would
prevent the master from power off as well.

I am wondering whether we should introduce some similar as
pm_runtime_no_callbacks() but for the generic PM domain instead.

What do you think?

>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/clk/renesas/clk-mstp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
> index 969fbb61ab07b9b8..5093a250650dad6d 100644
> --- a/drivers/clk/renesas/clk-mstp.c
> +++ b/drivers/clk/renesas/clk-mstp.c
> @@ -319,7 +319,7 @@ void __init cpg_mstp_add_clk_domain(struct device_node *np)
>         pd->flags = GENPD_FLAG_PM_CLK;
>         pd->attach_dev = cpg_mstp_attach_dev;
>         pd->detach_dev = cpg_mstp_detach_dev;
> -       pm_genpd_init(pd, &simple_qos_governor, false);
> +       pm_genpd_init(pd, &pm_domain_always_on_gov, false);
>
>         of_genpd_add_provider_simple(np, pd);
>  }
> --
> 1.9.1
>

Kind regards
Uffe

Re: [PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain

[Geert Uytterhoeven]

Hi Ulf,

On Wed, Apr 27, 2016 at 3:59 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 26 April 2016 at 09:09, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> As a pure Clock Domain does not have the concept of powering the domain
>> itself, the CPG/MSTP driver does not provide power_off() and power_on()
>> callbacks.
>> However, the genpd core may still perform a dummy power down, causing
>> /sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
>> status being "off-0".
>>
>> Use the always-on governor to make sure the domain is never powered
>> down, and always shows up as "on" in pm_genpd_summary.
>
> Hmm.
>
> Hypothetically, what if the clock domain would be a subdomain, where
> its master is able to power down? Using the always on governor would
> prevent the master from power off as well.

That's correct. However, on R-Mobile/R-Car SoCs, this is not the case, so it
doesn't matter here.

> I am wondering whether we should introduce some similar as
> pm_runtime_no_callbacks() but for the generic PM domain instead.
>
> What do you think?

In my case, the domain is not managed by its parent, to there's no such
analogy.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/4] clk: renesas: Clock Domain fixes

[Ulf Hansson]

On 26 April 2016 at 09:09, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>         Hi Mike, Stephen,
>
> This patch series contains fixes for the Renesas CPG/MSTP and CPG/MSSR
> Clock Domains:
>   1. Postpone calls to pm_genpd_init(), as all local setup of the
>      generic_pm_domain structure should have been completed before
>      calling pm_genpd_init(),
>   2. Use always-on governor for Clock Domains, to prevent their status
>      from being shown as "off-0" in
>      /sys/kernel/debug/pm_genpd/pm_genpd_summary.
>
> I plan to queue these up with other clock updates in
> clk-renesas-for-v4.7, and send a pull request later.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (4):
>   clk: renesas: mstp: Postpone call to pm_genpd_init()
>   clk: renesas: mstp: Use always-on governor for Clock Domain
>   clk: renesas: cpg-mssr: Postpone call to pm_genpd_init()
>   clk: renesas: cpg-mssr: Use always-on governor for Clock Domain
>
>  drivers/clk/renesas/clk-mstp.c         | 3 +--
>  drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)

For the series:

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

Re: [PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain

[Ulf Hansson]

On 27 April 2016 at 16:04, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Ulf,
>
> On Wed, Apr 27, 2016 at 3:59 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 26 April 2016 at 09:09, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>>> As a pure Clock Domain does not have the concept of powering the domain
>>> itself, the CPG/MSTP driver does not provide power_off() and power_on()
>>> callbacks.
>>> However, the genpd core may still perform a dummy power down, causing
>>> /sys/kernel/debug/pm_genpd/pm_genpd_summary to report the domain's
>>> status being "off-0".
>>>
>>> Use the always-on governor to make sure the domain is never powered
>>> down, and always shows up as "on" in pm_genpd_summary.
>>
>> Hmm.
>>
>> Hypothetically, what if the clock domain would be a subdomain, where
>> its master is able to power down? Using the always on governor would
>> prevent the master from power off as well.
>
> That's correct. However, on R-Mobile/R-Car SoCs, this is not the case, so it
> doesn't matter here.
>
>> I am wondering whether we should introduce some similar as
>> pm_runtime_no_callbacks() but for the generic PM domain instead.
>>
>> What do you think?
>
> In my case, the domain is not managed by its parent, to there's no such
> analogy.

Ok, fair enough.

This looks good to me!

Kind regards
Uffe

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds