From: Stefano Stabellini <sstabellini@kernel.org>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: linux-arm-kernel@lists.infradead.org,
Julien Grall <julien.grall@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v2] xen/arm: register clocks used by the hypervisor
Date: Tue, 5 Jul 2016 14:53:01 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1607051449370.2575@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1467282752-14053-1-git-send-email-dirk.behme@de.bosch.com>
On Thu, 30 Jun 2016, Dirk Behme wrote:
> Some clocks might be used by the Xen hypervisor and not by the Linux
> kernel. If these are not registered by the Linux kernel, they might be
> disabled by clk_disable_unused() as the kernel doesn't know that they
> are used. The clock of the serial console handled by Xen is one
> example for this. It might be disabled by clk_disable_unused() which
> stops the whole serial output, even from Xen, then.
>
> Up to now, the workaround for this has been to use the Linux kernel
> command line parameter 'clk_ignore_unused'. See Xen bug
>
> http://bugs.xenproject.org/xen/bug/45
>
> too.
>
> To fix this, we will add the "unused" clocks in Xen to the hypervisor
> node. The Linux kernel has to register the clocks from the hypervisor
> node, then.
>
> Therefore, check if there is a "clocks" entry in the hypervisor node
> and if so register the given clocks to the Linux kernel clock
> framework and with this mark them as used. This prevents the clocks
> from being disabled.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
> Changes in v2:
> - Rebase against git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.8
> - Add changes to Documentation/devicetree/bindings/arm/xen.txt
>
> Documentation/devicetree/bindings/arm/xen.txt | 11 +++++++
> arch/arm/xen/enlighten.c | 47 +++++++++++++++++++++++++++
> 2 files changed, 58 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt
> index c9b9321..55dfd3b 100644
> --- a/Documentation/devicetree/bindings/arm/xen.txt
> +++ b/Documentation/devicetree/bindings/arm/xen.txt
> @@ -17,6 +17,17 @@ the following properties:
> A GIC node is also required.
> This property is unnecessary when booting Dom0 using ACPI.
>
> +Optional properties:
> +
> +- clocks: one or more clocks to be registered.
> + Xen hypervisor drivers might replace native drivers, resulting in
> + clocks not registered by these native drivers. To avoid that these
> + unregistered clocks are disabled, then, e.g. by clk_disable_unused(),
> + register them in the hypervisor node.
> + An example for this are the clocks of the serial driver. If the clocks
> + used by the serial hardware interface are not registered by the serial
> + driver the serial output might stop once clk_disable_unused() is called.
What if we use the "status" property of the clocks? Could we set it to
"disabled" in Xen? Would that be enough for Linux to leave them alone?
> To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
> under /hypervisor with following parameters:
>
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 47acb36..5c546d0 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -24,6 +24,7 @@
> #include <linux/of_fdt.h>
> #include <linux/of_irq.h>
> #include <linux/of_address.h>
> +#include <linux/clk-provider.h>
> #include <linux/cpuidle.h>
> #include <linux/cpufreq.h>
> #include <linux/cpu.h>
> @@ -444,6 +445,52 @@ static int __init xen_pm_init(void)
> }
> late_initcall(xen_pm_init);
>
> +/*
> + * Check if we want to register some clocks, that they
> + * are not freed because unused by clk_disable_unused().
> + * E.g. the serial console clock.
> + */
> +static int __init xen_arm_register_clks(void)
> +{
> + struct clk *clk;
> + struct device_node *xen_node;
> + unsigned int i, count;
> + int ret = 0;
> +
> + xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
> + if (!xen_node) {
> + pr_err("Xen support was detected before, but it has disappeared\n");
> + return -EINVAL;
> + }
> +
> + count = of_clk_get_parent_count(xen_node);
> + if (!count)
> + goto out;
> +
> + for (i = 0; i < count; i++) {
> + clk = of_clk_get(xen_node, i);
> + if (IS_ERR(clk)) {
> + pr_err("Xen failed to register clock %i. Error: %li\n",
> + i, PTR_ERR(clk));
> + ret = PTR_ERR(clk);
> + goto out;
> + }
> +
> + ret = clk_prepare_enable(clk);
> + if (ret < 0) {
> + pr_err("Xen failed to enable clock %i. Error: %i\n",
> + i, ret);
> + goto out;
> + }
> + }
> +
> + ret = 0;
> +
> +out:
> + of_node_put(xen_node);
> + return ret;
> +}
> +late_initcall(xen_arm_register_clks);
>
> /* empty stubs */
> void xen_arch_pre_suspend(void) { }
> --
> 2.8.0
>
next prev parent reply other threads:[~2016-07-05 13:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 10:32 [PATCH v2] xen/arm: register clocks used by the hypervisor Dirk Behme
2016-06-30 14:21 ` Mark Rutland
2016-06-30 14:56 ` [Xen-devel] " Dirk Behme
2016-06-30 15:18 ` Mark Rutland
2016-06-30 15:33 ` Julien Grall
2016-07-05 13:53 ` Stefano Stabellini [this message]
2016-07-05 13:54 ` Julien Grall
2016-07-05 14:02 ` Julien Grall
2016-07-05 14:04 ` Stefano Stabellini
2016-07-05 14:08 ` Julien Grall
2016-07-05 14:37 ` Stefano Stabellini
2016-07-06 1:34 ` Michael Turquette
2016-07-06 13:10 ` Julien Grall
2016-07-06 13:16 ` Stefano Stabellini
2016-07-06 13:26 ` Julien Grall
2016-07-06 13:48 ` Mark Rutland
2016-07-06 20:42 ` Michael Turquette
2016-07-07 7:32 ` Dirk Behme
2016-07-08 2:50 ` Michael Turquette
2016-07-08 5:51 ` [Xen-devel] " Dirk Behme
2016-07-08 9:21 ` Julien Grall
2016-07-08 6:48 ` Dirk Behme
2016-07-08 9:35 ` Julien Grall
2016-07-05 6:50 Dirk Behme
2016-07-05 10:39 ` Mark Rutland
2016-07-05 10:45 ` Dirk Behme
2016-07-05 11:07 ` Mark Rutland
2016-07-06 23:38 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1607051449370.2575@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).