[PATCH v5 0/6] Initialise thermal framework and cpufreq earlier during boot

[PATCH v5 0/6] Initialise thermal framework and cpufreq earlier during boot

[Amit Kucheria]

Changes since v4:
- Collect Acks
- Pick the US spelling for 'initialis^Hze' consistently.

Changes since v3:
- Init schedutil governor earlier too
- Simplified changes to thermal_init() error path
- Collects Acks

Changes since v2:
- Missed one patch when posting v2. Respinning.

Changes since v1:
- Completely get rid of netlink support in the thermal framework.
- This changes the early init patch to a single line - change to
  core_initcall. Changed authorship of patch since it is nothing like the
  original. Lina, let me know if you feel otherwise.
- I've tested to make sure that the qcom-cpufreq-hw driver continues to
  work correctly as a module so this won't impact Android's GKI plans.
- Collected Acks

Device boot needs to be as fast as possible while keeping under the thermal
envelope. Now that thermal framework is built-in to the kernel, we can
initialize it earlier to enable thermal mitigation during boot.

We also need the cpufreq HW drivers to be initialised earlier to act as the
cooling devices. This series only converts over the qcom-hw driver to
initialize earlier but can be extended to other platforms as well.

Amit Kucheria (6):
  thermal: Remove netlink support
  thermal: Initialize thermal subsystem earlier
  cpufreq: Initialize the governors in core_initcall
  cpufreq: Initialize cpufreq-dt driver earlier
  clk: qcom: Initialize clock drivers earlier
  cpufreq: qcom-hw: Move driver initialization earlier

 .../driver-api/thermal/sysfs-api.rst          |  26 +----
 drivers/clk/qcom/clk-rpmh.c                   |   2 +-
 drivers/clk/qcom/gcc-qcs404.c                 |   2 +-
 drivers/clk/qcom/gcc-sdm845.c                 |   2 +-
 drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +-
 drivers/cpufreq/cpufreq_conservative.c        |   2 +-
 drivers/cpufreq/cpufreq_ondemand.c            |   2 +-
 drivers/cpufreq/cpufreq_performance.c         |   2 +-
 drivers/cpufreq/cpufreq_powersave.c           |   2 +-
 drivers/cpufreq/cpufreq_userspace.c           |   2 +-
 drivers/cpufreq/qcom-cpufreq-hw.c             |   2 +-
 drivers/thermal/thermal_core.c                | 103 +-----------------
 include/linux/thermal.h                       |  11 --
 kernel/sched/cpufreq_schedutil.c              |   2 +-
 14 files changed, 19 insertions(+), 143 deletions(-)

-- 
2.17.1

[PATCH v5 5/6] clk: qcom: Initialize clock drivers earlier

[Amit Kucheria]

Initialize the clock drivers on sdm845 and qcs404 in core_initcall so we
can have earlier access to cpufreq during booting.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/clk/qcom/clk-rpmh.c   | 2 +-
 drivers/clk/qcom/gcc-qcs404.c | 2 +-
 drivers/clk/qcom/gcc-sdm845.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 96a36f6ff667d..20d4258f125b9 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -487,7 +487,7 @@ static int __init clk_rpmh_init(void)
 {
 	return platform_driver_register(&clk_rpmh_driver);
 }
-subsys_initcall(clk_rpmh_init);
+core_initcall(clk_rpmh_init);
 
 static void __exit clk_rpmh_exit(void)
 {
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index bd32212f37e64..9b0c4ce2ef4ec 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -2855,7 +2855,7 @@ static int __init gcc_qcs404_init(void)
 {
 	return platform_driver_register(&gcc_qcs404_driver);
 }
-subsys_initcall(gcc_qcs404_init);
+core_initcall(gcc_qcs404_init);
 
 static void __exit gcc_qcs404_exit(void)
 {
diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c
index 95be125c3bddf..49dcff1af2db1 100644
--- a/drivers/clk/qcom/gcc-sdm845.c
+++ b/drivers/clk/qcom/gcc-sdm845.c
@@ -3628,7 +3628,7 @@ static int __init gcc_sdm845_init(void)
 {
 	return platform_driver_register(&gcc_sdm845_driver);
 }
-subsys_initcall(gcc_sdm845_init);
+core_initcall(gcc_sdm845_init);
 
 static void __exit gcc_sdm845_exit(void)
 {
-- 
2.17.1

Re: [PATCH v5 0/6] Initialise thermal framework and cpufreq earlier during boot

[Zhang Rui]

Hi,

Given that all the patches in this series have got the ACK from the
subsystem maintainers, I suppose we can take all the patches through
thermal tree, right?

thanks,
rui

On Mon, 2019-10-21 at 17:45 +0530, Amit Kucheria wrote:
> Changes since v4:
> - Collect Acks
> - Pick the US spelling for 'initialis^Hze' consistently.
> 
> Changes since v3:
> - Init schedutil governor earlier too
> - Simplified changes to thermal_init() error path
> - Collects Acks
> 
> Changes since v2:
> - Missed one patch when posting v2. Respinning.
> 
> Changes since v1:
> - Completely get rid of netlink support in the thermal framework.
> - This changes the early init patch to a single line - change to
>   core_initcall. Changed authorship of patch since it is nothing like
> the
>   original. Lina, let me know if you feel otherwise.
> - I've tested to make sure that the qcom-cpufreq-hw driver continues
> to
>   work correctly as a module so this won't impact Android's GKI
> plans.
> - Collected Acks
> 
> Device boot needs to be as fast as possible while keeping under the
> thermal
> envelope. Now that thermal framework is built-in to the kernel, we
> can
> initialize it earlier to enable thermal mitigation during boot.
> 
> We also need the cpufreq HW drivers to be initialised earlier to act
> as the
> cooling devices. This series only converts over the qcom-hw driver to
> initialize earlier but can be extended to other platforms as well.
> 
> Amit Kucheria (6):
>   thermal: Remove netlink support
>   thermal: Initialize thermal subsystem earlier
>   cpufreq: Initialize the governors in core_initcall
>   cpufreq: Initialize cpufreq-dt driver earlier
>   clk: qcom: Initialize clock drivers earlier
>   cpufreq: qcom-hw: Move driver initialization earlier
> 
>  .../driver-api/thermal/sysfs-api.rst          |  26 +----
>  drivers/clk/qcom/clk-rpmh.c                   |   2 +-
>  drivers/clk/qcom/gcc-qcs404.c                 |   2 +-
>  drivers/clk/qcom/gcc-sdm845.c                 |   2 +-
>  drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +-
>  drivers/cpufreq/cpufreq_conservative.c        |   2 +-
>  drivers/cpufreq/cpufreq_ondemand.c            |   2 +-
>  drivers/cpufreq/cpufreq_performance.c         |   2 +-
>  drivers/cpufreq/cpufreq_powersave.c           |   2 +-
>  drivers/cpufreq/cpufreq_userspace.c           |   2 +-
>  drivers/cpufreq/qcom-cpufreq-hw.c             |   2 +-
>  drivers/thermal/thermal_core.c                | 103 +---------------
> --
>  include/linux/thermal.h                       |  11 --
>  kernel/sched/cpufreq_schedutil.c              |   2 +-
>  14 files changed, 19 insertions(+), 143 deletions(-)
> 

Re: [PATCH v5 0/6] Initialise thermal framework and cpufreq earlier during boot

[Amit Kucheria]

Hi Rui,

I'm assuming that since Rafael acked it, he is ok with this going thru
the thermal tree.

Regards,
Amit

On Thu, Oct 31, 2019 at 8:12 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> Hi,
>
> Given that all the patches in this series have got the ACK from the
> subsystem maintainers, I suppose we can take all the patches through
> thermal tree, right?
>
> thanks,
> rui
>
> On Mon, 2019-10-21 at 17:45 +0530, Amit Kucheria wrote:
> > Changes since v4:
> > - Collect Acks
> > - Pick the US spelling for 'initialis^Hze' consistently.
> >
> > Changes since v3:
> > - Init schedutil governor earlier too
> > - Simplified changes to thermal_init() error path
> > - Collects Acks
> >
> > Changes since v2:
> > - Missed one patch when posting v2. Respinning.
> >
> > Changes since v1:
> > - Completely get rid of netlink support in the thermal framework.
> > - This changes the early init patch to a single line - change to
> >   core_initcall. Changed authorship of patch since it is nothing like
> > the
> >   original. Lina, let me know if you feel otherwise.
> > - I've tested to make sure that the qcom-cpufreq-hw driver continues
> > to
> >   work correctly as a module so this won't impact Android's GKI
> > plans.
> > - Collected Acks
> >
> > Device boot needs to be as fast as possible while keeping under the
> > thermal
> > envelope. Now that thermal framework is built-in to the kernel, we
> > can
> > initialize it earlier to enable thermal mitigation during boot.
> >
> > We also need the cpufreq HW drivers to be initialised earlier to act
> > as the
> > cooling devices. This series only converts over the qcom-hw driver to
> > initialize earlier but can be extended to other platforms as well.
> >
> > Amit Kucheria (6):
> >   thermal: Remove netlink support
> >   thermal: Initialize thermal subsystem earlier
> >   cpufreq: Initialize the governors in core_initcall
> >   cpufreq: Initialize cpufreq-dt driver earlier
> >   clk: qcom: Initialize clock drivers earlier
> >   cpufreq: qcom-hw: Move driver initialization earlier
> >
> >  .../driver-api/thermal/sysfs-api.rst          |  26 +----
> >  drivers/clk/qcom/clk-rpmh.c                   |   2 +-
> >  drivers/clk/qcom/gcc-qcs404.c                 |   2 +-
> >  drivers/clk/qcom/gcc-sdm845.c                 |   2 +-
> >  drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +-
> >  drivers/cpufreq/cpufreq_conservative.c        |   2 +-
> >  drivers/cpufreq/cpufreq_ondemand.c            |   2 +-
> >  drivers/cpufreq/cpufreq_performance.c         |   2 +-
> >  drivers/cpufreq/cpufreq_powersave.c           |   2 +-
> >  drivers/cpufreq/cpufreq_userspace.c           |   2 +-
> >  drivers/cpufreq/qcom-cpufreq-hw.c             |   2 +-
> >  drivers/thermal/thermal_core.c                | 103 +---------------
> > --
> >  include/linux/thermal.h                       |  11 --
> >  kernel/sched/cpufreq_schedutil.c              |   2 +-
> >  14 files changed, 19 insertions(+), 143 deletions(-)
> >
>

Re: [PATCH v5 0/6] Initialise thermal framework and cpufreq earlier during boot

[Daniel Lezcano]

Hi Zhang,

On 31/10/2019 03:42, Zhang Rui wrote:
> Hi,
> 
> Given that all the patches in this series have got the ACK from the
> subsystem maintainers, I suppose we can take all the patches through
> thermal tree, right?

Right




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog