* [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver
@ 2022-07-12 12:59 Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
The gcc-msm8939 driver is a copy/paste of the gcc-msm8916 for the good
reason that msm8936/msm8939 are an expanded version of msm8916. Reviewing
the qcom driver though there are some obvious missing/wrong frequencies
which a simple side-by-side comparison can show up.
This series captures that side-by-side and transmits into updated frequency
tables.
Bryan O'Donoghue (6):
clk: qcom: gcc-msm8939: Fix weird field spacing in
ftbl_gcc_camss_cci_clk
clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock
clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions
clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies
clk: qcom: gcc-msm8939: Add missing MDSS MDP clock frequencies
clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies
drivers/clk/qcom/gcc-msm8939.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
--
2.36.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:11 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock Bryan O'Donoghue
` (5 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
Adding a new item to this frequency table I see the existing indentation is
incorrect.
Fixes: 1664014e4679 ("clk: qcom: gcc-msm8939: Add MSM8939 Generic Clock Controller")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 39ebb443ae3d5..628b476a5468e 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1002,7 +1002,7 @@ static struct clk_rcg2 blsp1_uart2_apps_clk_src = {
};
static const struct freq_tbl ftbl_gcc_camss_cci_clk[] = {
- F(19200000, P_XO, 1, 0, 0),
+ F(19200000, P_XO, 1, 0, 0),
{ }
};
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:12 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions Bryan O'Donoghue
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
Standard CCI bus clock clocks are 19.2 MHz and 37.5 MHz. We already define
the 19.2 MHz but are missing the 37.5 MHz.
See qcom kernel drivers/clk/qcom/clock-gcc-8936.c::ftbl_gcc_camss_cci_clk[]
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 628b476a5468e..6a3e2326c72a3 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1003,6 +1003,7 @@ static struct clk_rcg2 blsp1_uart2_apps_clk_src = {
static const struct freq_tbl ftbl_gcc_camss_cci_clk[] = {
F(19200000, P_XO, 1, 0, 0),
+ F(37500000, P_GPLL0, 1, 3, 64),
{ }
};
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
` (3 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
The Venus clock frequencies are a copy/paste error from msm8916. Looking
at the original clock-gcc-8936.c ftbl_gcc_venus0_vcodec0_clk defines we
have:
- 133 MHz
- 200 MHz
- 266 MHz
These values are born out by the relevant qualcomm documentation for the
msm8936/msm8939 Venus core performance levels.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 6a3e2326c72a3..2aad40dbef8e6 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1824,9 +1824,9 @@ static struct clk_branch gcc_ultaudio_pcnoc_sway_clk = {
};
static const struct freq_tbl ftbl_gcc_venus0_vcodec0_clk[] = {
- F(100000000, P_GPLL0, 8, 0, 0),
- F(160000000, P_GPLL0, 5, 0, 0),
- F(228570000, P_GPLL0, 3.5, 0, 0),
+ F(133330000, P_GPLL0, 6, 0, 0),
+ F(200000000, P_GPLL0, 4, 0, 0),
+ F(266670000, P_GPLL0, 3, 0, 0),
{ }
};
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
` (2 preceding siblings ...)
2022-07-12 12:59 ` [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP " Bryan O'Donoghue
` (2 subsequent siblings)
6 siblings, 2 replies; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
Reviewing the qcom msm8936.c clock frequency tables we see
static struct clk_freq_tbl ftbl_gcc_camss_cpp_clk[] = {
F( 160000000, gpll0_out_main, 5, 0, 0),
F( 200000000, gpll0_out_main, 4, 0, 0),
F( 228570000, gpll0_out_main, 3.5, 0, 0),
F( 266670000, gpll0_out_main, 3, 0, 0),
F( 320000000, gpll0_out_main, 2.5, 0, 0),
F( 465000000, gpll2_out_main, 2, 0, 0),
F_END
};
which is a super-set of the msm8916 original definitions.
Add in the missing frequency definitions now.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 2aad40dbef8e6..6b265b68524f2 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1143,6 +1143,9 @@ static struct clk_rcg2 csi1phytimer_clk_src = {
static const struct freq_tbl ftbl_gcc_camss_cpp_clk[] = {
F(160000000, P_GPLL0, 5, 0, 0),
+ F(200000000, P_GPLL0, 4, 0, 0),
+ F(228570000, P_GPLL0, 3.5, 0, 0),
+ F(266670000, P_GPLL0, 3, 0, 0),
F(320000000, P_GPLL0, 2.5, 0, 0),
F(465000000, P_GPLL2, 2, 0, 0),
{ }
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP clock frequencies
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
` (3 preceding siblings ...)
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system " Bryan O'Donoghue
2022-07-19 4:48 ` [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bjorn Andersson
6 siblings, 1 reply; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
Again the msm8936/msm8939 supports a wider range of operating frequencies
to the antecedent msm8916 from which the msm8939.c driver is derived.
static struct clk_freq_tbl ftbl_gcc_mdss_mdp_clk[] = {
F( 50000000, gpll0_out_aux, 16, 0, 0),
F( 80000000, gpll0_out_aux, 10, 0, 0),
F( 100000000, gpll0_out_aux, 8, 0, 0),
F( 145500000, gpll0_out_aux, 5.5, 0, 0),
F( 153600000, gpll1_out_main, 4, 0, 0),
F( 160000000, gpll0_out_aux, 5, 0, 0),
F( 177780000, gpll0_out_aux, 4.5, 0, 0),
F( 200000000, gpll0_out_aux, 4, 0, 0),
F( 266670000, gpll0_out_aux, 3, 0, 0),
F( 307200000, gpll1_out_main, 2, 0, 0),
F( 366670000, gpll3_out_aux, 3, 0, 0),
F_END
};
We are missing 145.5 MHz and 153.6 MHz.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 6b265b68524f2..7f71491d52c4b 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1294,6 +1294,8 @@ static const struct freq_tbl ftbl_gcc_mdss_mdp_clk[] = {
F(50000000, P_GPLL0_AUX, 16, 0, 0),
F(80000000, P_GPLL0_AUX, 10, 0, 0),
F(100000000, P_GPLL0_AUX, 8, 0, 0),
+ F(145500000, P_GPLL0_AUX, 5.5, 0, 0),
+ F(153600000, P_GPLL0, 4, 0, 0),
F(160000000, P_GPLL0_AUX, 5, 0, 0),
F(177780000, P_GPLL0_AUX, 4.5, 0, 0),
F(200000000, P_GPLL0_AUX, 4, 0, 0),
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
` (4 preceding siblings ...)
2022-07-12 12:59 ` [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP " Bryan O'Donoghue
@ 2022-07-12 12:59 ` Bryan O'Donoghue
2022-07-12 16:18 ` Konrad Dybcio
2022-07-19 4:48 ` [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bjorn Andersson
6 siblings, 1 reply; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 12:59 UTC (permalink / raw)
To: bjorn.andersson, agross, konrad.dybcio, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, Bryan O'Donoghue
The shipped qcom driver defines:
static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
F( 57140000, gpll0_out_main, 14, 0, 0),
F( 80000000, gpll0_out_main, 10, 0, 0),
F( 100000000, gpll0_out_main, 8, 0, 0),
F_END
};
In the upstream code we omit 57.14 MHz and 100 MHz.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
drivers/clk/qcom/gcc-msm8939.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 7f71491d52c4b..754d5573b1df5 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -1468,7 +1468,9 @@ static struct clk_rcg2 bimc_gpu_clk_src = {
};
static const struct freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
+ F(57140000, P_GPLL0, 14, 0, 0),
F(80000000, P_GPLL0, 10, 0, 0),
+ F(100000000, P_GPLL0, 8, 0, 0),
{ }
};
--
2.36.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
@ 2022-07-12 16:11 ` Konrad Dybcio
0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:11 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> Adding a new item to this frequency table I see the existing indentation is
> incorrect.
>
> Fixes: 1664014e4679 ("clk: qcom: gcc-msm8939: Add MSM8939 Generic Clock Controller")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 39ebb443ae3d5..628b476a5468e 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1002,7 +1002,7 @@ static struct clk_rcg2 blsp1_uart2_apps_clk_src = {
> };
>
> static const struct freq_tbl ftbl_gcc_camss_cci_clk[] = {
> - F(19200000, P_XO, 1, 0, 0),
> + F(19200000, P_XO, 1, 0, 0),
> { }
> };
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock
2022-07-12 12:59 ` [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock Bryan O'Donoghue
@ 2022-07-12 16:12 ` Konrad Dybcio
0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:12 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> Standard CCI bus clock clocks are 19.2 MHz and 37.5 MHz. We already define
> the 19.2 MHz but are missing the 37.5 MHz.
>
> See qcom kernel drivers/clk/qcom/clock-gcc-8936.c::ftbl_gcc_camss_cci_clk[]
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 628b476a5468e..6a3e2326c72a3 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1003,6 +1003,7 @@ static struct clk_rcg2 blsp1_uart2_apps_clk_src = {
>
> static const struct freq_tbl ftbl_gcc_camss_cci_clk[] = {
> F(19200000, P_XO, 1, 0, 0),
> + F(37500000, P_GPLL0, 1, 3, 64),
> { }
> };
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions
2022-07-12 12:59 ` [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions Bryan O'Donoghue
@ 2022-07-12 16:13 ` Konrad Dybcio
0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:13 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> The Venus clock frequencies are a copy/paste error from msm8916. Looking
> at the original clock-gcc-8936.c ftbl_gcc_venus0_vcodec0_clk defines we
> have:
>
> - 133 MHz
> - 200 MHz
> - 266 MHz
>
> These values are born out by the relevant qualcomm documentation for the
> msm8936/msm8939 Venus core performance levels.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 6a3e2326c72a3..2aad40dbef8e6 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1824,9 +1824,9 @@ static struct clk_branch gcc_ultaudio_pcnoc_sway_clk = {
> };
>
> static const struct freq_tbl ftbl_gcc_venus0_vcodec0_clk[] = {
> - F(100000000, P_GPLL0, 8, 0, 0),
> - F(160000000, P_GPLL0, 5, 0, 0),
> - F(228570000, P_GPLL0, 3.5, 0, 0),
> + F(133330000, P_GPLL0, 6, 0, 0),
> + F(200000000, P_GPLL0, 4, 0, 0),
> + F(266670000, P_GPLL0, 3, 0, 0),
> { }
> };
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
@ 2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 16:17 ` Konrad Dybcio
1 sibling, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:13 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> Reviewing the qcom msm8936.c clock frequency tables we see
>
> static struct clk_freq_tbl ftbl_gcc_camss_cpp_clk[] = {
> F( 160000000, gpll0_out_main, 5, 0, 0),
> F( 200000000, gpll0_out_main, 4, 0, 0),
> F( 228570000, gpll0_out_main, 3.5, 0, 0),
> F( 266670000, gpll0_out_main, 3, 0, 0),
> F( 320000000, gpll0_out_main, 2.5, 0, 0),
> F( 465000000, gpll2_out_main, 2, 0, 0),
> F_END
> };
> which is a super-set of the msm8916 original definitions.
> Add in the missing frequency definitions now.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 2aad40dbef8e6..6b265b68524f2 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1143,6 +1143,9 @@ static struct clk_rcg2 csi1phytimer_clk_src = {
>
> static const struct freq_tbl ftbl_gcc_camss_cpp_clk[] = {
> F(160000000, P_GPLL0, 5, 0, 0),
> + F(200000000, P_GPLL0, 4, 0, 0),
> + F(228570000, P_GPLL0, 3.5, 0, 0),
> + F(266670000, P_GPLL0, 3, 0, 0),
> F(320000000, P_GPLL0, 2.5, 0, 0),
> F(465000000, P_GPLL2, 2, 0, 0),
> { }
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
@ 2022-07-12 16:17 ` Konrad Dybcio
1 sibling, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:17 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> Reviewing the qcom msm8936.c clock frequency tables we see
>
> static struct clk_freq_tbl ftbl_gcc_camss_cpp_clk[] = {
> F( 160000000, gpll0_out_main, 5, 0, 0),
> F( 200000000, gpll0_out_main, 4, 0, 0),
> F( 228570000, gpll0_out_main, 3.5, 0, 0),
> F( 266670000, gpll0_out_main, 3, 0, 0),
> F( 320000000, gpll0_out_main, 2.5, 0, 0),
> F( 465000000, gpll2_out_main, 2, 0, 0),
> F_END
> };
> which is a super-set of the msm8916 original definitions.
> Add in the missing frequency definitions now.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 2aad40dbef8e6..6b265b68524f2 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1143,6 +1143,9 @@ static struct clk_rcg2 csi1phytimer_clk_src = {
>
> static const struct freq_tbl ftbl_gcc_camss_cpp_clk[] = {
> F(160000000, P_GPLL0, 5, 0, 0),
> + F(200000000, P_GPLL0, 4, 0, 0),
> + F(228570000, P_GPLL0, 3.5, 0, 0),
> + F(266670000, P_GPLL0, 3, 0, 0),
> F(320000000, P_GPLL0, 2.5, 0, 0),
> F(465000000, P_GPLL2, 2, 0, 0),
> { }
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP clock frequencies
2022-07-12 12:59 ` [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP " Bryan O'Donoghue
@ 2022-07-12 16:17 ` Konrad Dybcio
0 siblings, 0 replies; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:17 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> Again the msm8936/msm8939 supports a wider range of operating frequencies
> to the antecedent msm8916 from which the msm8939.c driver is derived.
>
> static struct clk_freq_tbl ftbl_gcc_mdss_mdp_clk[] = {
> F( 50000000, gpll0_out_aux, 16, 0, 0),
> F( 80000000, gpll0_out_aux, 10, 0, 0),
> F( 100000000, gpll0_out_aux, 8, 0, 0),
> F( 145500000, gpll0_out_aux, 5.5, 0, 0),
> F( 153600000, gpll1_out_main, 4, 0, 0),
> F( 160000000, gpll0_out_aux, 5, 0, 0),
> F( 177780000, gpll0_out_aux, 4.5, 0, 0),
> F( 200000000, gpll0_out_aux, 4, 0, 0),
> F( 266670000, gpll0_out_aux, 3, 0, 0),
> F( 307200000, gpll1_out_main, 2, 0, 0),
> F( 366670000, gpll3_out_aux, 3, 0, 0),
> F_END
> };
>
> We are missing 145.5 MHz and 153.6 MHz.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 6b265b68524f2..7f71491d52c4b 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1294,6 +1294,8 @@ static const struct freq_tbl ftbl_gcc_mdss_mdp_clk[] = {
> F(50000000, P_GPLL0_AUX, 16, 0, 0),
> F(80000000, P_GPLL0_AUX, 10, 0, 0),
> F(100000000, P_GPLL0_AUX, 8, 0, 0),
> + F(145500000, P_GPLL0_AUX, 5.5, 0, 0),
> + F(153600000, P_GPLL0, 4, 0, 0),
> F(160000000, P_GPLL0_AUX, 5, 0, 0),
> F(177780000, P_GPLL0_AUX, 4.5, 0, 0),
> F(200000000, P_GPLL0_AUX, 4, 0, 0),
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies
2022-07-12 12:59 ` [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system " Bryan O'Donoghue
@ 2022-07-12 16:18 ` Konrad Dybcio
2022-07-12 16:19 ` Bryan O'Donoghue
0 siblings, 1 reply; 16+ messages in thread
From: Konrad Dybcio @ 2022-07-12 16:18 UTC (permalink / raw)
To: Bryan O'Donoghue, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12.07.2022 14:59, Bryan O'Donoghue wrote:
> The shipped qcom driver defines:
> static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
> F( 57140000, gpll0_out_main, 14, 0, 0),
> F( 80000000, gpll0_out_main, 10, 0, 0),
> F( 100000000, gpll0_out_main, 8, 0, 0),
> F_END
> };
> In the upstream code we omit 57.14 MHz and 100 MHz.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/gcc-msm8939.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 7f71491d52c4b..754d5573b1df5 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -1468,7 +1468,9 @@ static struct clk_rcg2 bimc_gpu_clk_src = {
> };
>
> static const struct freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
> + F(57140000, P_GPLL0, 14, 0, 0),
> F(80000000, P_GPLL0, 10, 0, 0),
> + F(100000000, P_GPLL0, 8, 0, 0),
> { }
> };
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies
2022-07-12 16:18 ` Konrad Dybcio
@ 2022-07-12 16:19 ` Bryan O'Donoghue
0 siblings, 0 replies; 16+ messages in thread
From: Bryan O'Donoghue @ 2022-07-12 16:19 UTC (permalink / raw)
To: Konrad Dybcio, bjorn.andersson, agross, mturquette, sboyd
Cc: linux-arm-msm, linux-clk
On 12/07/2022 17:18, Konrad Dybcio wrote:
>
>
> On 12.07.2022 14:59, Bryan O'Donoghue wrote:
>> The shipped qcom driver defines:
>> static struct clk_freq_tbl ftbl_gcc_usb_hs_system_clk[] = {
>> F( 57140000, gpll0_out_main, 14, 0, 0),
>> F( 80000000, gpll0_out_main, 10, 0, 0),
>> F( 100000000, gpll0_out_main, 8, 0, 0),
>> F_END
>> };
>> In the upstream code we omit 57.14 MHz and 100 MHz.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> Konrad
Thx for the review, appreciated.
---
bod
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
` (5 preceding siblings ...)
2022-07-12 12:59 ` [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system " Bryan O'Donoghue
@ 2022-07-19 4:48 ` Bjorn Andersson
6 siblings, 0 replies; 16+ messages in thread
From: Bjorn Andersson @ 2022-07-19 4:48 UTC (permalink / raw)
To: konrad.dybcio, bryan.odonoghue, mturquette, sboyd, agross
Cc: linux-clk, linux-arm-msm
On Tue, 12 Jul 2022 13:59:16 +0100, Bryan O'Donoghue wrote:
> The gcc-msm8939 driver is a copy/paste of the gcc-msm8916 for the good
> reason that msm8936/msm8939 are an expanded version of msm8916. Reviewing
> the qcom driver though there are some obvious missing/wrong frequencies
> which a simple side-by-side comparison can show up.
>
> This series captures that side-by-side and transmits into updated frequency
> tables.
>
> [...]
Applied, thanks!
[1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk
commit: 2bc308ebc453ba22f3f120f777b9ac48f973ee80
[2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock
commit: 159b2f59d65b4d34e225ef8d96ed290a13610d9c
[3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions
commit: 680b86da10a23268b24d65b567830824075eb151
[4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies
commit: 2c37d70c82e826e44163ab2c83f8b7b81e7db35a
[5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP clock frequencies
commit: 2573f7d8629afc1d2c5f841b8a2b2359396a5e77
[6/6] clk: qcom: gcc-msm8939: Add missing USB HS system clock frequencies
commit: 873b98538491feb0b0548ea1a8ee054fcfe0d435
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-07-19 4:48 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 12:59 [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bryan O'Donoghue
2022-07-12 12:59 ` [PATCH 1/6] clk: qcom: gcc-msm8939: Fix weird field spacing in ftbl_gcc_camss_cci_clk Bryan O'Donoghue
2022-07-12 16:11 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 2/6] clk: qcom: gcc-msm8939: Add missing CAMSS CCI bus clock Bryan O'Donoghue
2022-07-12 16:12 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 3/6] clk: qcom: gcc-msm8939: Fix venus0_vcodec0_clk frequency definitions Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 4/6] clk: qcom: gcc-msm8939: Add missing CAMSS CPP clock frequencies Bryan O'Donoghue
2022-07-12 16:13 ` Konrad Dybcio
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 5/6] clk: qcom: gcc-msm8939: Add missing MDSS MDP " Bryan O'Donoghue
2022-07-12 16:17 ` Konrad Dybcio
2022-07-12 12:59 ` [PATCH 6/6] clk: qcom: gcc-msm8939: Add missing USB HS system " Bryan O'Donoghue
2022-07-12 16:18 ` Konrad Dybcio
2022-07-12 16:19 ` Bryan O'Donoghue
2022-07-19 4:48 ` [PATCH 0/6] clk: qcom: gcc-msm8939: Align clock frequencies with downstream driver Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).