* [PATCH 0/4] Add imem clock for Exynos 5433
[not found] <CGME20181121120522eucas1p2ecd03f848bc4ea3be3d517b40b78b084@eucas1p2.samsung.com>
@ 2018-11-21 12:05 ` Kamil Konieczny
[not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com>
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw)
To: k.konieczny, linux-samsung-soc
Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski,
Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Marek Szyprowski
Add imem clock for Exynos 5433. This will allow to use SSS and SlimSSS
(Security SubSystem) with crypto functions.
Kamil Konieczny (4):
clk: samsung: exynos5433: fix name typos
arm64: dts: bindings: document imem clock
arm64: dts: exynos: add imem clock
clk: samsung: exynos5433: add imem clock
.../bindings/clock/exynos5433-clock.txt | 23 ++++
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 15 ++
drivers/clk/samsung/clk-exynos5433.c | 129 +++++++++++++++++-
include/dt-bindings/clock/exynos5433.h | 57 +++++++-
4 files changed, 220 insertions(+), 4 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/4] clk: samsung: exynos5433: fix name typos
[not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com>
@ 2018-11-21 12:05 ` Kamil Konieczny
2018-11-21 12:23 ` Chanwoo Choi
2018-11-21 13:13 ` Krzysztof Kozlowski
0 siblings, 2 replies; 7+ messages in thread
From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw)
To: k.konieczny, linux-samsung-soc
Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski,
Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Marek Szyprowski
Fix typo in imem sssx name and typo 200 switched with 266.
Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
---
drivers/clk/samsung/clk-exynos5433.c | 6 +++---
include/dt-bindings/clock/exynos5433.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index 751e2c4fb65b..24c3360db65b 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
/* ENABLE_ACLK_TOP */
GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400",
ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0),
- GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266",
+ GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266",
"div_aclk_imem_sssx_266", ENABLE_ACLK_TOP,
29, CLK_IGNORE_UNUSED, 0),
GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400",
@@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400",
ENABLE_ACLK_TOP, 25,
CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
- GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266",
+ GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200",
ENABLE_ACLK_TOP, 24,
CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
- GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200",
+ GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266",
ENABLE_ACLK_TOP, 23,
CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b",
diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h
index 98bd85ce1e45..87bb2b017143 100644
--- a/include/dt-bindings/clock/exynos5433.h
+++ b/include/dt-bindings/clock/exynos5433.h
@@ -156,7 +156,7 @@
#define CLK_ACLK_G2D_266 220
#define CLK_ACLK_G2D_400 221
#define CLK_ACLK_G3D_400 222
-#define CLK_ACLK_IMEM_SSX_266 223
+#define CLK_ACLK_IMEM_SSSX_266 223
#define CLK_ACLK_BUS0_400 224
#define CLK_ACLK_BUS1_400 225
#define CLK_ACLK_IMEM_200 226
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/4] arm64: dts: bindings: document imem clock
[not found] ` <CGME20181121120523eucas1p1e8c1ef3d19d0f71bbdc57e2a470c80b0@eucas1p1.samsung.com>
@ 2018-11-21 12:05 ` Kamil Konieczny
0 siblings, 0 replies; 7+ messages in thread
From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw)
To: k.konieczny, linux-samsung-soc
Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski,
Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Marek Szyprowski
Document imem clock bindings for SSS (Security SubSystem) and SlimSSS IPs.
Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
---
.../bindings/clock/exynos5433-clock.txt | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/exynos5433-clock.txt b/Documentation/devicetree/bindings/clock/exynos5433-clock.txt
index 50d5897c9849..4e4352bf5a0b 100644
--- a/Documentation/devicetree/bindings/clock/exynos5433-clock.txt
+++ b/Documentation/devicetree/bindings/clock/exynos5433-clock.txt
@@ -19,6 +19,8 @@ Required Properties:
which generates clocks for PMU/TMU/MCT/WDT/RTC/SECKEY/TZPC IPs.
- "samsung,exynos5433-cmu-fsys" - clock controller compatible for CMU_FSYS
which generates clocks for USB/UFS/SDMMC/TSI/PDMA IPs.
+ - "samsung,exynos5433-cmu-imem" - clock controller compatible for CMU_IMEM
+ which generates clocks for SSS (Security SubSystem) and SlimSSS IPs.
- "samsung,exynos5433-cmu-g2d" - clock controller compatible for CMU_G2D
which generates clocks for G2D/MDMA IPs.
- "samsung,exynos5433-cmu-disp" - clock controller compatible for CMU_DISP
@@ -88,6 +90,12 @@ Required Properties:
- sclk_usbhost30_fsys
- sclk_usbdrd30_fsys
+ Input clocks for imem clock controller:
+ - oscclk
+ - aclk_imem_sssx_266
+ - aclk_imem_266
+ - aclk_imem_200
+
Input clocks for g2d clock controller:
- oscclk
- aclk_g2d_266
@@ -264,6 +272,21 @@ Example 2: Examples of clock controller nodes are listed below.
<&cmu_top CLK_SCLK_USBDRD30_FSYS>;
};
+ cmu_imem: clock-controller@11060000 {
+ compatible = "samsung,exynos5433-cmu-imem";
+ reg = <0x11060000 0x1000>;
+ #clock-cells = <1>;
+
+ clock-names = "oscclk",
+ "aclk_imem_sssx_266",
+ "aclk_imem_266",
+ "aclk_imem_200";
+ clocks = <&xxti>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_SSSX_266>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_266>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_200>;
+ };
+
cmu_g2d: clock-controller@12460000 {
compatible = "samsung,exynos5433-cmu-g2d";
reg = <0x12460000 0x0b08>;
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] arm64: dts: exynos: add imem clock
[not found] ` <CGME20181121120524eucas1p2545f7ee0ed4064a10b3bc18f446c288c@eucas1p2.samsung.com>
@ 2018-11-21 12:05 ` Kamil Konieczny
0 siblings, 0 replies; 7+ messages in thread
From: Kamil Konieczny @ 2018-11-21 12:05 UTC (permalink / raw)
To: k.konieczny, linux-samsung-soc
Cc: linux-clk, Chanwoo Choi, devicetree, Krzysztof Kozlowski,
Kukjin Kim, Mark Rutland, Rob Herring, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Marek Szyprowski
Add description for imem clock. The users can use compatibility
"samsung,exynos5433-cmu-imem".
Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 2131f12364cb..34055fa3a9d0 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -340,6 +340,21 @@
<&cmu_top CLK_SCLK_USBDRD30_FSYS>;
};
+ cmu_imem: clock-controller@11060000 {
+ compatible = "samsung,exynos5433-cmu-imem";
+ reg = <0x11060000 0x1000>;
+ #clock-cells = <1>;
+
+ clock-names = "oscclk",
+ "aclk_imem_sssx_266",
+ "aclk_imem_266",
+ "aclk_imem_200";
+ clocks = <&xxti>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_SSSX_266>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_266>,
+ <&cmu_top CLK_DIV_ACLK_IMEM_200>;
+ };
+
cmu_g2d: clock-controller@12460000 {
compatible = "samsung,exynos5433-cmu-g2d";
reg = <0x12460000 0x1000>;
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos
2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny
@ 2018-11-21 12:23 ` Chanwoo Choi
2018-11-21 13:13 ` Krzysztof Kozlowski
1 sibling, 0 replies; 7+ messages in thread
From: Chanwoo Choi @ 2018-11-21 12:23 UTC (permalink / raw)
To: Kamil Konieczny, linux-samsung-soc
Cc: linux-clk, devicetree, Krzysztof Kozlowski, Kukjin Kim,
Mark Rutland, Rob Herring, Sylwester Nawrocki,
Bartlomiej Zolnierkiewicz, Marek Szyprowski
Hi,
On 2018년 11월 21일 21:05, Kamil Konieczny wrote:
> Fix typo in imem sssx name and typo 200 switched with 266.
>
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
Looks good to me.
But, You have to add the 'Fixes' information and then send this patch to stable mailing list.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 6 +++---
> include/dt-bindings/clock/exynos5433.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index 751e2c4fb65b..24c3360db65b 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
> /* ENABLE_ACLK_TOP */
> GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400",
> ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0),
> - GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266",
> + GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266",
> "div_aclk_imem_sssx_266", ENABLE_ACLK_TOP,
> 29, CLK_IGNORE_UNUSED, 0),
> GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400",
> @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
> GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400",
> ENABLE_ACLK_TOP, 25,
> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
> - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266",
> + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200",
> ENABLE_ACLK_TOP, 24,
> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
> - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200",
> + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266",
> ENABLE_ACLK_TOP, 23,
> CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b",
> diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h
> index 98bd85ce1e45..87bb2b017143 100644
> --- a/include/dt-bindings/clock/exynos5433.h
> +++ b/include/dt-bindings/clock/exynos5433.h
> @@ -156,7 +156,7 @@
> #define CLK_ACLK_G2D_266 220
> #define CLK_ACLK_G2D_400 221
> #define CLK_ACLK_G3D_400 222
> -#define CLK_ACLK_IMEM_SSX_266 223
> +#define CLK_ACLK_IMEM_SSSX_266 223
> #define CLK_ACLK_BUS0_400 224
> #define CLK_ACLK_BUS1_400 225
> #define CLK_ACLK_IMEM_200 226
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos
2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny
2018-11-21 12:23 ` Chanwoo Choi
@ 2018-11-21 13:13 ` Krzysztof Kozlowski
2018-11-26 14:25 ` Kamil Konieczny
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2018-11-21 13:13 UTC (permalink / raw)
To: k.konieczny
Cc: linux-samsung-soc, linux-clk, Chanwoo Choi, devicetree, kgene,
mark.rutland, robh+dt, s.nawrocki,
Bartłomiej Żołnierkiewicz, Marek Szyprowski
On Wed, 21 Nov 2018 at 13:05, Kamil Konieczny
<k.konieczny@partner.samsung.com> wrote:
>
> Fix typo in imem sssx name and typo 200 switched with 266.
These should be two separate patches. Then the one changing parent
could go to stable.
Best regards,
Krzysztof
>
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 6 +++---
> include/dt-bindings/clock/exynos5433.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index 751e2c4fb65b..24c3360db65b 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -559,7 +559,7 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
> /* ENABLE_ACLK_TOP */
> GATE(CLK_ACLK_G3D_400, "aclk_g3d_400", "div_aclk_g3d_400",
> ENABLE_ACLK_TOP, 30, CLK_IS_CRITICAL, 0),
> - GATE(CLK_ACLK_IMEM_SSX_266, "aclk_imem_ssx_266",
> + GATE(CLK_ACLK_IMEM_SSSX_266, "aclk_imem_sssx_266",
> "div_aclk_imem_sssx_266", ENABLE_ACLK_TOP,
> 29, CLK_IGNORE_UNUSED, 0),
> GATE(CLK_ACLK_BUS0_400, "aclk_bus0_400", "div_aclk_bus0_400",
> @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
> GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400",
> ENABLE_ACLK_TOP, 25,
> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
> - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266",
> + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200",
> ENABLE_ACLK_TOP, 24,
> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
> - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200",
> + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266",
> ENABLE_ACLK_TOP, 23,
> CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b",
> diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h
> index 98bd85ce1e45..87bb2b017143 100644
> --- a/include/dt-bindings/clock/exynos5433.h
> +++ b/include/dt-bindings/clock/exynos5433.h
> @@ -156,7 +156,7 @@
> #define CLK_ACLK_G2D_266 220
> #define CLK_ACLK_G2D_400 221
> #define CLK_ACLK_G3D_400 222
> -#define CLK_ACLK_IMEM_SSX_266 223
> +#define CLK_ACLK_IMEM_SSSX_266 223
> #define CLK_ACLK_BUS0_400 224
> #define CLK_ACLK_BUS1_400 225
> #define CLK_ACLK_IMEM_200 226
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] clk: samsung: exynos5433: fix name typos
2018-11-21 13:13 ` Krzysztof Kozlowski
@ 2018-11-26 14:25 ` Kamil Konieczny
0 siblings, 0 replies; 7+ messages in thread
From: Kamil Konieczny @ 2018-11-26 14:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-samsung-soc, linux-clk, Chanwoo Choi, devicetree, kgene,
mark.rutland, robh+dt, s.nawrocki,
Bartłomiej Żołnierkiewicz, Marek Szyprowski
On 21.11.2018 14:13, Krzysztof Kozlowski wrote:
> On Wed, 21 Nov 2018 at 13:05, Kamil Konieczny
> <k.konieczny@partner.samsung.com> wrote:
>>
>> Fix typo in imem sssx name and typo 200 switched with 266.
>
> These should be two separate patches. Then the one changing parent
> could go to stable. [...]
Thank you, I will split it as you suggested.
>> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 6 +++---
>> include/dt-bindings/clock/exynos5433.h | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>> [...]
>> @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = {
>> GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400",
>> ENABLE_ACLK_TOP, 25,
>> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
>> - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266",
>> + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200",
>> ENABLE_ACLK_TOP, 24,
>> CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
>> - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200",
>> + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266",
>> ENABLE_ACLK_TOP, 23,
>> [...]
--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-26 14:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20181121120522eucas1p2ecd03f848bc4ea3be3d517b40b78b084@eucas1p2.samsung.com>
2018-11-21 12:05 ` [PATCH 0/4] Add imem clock for Exynos 5433 Kamil Konieczny
[not found] ` <CGME20181121120523eucas1p1e69848a515c713315499e6e21f099cc2@eucas1p1.samsung.com>
2018-11-21 12:05 ` [PATCH 1/4] clk: samsung: exynos5433: fix name typos Kamil Konieczny
2018-11-21 12:23 ` Chanwoo Choi
2018-11-21 13:13 ` Krzysztof Kozlowski
2018-11-26 14:25 ` Kamil Konieczny
[not found] ` <CGME20181121120523eucas1p1e8c1ef3d19d0f71bbdc57e2a470c80b0@eucas1p1.samsung.com>
2018-11-21 12:05 ` [PATCH 2/4] arm64: dts: bindings: document imem clock Kamil Konieczny
[not found] ` <CGME20181121120524eucas1p2545f7ee0ed4064a10b3bc18f446c288c@eucas1p2.samsung.com>
2018-11-21 12:05 ` [PATCH 3/4] arm64: dts: exynos: add " Kamil Konieczny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).