linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] clk: clk-st: Add missed return value checks in st_clk_probe()
@ 2020-06-03 17:30 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-03 17:30 UTC (permalink / raw)
  To: Chuhong Yuan, linux-clk
  Cc: Akshu Agrawal, Daniel Kurtz, Michael Turquette,
	Rafael J. Wysocki, Stephen Boyd, kernel-janitors, linux-kernel

> st_clk_probe() has not check for clk_hw_register_mux(), clk_hw_register_gate()
> and devm_clk_hw_register_clkdev().
> Add the missed checks and return devm_clk_hw_register_clkdev()'s return value
> to check errors.

How do you think about another wording variant?

   Return values were not checked after calls of the following functions.
   - clk_hw_register_mux
   - clk_hw_register_gate
   - devm_clk_hw_register_clkdev

   * Thus add error detection and the corresponding exception handling.

   * Return the value from the function call “devm_clk_hw_register_clkdev”
     at the end of this function implementation.

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-03 17:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 17:30 [PATCH] clk: clk-st: Add missed return value checks in st_clk_probe() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).