* [PATCH] clk: at91: add compatible for sam9x60
@ 2019-10-08 16:46 Claudiu Beznea
2019-10-08 16:54 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: Claudiu Beznea @ 2019-10-08 16:46 UTC (permalink / raw)
To: mturquette, sboyd, nicolas.ferre, alexandre.belloni
Cc: linux-clk, linux-arm-kernel, linux-kernel, Claudiu Beznea
Add compatible for SAM9X60's PMC.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/clk/at91/pmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
index db24539d5740..24975bca608e 100644
--- a/drivers/clk/at91/pmc.c
+++ b/drivers/clk/at91/pmc.c
@@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = {
static const struct of_device_id sama5d2_pmc_dt_ids[] = {
{ .compatible = "atmel,sama5d2-pmc" },
+ { .compatible = "microchip,sam9x60-pmc" },
{ /* sentinel */ }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: add compatible for sam9x60
2019-10-08 16:46 [PATCH] clk: at91: add compatible for sam9x60 Claudiu Beznea
@ 2019-10-08 16:54 ` Alexandre Belloni
2019-10-09 12:17 ` Claudiu.Beznea
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2019-10-08 16:54 UTC (permalink / raw)
To: Claudiu Beznea
Cc: mturquette, sboyd, nicolas.ferre, linux-clk, linux-arm-kernel,
linux-kernel
Hi,
On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote:
> Add compatible for SAM9X60's PMC.
I think the commit log could be clearer and mention why this is needed
and the compatible string in sam9x60 is not sufficient.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clk/at91/pmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index db24539d5740..24975bca608e 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = {
>
> static const struct of_device_id sama5d2_pmc_dt_ids[] = {
Maybe rename the array?
> { .compatible = "atmel,sama5d2-pmc" },
> + { .compatible = "microchip,sam9x60-pmc" },
> { /* sentinel */ }
> };
>
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: add compatible for sam9x60
2019-10-08 16:54 ` Alexandre Belloni
@ 2019-10-09 12:17 ` Claudiu.Beznea
0 siblings, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2019-10-09 12:17 UTC (permalink / raw)
To: alexandre.belloni
Cc: mturquette, sboyd, Nicolas.Ferre, linux-clk, linux-arm-kernel,
linux-kernel
Hi,
On 08.10.2019 19:54, Alexandre Belloni wrote:
> Hi,
>
> On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote:
>> Add compatible for SAM9X60's PMC.
>
> I think the commit log could be clearer and mention why this is needed
> and the compatible string in sam9x60 is not sufficient.
I had issues with waking up from ULP1 without even having configuring
wakeup sources.
But, investigating more I discovered that this patch breaks other things
so please ignore it.
Sorry for the noise,
Claudiu Beznea
>
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> drivers/clk/at91/pmc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
>> index db24539d5740..24975bca608e 100644
>> --- a/drivers/clk/at91/pmc.c
>> +++ b/drivers/clk/at91/pmc.c
>> @@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = {
>>
>> static const struct of_device_id sama5d2_pmc_dt_ids[] = {
>
> Maybe rename the array?
>
>> { .compatible = "atmel,sama5d2-pmc" },
>> + { .compatible = "microchip,sam9x60-pmc" },
>> { /* sentinel */ }
>> };
>>
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-09 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 16:46 [PATCH] clk: at91: add compatible for sam9x60 Claudiu Beznea
2019-10-08 16:54 ` Alexandre Belloni
2019-10-09 12:17 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).