* [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros
@ 2022-04-27 7:43 Juerg Haefliger
2022-04-27 7:51 ` Antoine Tenart
2022-05-06 10:21 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Juerg Haefliger @ 2022-04-27 7:43 UTC (permalink / raw)
To: atenart, herbert, davem, linux-crypto; +Cc: linux-kernel, Juerg Haefliger
The safexcel module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.
Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
---
v2:
Add legacy fallback firmware locations.
---
drivers/crypto/inside-secure/safexcel.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 9ff885d50edf..9b1a158aec29 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1997,3 +1997,12 @@ MODULE_AUTHOR("Igal Liberman <igall@marvell.com>");
MODULE_DESCRIPTION("Support for SafeXcel cryptographic engines: EIP97 & EIP197");
MODULE_LICENSE("GPL v2");
MODULE_IMPORT_NS(CRYPTO_INTERNAL);
+
+MODULE_FIRMWARE("ifpp.bin");
+MODULE_FIRMWARE("ipue.bin");
+MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
+MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
+MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
+MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros
2022-04-27 7:43 [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros Juerg Haefliger
@ 2022-04-27 7:51 ` Antoine Tenart
2022-05-06 10:21 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Antoine Tenart @ 2022-04-27 7:51 UTC (permalink / raw)
To: Juerg Haefliger, davem, herbert, linux-crypto
Cc: linux-kernel, Juerg Haefliger
Quoting Juerg Haefliger (2022-04-27 09:43:51)
> The safexcel module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
LGTM, thanks!
Acked-by: Antoine Tenart <atenart@kernel.org>
> ---
> v2:
> Add legacy fallback firmware locations.
> ---
> drivers/crypto/inside-secure/safexcel.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 9ff885d50edf..9b1a158aec29 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1997,3 +1997,12 @@ MODULE_AUTHOR("Igal Liberman <igall@marvell.com>");
> MODULE_DESCRIPTION("Support for SafeXcel cryptographic engines: EIP97 & EIP197");
> MODULE_LICENSE("GPL v2");
> MODULE_IMPORT_NS(CRYPTO_INTERNAL);
> +
> +MODULE_FIRMWARE("ifpp.bin");
> +MODULE_FIRMWARE("ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros
2022-04-27 7:43 [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros Juerg Haefliger
2022-04-27 7:51 ` Antoine Tenart
@ 2022-05-06 10:21 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-05-06 10:21 UTC (permalink / raw)
To: Juerg Haefliger
Cc: atenart, davem, linux-crypto, linux-kernel, Juerg Haefliger
On Wed, Apr 27, 2022 at 09:43:51AM +0200, Juerg Haefliger wrote:
> The safexcel module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juergh@protonmail.com>
> ---
> v2:
> Add legacy fallback firmware locations.
> ---
> drivers/crypto/inside-secure/safexcel.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-06 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 7:43 [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros Juerg Haefliger
2022-04-27 7:51 ` Antoine Tenart
2022-05-06 10:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).