* arm64 broken
@ 2017-01-11 18:37 Rob Rice
2017-01-12 7:50 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Rob Rice @ 2017-01-11 18:37 UTC (permalink / raw)
To: linux-crypto
I’m working on updating a patchset. The master branch in crypto-2.6 doesn’t compile for ARM64. The first couple errors are listed below. A colleague believes that the following commit in rc2 fixes the problem.
commit b4b8664d291ac1998e0f0bcdc96b6397f0fe68b3
Author: Al Viro <viro@zeniv.linux.org.uk <mailto:viro@zeniv.linux.org.uk>>
Date: Mon Dec 26 04:10:19 2016 -0500
arm64: don't pull uaccess.h into *.S
Split asm-only parts of arm64 uaccess.h into a new header and use that
from *.S.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk <mailto:viro@zeniv.linux.org.uk>>
Any chance we could either pull in the fix or move to rc2?
Thanks,
Rob
AS arch/arm64/kernel/entry.o
In file included from ./include/linux/sched.h:17:0,
from ./include/linux/uaccess.h:4,
from arch/arm64/kernel/entry.S:34:
./include/linux/kernel.h:49:0: warning: "ALIGN" redefined
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
^
In file included from arch/arm64/kernel/entry.S:22:0:
./include/linux/linkage.h:78:0: note: this is the location of the previous definition
#define ALIGN __ALIGN
^
In file included from ./include/linux/time.h:7:0,
from ./include/uapi/linux/timex.h:56,
from ./include/linux/timex.h:56,
from ./include/linux/sched.h:19,
from ./include/linux/uaccess.h:4,
from arch/arm64/kernel/entry.S:34:
./include/linux/time64.h:36:0: warning: "NSEC_PER_SEC" redefined
#define NSEC_PER_SEC 1000000000L
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: arm64 broken
2017-01-11 18:37 arm64 broken Rob Rice
@ 2017-01-12 7:50 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-01-12 7:50 UTC (permalink / raw)
To: Rob Rice; +Cc: linux-crypto
Rob Rice <rob.rice@broadcom.com> wrote:
> I’m working on updating a patchset. The master branch in crypto-2.6 doesn’t compile for ARM64. The first couple errors are listed below. A colleague believes that the following commit in rc2 fixes the problem.
I presume you mean cryptodev and not crypto.
> commit b4b8664d291ac1998e0f0bcdc96b6397f0fe68b3
> Author: Al Viro <viro@zeniv.linux.org.uk <mailto:viro@zeniv.linux.org.uk>>
> Date: Mon Dec 26 04:10:19 2016 -0500
>
> arm64: don't pull uaccess.h into *.S
>
> Split asm-only parts of arm64 uaccess.h into a new header and use that
> from *.S.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk <mailto:viro@zeniv.linux.org.uk>>
>
> Any chance we could either pull in the fix or move to rc2?
Sure I'll pull it in.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-12 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-11 18:37 arm64 broken Rob Rice
2017-01-12 7:50 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).