linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA
@ 2017-02-24 10:27 Geert Uytterhoeven
  2017-02-24 10:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK " Geert Uytterhoeven
  2017-02-27 10:37 ` [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA " Herbert Xu
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-02-24 10:27 UTC (permalink / raw)
  To: Herbert Xu, David S . Miller
  Cc: Arnd Bergmann, Matthias Brugger, linux-crypto, linux-kernel,
	Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/crypto/atmel-tdes.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/crypto/atmel-sha.ko] undefined!

Add dependencies on HAS_DMA to fix this.

Fixes: ceb4afb3086ab08f ("crypto: atmel - refine Kconfig dependencies")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 2cac445b02fde0f6..69f7fc0dc84dc3b9 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -445,6 +445,7 @@ config CRYPTO_DEV_ATMEL_AES
 
 config CRYPTO_DEV_ATMEL_TDES
 	tristate "Support for Atmel DES/TDES hw accelerator"
+	depends on HAS_DMA
 	depends on ARCH_AT91 || COMPILE_TEST
 	select CRYPTO_DES
 	select CRYPTO_BLKCIPHER
@@ -458,6 +459,7 @@ config CRYPTO_DEV_ATMEL_TDES
 
 config CRYPTO_DEV_ATMEL_SHA
 	tristate "Support for Atmel SHA hw accelerator"
+	depends on HAS_DMA
 	depends on ARCH_AT91 || COMPILE_TEST
 	select CRYPTO_HASH
 	help
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA
  2017-02-24 10:27 [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA Geert Uytterhoeven
@ 2017-02-24 10:27 ` Geert Uytterhoeven
  2017-02-27 10:38   ` Herbert Xu
  2017-02-27 10:37 ` [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA " Herbert Xu
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-02-24 10:27 UTC (permalink / raw)
  To: Herbert Xu, David S . Miller
  Cc: Arnd Bergmann, Matthias Brugger, linux-crypto, linux-kernel,
	Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/crypto/mediatek/mtk-crypto.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Fixes: 7dee9f618790d0b7 ("crypto: mediatek - remove ARM dependencies")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 69f7fc0dc84dc3b9..a7ff6e5d0ba92cb7 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -571,6 +571,7 @@ config CRYPTO_DEV_ROCKCHIP
 
 config CRYPTO_DEV_MEDIATEK
 	tristate "MediaTek's EIP97 Cryptographic Engine driver"
+	depends on HAS_DMA
 	depends on (ARM && ARCH_MEDIATEK) || COMPILE_TEST
 	select CRYPTO_AES
 	select CRYPTO_AEAD
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA
  2017-02-24 10:27 [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA Geert Uytterhoeven
  2017-02-24 10:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK " Geert Uytterhoeven
@ 2017-02-27 10:37 ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-02-27 10:37 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David S . Miller, Arnd Bergmann, Matthias Brugger, linux-crypto,
	linux-kernel

On Fri, Feb 24, 2017 at 11:27:38AM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/crypto/atmel-tdes.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/crypto/atmel-sha.ko] undefined!
> 
> Add dependencies on HAS_DMA to fix this.
> 
> Fixes: ceb4afb3086ab08f ("crypto: atmel - refine Kconfig dependencies")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA
  2017-02-24 10:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK " Geert Uytterhoeven
@ 2017-02-27 10:38   ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-02-27 10:38 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David S . Miller, Arnd Bergmann, Matthias Brugger, linux-crypto,
	linux-kernel

On Fri, Feb 24, 2017 at 11:27:39AM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/crypto/mediatek/mtk-crypto.ko] undefined!
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Fixes: 7dee9f618790d0b7 ("crypto: mediatek - remove ARM dependencies")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-27 10:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-24 10:27 [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA Geert Uytterhoeven
2017-02-24 10:27 ` [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK " Geert Uytterhoeven
2017-02-27 10:38   ` Herbert Xu
2017-02-27 10:37 ` [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA " Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).