* [PATCH] staging: ccree: Fix bool comparison
@ 2017-10-16 10:08 sunil.m
2017-10-16 21:17 ` Tobin C. Harding
0 siblings, 1 reply; 4+ messages in thread
From: sunil.m @ 2017-10-16 10:08 UTC (permalink / raw)
To: gilad, gregkh
Cc: linux-crypto, driverdev-devel, devel, linux-kernel, karthik,
Suniel Mahesh
From: Suniel Mahesh <sunil.m@techveda.org>
Bool tests don't need comparisons.
This fixes the following coccinelle warning:
WARNING: Comparison of bool to 0/1
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Note:
- Patch was tested and built(ARCH=arm) on latest
linux-next.
- No build issues reported, however it was not
tested on real hardware.
- Please discard this changeset, if this is not
helping the code look better.
---
drivers/staging/ccree/ssi_request_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
index 2e0df57..942afe2 100644
--- a/drivers/staging/ccree/ssi_request_mgr.c
+++ b/drivers/staging/ccree/ssi_request_mgr.c
@@ -272,7 +272,7 @@ int send_request(
unsigned int max_required_seq_len = (total_seq_len +
((ssi_req->ivgen_dma_addr_len == 0) ? 0 :
SSI_IVPOOL_SEQ_LEN) +
- ((is_dout == 0) ? 1 : 0));
+ (!is_dout ? 1 : 0));
#if defined(CONFIG_PM_RUNTIME) || defined(CONFIG_PM_SLEEP)
rc = ssi_power_mgr_runtime_get(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: ccree: Fix bool comparison
2017-10-16 10:08 [PATCH] staging: ccree: Fix bool comparison sunil.m
@ 2017-10-16 21:17 ` Tobin C. Harding
2017-10-18 2:10 ` [PATCH v2] " sunil.m
0 siblings, 1 reply; 4+ messages in thread
From: Tobin C. Harding @ 2017-10-16 21:17 UTC (permalink / raw)
To: sunil.m
Cc: devel, gregkh, driverdev-devel, karthik, linux-kernel, linux-crypto
On Mon, Oct 16, 2017 at 03:38:11PM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> Bool tests don't need comparisons.
This commit log could be a bit longer. You may like to read
Documentation/process/submitting-patches.rst (section 2).
> This fixes the following coccinelle warning:
> WARNING: Comparison of bool to 0/1
>
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
> ---
> Note:
> - Patch was tested and built(ARCH=arm) on latest
> linux-next.
Building is _not_ testing.
> - No build issues reported, however it was not
> tested on real hardware.
This is implicit if you state 'builds on ARM'
> - Please discard this changeset, if this is not
> helping the code look better.
This is implicit also ;)
> ---
> drivers/staging/ccree/ssi_request_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
> index 2e0df57..942afe2 100644
> --- a/drivers/staging/ccree/ssi_request_mgr.c
> +++ b/drivers/staging/ccree/ssi_request_mgr.c
> @@ -272,7 +272,7 @@ int send_request(
> unsigned int max_required_seq_len = (total_seq_len +
> ((ssi_req->ivgen_dma_addr_len == 0) ? 0 :
> SSI_IVPOOL_SEQ_LEN) +
> - ((is_dout == 0) ? 1 : 0));
> + (!is_dout ? 1 : 0));
Perhaps
- ((is_dout == 0) ? 1 : 0));
+ (is_dout ? 0 : 1)
Good luck,
Tobin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: ccree: Fix bool comparison
2017-10-16 21:17 ` Tobin C. Harding
@ 2017-10-18 2:10 ` sunil.m
2017-10-18 2:33 ` Tobin C. Harding
0 siblings, 1 reply; 4+ messages in thread
From: sunil.m @ 2017-10-18 2:10 UTC (permalink / raw)
To: gilad, gregkh, me
Cc: linux-crypto, driverdev-devel, devel, linux-kernel, karthik,
Suniel Mahesh
From: Suniel Mahesh <sunil.m@techveda.org>
Comparision operator "equal to" not required on a variable
"foo" of type "bool". Bool has only two values, can be used
directly or with logical not.
This fixes the following coccinelle warning:
WARNING: Comparison of bool to 0/1
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Changes for v2:
- Changed the commit log to give a more accurate description
of the changeset as suggested by Toby C.Harding
---
Note:
- Patch was built(ARCH=arm) on latest linux-next.
- No build issues reported, however it was not
tested on real hardware.
- Please discard this changeset, if this is not
helping the code look better.
---
drivers/staging/ccree/ssi_request_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
index 2e0df57..942afe2 100644
--- a/drivers/staging/ccree/ssi_request_mgr.c
+++ b/drivers/staging/ccree/ssi_request_mgr.c
@@ -272,7 +272,7 @@ int send_request(
unsigned int max_required_seq_len = (total_seq_len +
((ssi_req->ivgen_dma_addr_len == 0) ? 0 :
SSI_IVPOOL_SEQ_LEN) +
- ((is_dout == 0) ? 1 : 0));
+ (!is_dout ? 1 : 0));
#if defined(CONFIG_PM_RUNTIME) || defined(CONFIG_PM_SLEEP)
rc = ssi_power_mgr_runtime_get(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: ccree: Fix bool comparison
2017-10-18 2:10 ` [PATCH v2] " sunil.m
@ 2017-10-18 2:33 ` Tobin C. Harding
0 siblings, 0 replies; 4+ messages in thread
From: Tobin C. Harding @ 2017-10-18 2:33 UTC (permalink / raw)
To: sunil.m
Cc: gilad, gregkh, linux-crypto, driverdev-devel, devel,
linux-kernel, karthik
On Wed, Oct 18, 2017 at 07:40:14AM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> Comparision operator "equal to" not required on a variable
> "foo" of type "bool". Bool has only two values, can be used
> directly or with logical not.
>
> This fixes the following coccinelle warning:
> WARNING: Comparison of bool to 0/1
>
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Nice.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-18 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 10:08 [PATCH] staging: ccree: Fix bool comparison sunil.m
2017-10-16 21:17 ` Tobin C. Harding
2017-10-18 2:10 ` [PATCH v2] " sunil.m
2017-10-18 2:33 ` Tobin C. Harding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).