* [PATCH] crypto: bcm: remove -I. header search path and unused macro define
@ 2019-01-25 6:07 Masahiro Yamada
2019-02-01 6:51 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-01-25 6:07 UTC (permalink / raw)
To: Herbert Xu, linux-crypto; +Cc: Masahiro Yamada, David S. Miller, linux-kernel
The header search path -I. in kernel Makefiles is very suspicious;
it allows the compiler to search for headers in the top of $(srctree),
where obviously no header file exists.
'git grep BCMDRIVER' has no hit. So, this macro is not referenced.
I was able to build this driver without the extra compiler options.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/crypto/bcm/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/bcm/Makefile b/drivers/crypto/bcm/Makefile
index 13cb80e..7469e19 100644
--- a/drivers/crypto/bcm/Makefile
+++ b/drivers/crypto/bcm/Makefile
@@ -11,5 +11,3 @@
obj-$(CONFIG_CRYPTO_DEV_BCM_SPU) := bcm_crypto_spu.o
bcm_crypto_spu-objs := util.o spu.o spu2.o cipher.o
-
-ccflags-y += -I. -DBCMDRIVER
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: bcm: remove -I. header search path and unused macro define
2019-01-25 6:07 [PATCH] crypto: bcm: remove -I. header search path and unused macro define Masahiro Yamada
@ 2019-02-01 6:51 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-02-01 6:51 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-crypto, David S. Miller, linux-kernel
On Fri, Jan 25, 2019 at 03:07:48PM +0900, Masahiro Yamada wrote:
> The header search path -I. in kernel Makefiles is very suspicious;
> it allows the compiler to search for headers in the top of $(srctree),
> where obviously no header file exists.
>
> 'git grep BCMDRIVER' has no hit. So, this macro is not referenced.
>
> I was able to build this driver without the extra compiler options.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/crypto/bcm/Makefile | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-01 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 6:07 [PATCH] crypto: bcm: remove -I. header search path and unused macro define Masahiro Yamada
2019-02-01 6:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).