[PATCH] crypto: ccree: add missing inline qualifier

[PATCH] crypto: ccree: add missing inline qualifier

[Gilad Ben-Yossef]

Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
was missing a "inline" qualifier for stub function used when CONFIG_PM
is not set causing a build warning.

Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
Cc: stable@kernel.org # v4.20
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
 drivers/crypto/ccree/cc_pm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/ccree/cc_pm.h b/drivers/crypto/ccree/cc_pm.h
index f62624357020..907a6db4d6c0 100644
--- a/drivers/crypto/ccree/cc_pm.h
+++ b/drivers/crypto/ccree/cc_pm.h
@@ -30,7 +30,7 @@ static inline int cc_pm_init(struct cc_drvdata *drvdata)
 	return 0;
 }
 
-static void cc_pm_go(struct cc_drvdata *drvdata) {}
+static inline void cc_pm_go(struct cc_drvdata *drvdata) {}
 
 static inline void cc_pm_fini(struct cc_drvdata *drvdata) {}
 
-- 
2.20.1

Re: [PATCH] crypto: ccree: add missing inline qualifier

[Geert Uytterhoeven]

On Mon, Feb 11, 2019 at 3:29 PM Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> was missing a "inline" qualifier for stub function used when CONFIG_PM
> is not set causing a build warning.
>
> Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> Cc: stable@kernel.org # v4.20

# v5.0

However, I believe the version comment is not necessary, as the same
version is indicated by the Fixes tag.

> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] crypto: ccree: add missing inline qualifier

[Gilad Ben-Yossef]

Hi,

On Mon, Feb 18, 2019 at 10:48 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> On Mon, Feb 11, 2019 at 3:29 PM Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> > Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> > was missing a "inline" qualifier for stub function used when CONFIG_PM
> > is not set causing a build warning.
> >
> > Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> > Cc: stable@kernel.org # v4.20
>
> # v5.0
>
> However, I believe the version comment is not necessary, as the same
> version is indicated by the Fixes tag.

I've marked it v4.20 since I've marked the patch that this fixes for
inclusion in 4.20.

Although the underlying bug was there all along, it was only revealed
by a change that
went into 4.20.
>
> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>


Thanks!
Gilad


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!

Re: [PATCH] crypto: ccree: add missing inline qualifier

[Herbert Xu]

On Mon, Feb 11, 2019 at 04:27:58PM +0200, Gilad Ben-Yossef wrote:
> Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> was missing a "inline" qualifier for stub function used when CONFIG_PM
> is not set causing a build warning.
> 
> Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> Cc: stable@kernel.org # v4.20
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
>  drivers/crypto/ccree/cc_pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt