linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: s5p-sss - Use AES_BLOCK_SIZE define instead of number
@ 2019-02-19 12:01 Krzysztof Kozlowski
  2019-02-28  6:29 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-02-19 12:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Vladimir Zapolskiy, Kamil Konieczny,
	Herbert Xu, David S. Miller, linux-crypto, linux-samsung-soc,
	linux-kernel

Replace hard coded AES block size with define.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/crypto/s5p-sss.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 0064be0e3941..39fc6942364b 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -1819,10 +1819,12 @@ static void s5p_set_aes(struct s5p_aes_dev *dev,
 	void __iomem *keystart;
 
 	if (iv)
-		memcpy_toio(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv, 0x10);
+		memcpy_toio(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv,
+			    AES_BLOCK_SIZE);
 
 	if (ctr)
-		memcpy_toio(dev->aes_ioaddr + SSS_REG_AES_CNT_DATA(0), ctr, 0x10);
+		memcpy_toio(dev->aes_ioaddr + SSS_REG_AES_CNT_DATA(0), ctr,
+			    AES_BLOCK_SIZE);
 
 	if (keylen == AES_KEYSIZE_256)
 		keystart = dev->aes_ioaddr + SSS_REG_AES_KEY_DATA(0);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: s5p-sss - Use AES_BLOCK_SIZE define instead of number
  2019-02-19 12:01 [PATCH] crypto: s5p-sss - Use AES_BLOCK_SIZE define instead of number Krzysztof Kozlowski
@ 2019-02-28  6:29 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-02-28  6:29 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Vladimir Zapolskiy, Kamil Konieczny, David S. Miller,
	linux-crypto, linux-samsung-soc, linux-kernel

On Tue, Feb 19, 2019 at 01:01:03PM +0100, Krzysztof Kozlowski wrote:
> Replace hard coded AES block size with define.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/s5p-sss.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-28  6:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 12:01 [PATCH] crypto: s5p-sss - Use AES_BLOCK_SIZE define instead of number Krzysztof Kozlowski
2019-02-28  6:29 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).