* Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433
2019-03-01 14:02 ` [PATCH] crypto: s5p-sss - fix AES support for Exynos5433 Kamil Konieczny
@ 2019-03-01 14:18 ` Krzysztof Kozlowski
2019-03-07 8:25 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2019-03-01 14:18 UTC (permalink / raw)
To: Kamil Konieczny
Cc: Herbert Xu, David S. Miller, Vladimir Zapolskiy,
Bartlomiej Zolnierkiewicz, Marek Szyprowski, linux-crypto,
linux-samsung-soc, linux-kernel
On Fri, 1 Mar 2019 at 15:03, Kamil Konieczny
<k.konieczny@partner.samsung.com> wrote:
>
> Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> introduced bug in dereferencing clk_names[1] on platforms different from
> Exynos5433. On Exynos board XU3 call trace is:
>
> "Unable to handle kernel paging request at virtual address 00004000"
> (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
> ...
> (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
> (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)
>
> Fix this by setting array clk_names size to 2.
>
> Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> ---
> drivers/crypto/s5p-sss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for fast fix!
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested on Exynos5422 Odroid HC1:
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: s5p-sss - fix AES support for Exynos5433
2019-03-01 14:02 ` [PATCH] crypto: s5p-sss - fix AES support for Exynos5433 Kamil Konieczny
2019-03-01 14:18 ` Krzysztof Kozlowski
@ 2019-03-07 8:25 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-03-07 8:25 UTC (permalink / raw)
To: Kamil Konieczny
Cc: David S. Miller, Krzysztof Kozlowski, Vladimir Zapolskiy,
Bartlomiej Zolnierkiewicz, Marek Szyprowski, linux-crypto,
linux-samsung-soc, linux-kernel
On Fri, Mar 01, 2019 at 03:02:54PM +0100, Kamil Konieczny wrote:
> Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> introduced bug in dereferencing clk_names[1] on platforms different from
> Exynos5433. On Exynos board XU3 call trace is:
>
> "Unable to handle kernel paging request at virtual address 00004000"
> (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0)
> ...
> (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0)
> (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4)
>
> Fix this by setting array clk_names size to 2.
>
> Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433")
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> ---
> drivers/crypto/s5p-sss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread