* [PATCH] crypto: arm/sha512 - make function static
@ 2019-05-22 10:07 Philippe Mazenauer
2019-05-23 5:38 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mazenauer @ 2019-05-22 10:07 UTC (permalink / raw)
Cc: Philippe Mazenauer, Herbert Xu, David S. Miller, Russell King,
open list:CRYPTO API, moderated list:ARM PORT, open list
Function sha512_arm_final() is only used in this file, therefore should
be static
../arch/arm/crypto/sha512-glue.c:40:5: warning: no previous prototype for ‘sha512_arm_final’ [-Wmissing-prototypes]
int sha512_arm_final(struct shash_desc *desc, u8 *out)
^~~~~~~~~~~~~~~~
Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
---
arch/arm/crypto/sha512-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/crypto/sha512-glue.c b/arch/arm/crypto/sha512-glue.c
index 86540cd4a6fa..23fc3813a91b 100644
--- a/arch/arm/crypto/sha512-glue.c
+++ b/arch/arm/crypto/sha512-glue.c
@@ -37,7 +37,7 @@ int sha512_arm_update(struct shash_desc *desc, const u8 *data,
(sha512_block_fn *)sha512_block_data_order);
}
-int sha512_arm_final(struct shash_desc *desc, u8 *out)
+static int sha512_arm_final(struct shash_desc *desc, u8 *out)
{
sha512_base_do_finalize(desc,
(sha512_block_fn *)sha512_block_data_order);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: arm/sha512 - make function static
2019-05-22 10:07 [PATCH] crypto: arm/sha512 - make function static Philippe Mazenauer
@ 2019-05-23 5:38 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-05-23 5:38 UTC (permalink / raw)
To: Philippe Mazenauer
Cc: David S. Miller, Russell King, open list:CRYPTO API,
moderated list:ARM PORT, open list
On Wed, May 22, 2019 at 10:07:14AM +0000, Philippe Mazenauer wrote:
> Function sha512_arm_final() is only used in this file, therefore should
> be static
>
> ../arch/arm/crypto/sha512-glue.c:40:5: warning: no previous prototype for ‘sha512_arm_final’ [-Wmissing-prototypes]
> int sha512_arm_final(struct shash_desc *desc, u8 *out)
> ^~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
An identical patch is already in the patchwork queue.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-23 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 10:07 [PATCH] crypto: arm/sha512 - make function static Philippe Mazenauer
2019-05-23 5:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).