* [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load
@ 2019-07-29 12:56 Hook, Gary
2019-08-09 6:10 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Hook, Gary @ 2019-07-29 12:56 UTC (permalink / raw)
To: linux-crypto; +Cc: herbert, davem, Lendacky, Thomas, Hook, Gary
From: Gary R Hook <gary.hook@amd.com>
If there are no CCP devices on the system, ccp-crypto will not load.
Write a message to the system log clarifying the reason for the failure
of the modprobe operation
Signed-off-by: Gary R Hook <gary.hook@amd.com>
---
Changes since v1:
- Add missing signed-off-by
drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c
index 818096490829..8ee4cb45a3f3 100644
--- a/drivers/crypto/ccp/ccp-crypto-main.c
+++ b/drivers/crypto/ccp/ccp-crypto-main.c
@@ -405,8 +405,10 @@ static int ccp_crypto_init(void)
int ret;
ret = ccp_present();
- if (ret)
+ if (ret) {
+ pr_err("Cannot load: there are no available CCPs\n");
return ret;
+ }
spin_lock_init(&req_queue_lock);
INIT_LIST_HEAD(&req_queue.cmds);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load
2019-07-29 12:56 [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load Hook, Gary
@ 2019-08-09 6:10 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-08-09 6:10 UTC (permalink / raw)
To: Hook, Gary; +Cc: linux-crypto, davem, Lendacky, Thomas
On Mon, Jul 29, 2019 at 12:56:08PM +0000, Hook, Gary wrote:
> From: Gary R Hook <gary.hook@amd.com>
>
> If there are no CCP devices on the system, ccp-crypto will not load.
> Write a message to the system log clarifying the reason for the failure
> of the modprobe operation
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
>
> Changes since v1:
> - Add missing signed-off-by
>
> drivers/crypto/ccp/ccp-crypto-main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-09 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 12:56 [PATCH v2] crypto: ccp - Log an error message when ccp-crypto fails to load Hook, Gary
2019-08-09 6:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).