* [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code
@ 2019-10-16 10:46 YueHaibing
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
` (14 more replies)
0 siblings, 15 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
devm_platform_ioremap_resource() internally have platform_get_resource()
and devm_ioremap_resource() in it. So instead of calling them separately
use devm_platform_ioremap_resource() directly.
YueHaibing (13):
hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
hwrng: meson - use devm_platform_ioremap_resource() to simplify code
hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
hwrng: omap - use devm_platform_ioremap_resource() to simplify code
hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
hwrng: st - use devm_platform_ioremap_resource() to simplify code
hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
drivers/char/hw_random/atmel-rng.c | 4 +---
drivers/char/hw_random/bcm2835-rng.c | 5 +----
drivers/char/hw_random/exynos-trng.c | 4 +---
drivers/char/hw_random/hisi-rng.c | 4 +---
drivers/char/hw_random/ks-sa-rng.c | 4 +---
drivers/char/hw_random/meson-rng.c | 4 +---
drivers/char/hw_random/npcm-rng.c | 4 +---
drivers/char/hw_random/omap-rng.c | 4 +---
drivers/char/hw_random/pasemi-rng.c | 4 +---
drivers/char/hw_random/pic32-rng.c | 4 +---
drivers/char/hw_random/st-rng.c | 4 +---
drivers/char/hw_random/tx4939-rng.c | 4 +---
drivers/char/hw_random/xgene-rng.c | 4 +---
13 files changed, 13 insertions(+), 40 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH -next 01/13] hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-17 9:32 ` Ludovic Desroches
2019-10-16 10:46 ` [PATCH -next 02/13] hwrng: bcm2835 " YueHaibing
` (13 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/atmel-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
index e557057..b3138ec2 100644
--- a/drivers/char/hw_random/atmel-rng.c
+++ b/drivers/char/hw_random/atmel-rng.c
@@ -62,15 +62,13 @@ static void atmel_trng_disable(struct atmel_trng *trng)
static int atmel_trng_probe(struct platform_device *pdev)
{
struct atmel_trng *trng;
- struct resource *res;
int ret;
trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
if (!trng)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- trng->base = devm_ioremap_resource(&pdev->dev, res);
+ trng->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(trng->base))
return PTR_ERR(trng->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 02/13] hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 16:41 ` Florian Fainelli
2019-10-16 10:46 ` [PATCH -next 03/13] hwrng: exynos " YueHaibing
` (12 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/bcm2835-rng.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
index f759790..d2a5791 100644
--- a/drivers/char/hw_random/bcm2835-rng.c
+++ b/drivers/char/hw_random/bcm2835-rng.c
@@ -142,7 +142,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
const struct of_device_id *rng_id;
struct bcm2835_rng_priv *priv;
- struct resource *r;
int err;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -151,10 +150,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
/* map peripheral */
- priv->base = devm_ioremap_resource(dev, r);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 03/13] hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
2019-10-16 10:46 ` [PATCH -next 02/13] hwrng: bcm2835 " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
[not found] ` <CGME20191018150543eucas1p1cf4312467597ad7c76f258e924d8184a@eucas1p1.samsung.com>
2019-10-16 10:46 ` [PATCH -next 04/13] hwrng: hisi " YueHaibing
` (11 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/exynos-trng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
index b4b52ab..8e1fe3f 100644
--- a/drivers/char/hw_random/exynos-trng.c
+++ b/drivers/char/hw_random/exynos-trng.c
@@ -109,7 +109,6 @@ static int exynos_trng_init(struct hwrng *rng)
static int exynos_trng_probe(struct platform_device *pdev)
{
struct exynos_trng_dev *trng;
- struct resource *res;
int ret = -ENOMEM;
trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
@@ -128,8 +127,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, trng);
trng->dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- trng->mem = devm_ioremap_resource(&pdev->dev, res);
+ trng->mem = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(trng->mem))
return PTR_ERR(trng->mem);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 04/13] hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (2 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 03/13] hwrng: exynos " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 05/13] hwrng: ks-sa " YueHaibing
` (10 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/hisi-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
index c663d5d..6815e17 100644
--- a/drivers/char/hw_random/hisi-rng.c
+++ b/drivers/char/hw_random/hisi-rng.c
@@ -73,7 +73,6 @@ static int hisi_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
static int hisi_rng_probe(struct platform_device *pdev)
{
struct hisi_rng *rng;
- struct resource *res;
int ret;
rng = devm_kzalloc(&pdev->dev, sizeof(*rng), GFP_KERNEL);
@@ -82,8 +81,7 @@ static int hisi_rng_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rng);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- rng->base = devm_ioremap_resource(&pdev->dev, res);
+ rng->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(rng->base))
return PTR_ERR(rng->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 05/13] hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (3 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 04/13] hwrng: hisi " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 06/13] hwrng: meson " YueHaibing
` (9 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/ks-sa-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
index a674300..556400a 100644
--- a/drivers/char/hw_random/ks-sa-rng.c
+++ b/drivers/char/hw_random/ks-sa-rng.c
@@ -174,7 +174,6 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
struct ks_sa_rng *ks_sa_rng;
struct device *dev = &pdev->dev;
int ret;
- struct resource *mem;
ks_sa_rng = devm_kzalloc(dev, sizeof(*ks_sa_rng), GFP_KERNEL);
if (!ks_sa_rng)
@@ -190,8 +189,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
};
ks_sa_rng->rng.priv = (unsigned long)dev;
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ks_sa_rng->reg_rng = devm_ioremap_resource(dev, mem);
+ ks_sa_rng->reg_rng = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ks_sa_rng->reg_rng))
return PTR_ERR(ks_sa_rng->reg_rng);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 06/13] hwrng: meson - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (4 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 05/13] hwrng: ks-sa " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 16:26 ` Kevin Hilman
2019-10-16 10:46 ` [PATCH -next 07/13] hwrng: npcm " YueHaibing
` (8 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/meson-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 76e693d..e446236 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -42,7 +42,6 @@ static int meson_rng_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct meson_rng_data *data;
- struct resource *res;
int ret;
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
@@ -51,8 +50,7 @@ static int meson_rng_probe(struct platform_device *pdev)
data->pdev = pdev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- data->base = devm_ioremap_resource(dev, res);
+ data->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->base))
return PTR_ERR(data->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 07/13] hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (5 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 06/13] hwrng: meson " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 08/13] hwrng: omap " YueHaibing
` (7 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/npcm-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/npcm-rng.c b/drivers/char/hw_random/npcm-rng.c
index b7c8c7e..01d0440 100644
--- a/drivers/char/hw_random/npcm-rng.c
+++ b/drivers/char/hw_random/npcm-rng.c
@@ -87,15 +87,13 @@ static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
static int npcm_rng_probe(struct platform_device *pdev)
{
struct npcm_rng *priv;
- struct resource *res;
int ret;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 08/13] hwrng: omap - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (6 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 07/13] hwrng: npcm " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 09/13] hwrng: pasemi " YueHaibing
` (6 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/omap-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index b27f396..b3f4a00 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -432,7 +432,6 @@ static int get_omap_rng_device_details(struct omap_rng_dev *omap_rng)
static int omap_rng_probe(struct platform_device *pdev)
{
struct omap_rng_dev *priv;
- struct resource *res;
struct device *dev = &pdev->dev;
int ret;
@@ -449,8 +448,7 @@ static int omap_rng_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
priv->dev = dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
ret = PTR_ERR(priv->base);
goto err_ioremap;
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 09/13] hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (7 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 08/13] hwrng: omap " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 10/13] hwrng: pic32 " YueHaibing
` (5 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/pasemi-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/pasemi-rng.c b/drivers/char/hw_random/pasemi-rng.c
index 24b1460..2498d4e 100644
--- a/drivers/char/hw_random/pasemi-rng.c
+++ b/drivers/char/hw_random/pasemi-rng.c
@@ -86,10 +86,8 @@ static struct hwrng pasemi_rng = {
static int rng_probe(struct platform_device *pdev)
{
void __iomem *rng_regs;
- struct resource *res;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- rng_regs = devm_ioremap_resource(&pdev->dev, res);
+ rng_regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(rng_regs))
return PTR_ERR(rng_regs);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 10/13] hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (8 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 09/13] hwrng: pasemi " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 11/13] hwrng: st " YueHaibing
` (4 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/pic32-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/pic32-rng.c b/drivers/char/hw_random/pic32-rng.c
index 90f498c..81080cb 100644
--- a/drivers/char/hw_random/pic32-rng.c
+++ b/drivers/char/hw_random/pic32-rng.c
@@ -70,7 +70,6 @@ static int pic32_rng_read(struct hwrng *rng, void *buf, size_t max,
static int pic32_rng_probe(struct platform_device *pdev)
{
struct pic32_rng *priv;
- struct resource *res;
u32 v;
int ret;
@@ -78,8 +77,7 @@ static int pic32_rng_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 11/13] hwrng: st - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (9 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 10/13] hwrng: pic32 " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 11:29 ` Patrice CHOTARD
2019-10-16 10:46 ` [PATCH -next 12/13] hwrng: tx4939 " YueHaibing
` (3 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/st-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c
index 8634483..783c24e 100644
--- a/drivers/char/hw_random/st-rng.c
+++ b/drivers/char/hw_random/st-rng.c
@@ -72,7 +72,6 @@ static int st_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
static int st_rng_probe(struct platform_device *pdev)
{
struct st_rng_data *ddata;
- struct resource *res;
struct clk *clk;
void __iomem *base;
int ret;
@@ -81,8 +80,7 @@ static int st_rng_probe(struct platform_device *pdev)
if (!ddata)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 12/13] hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (10 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 11/13] hwrng: st " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 10:46 ` [PATCH -next 13/13] hwrng: xgene " YueHaibing
` (2 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/tx4939-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/tx4939-rng.c b/drivers/char/hw_random/tx4939-rng.c
index 1093583..c8bd34e 100644
--- a/drivers/char/hw_random/tx4939-rng.c
+++ b/drivers/char/hw_random/tx4939-rng.c
@@ -107,14 +107,12 @@ static int tx4939_rng_data_read(struct hwrng *rng, u32 *buffer)
static int __init tx4939_rng_probe(struct platform_device *dev)
{
struct tx4939_rng *rngdev;
- struct resource *r;
int i;
rngdev = devm_kzalloc(&dev->dev, sizeof(*rngdev), GFP_KERNEL);
if (!rngdev)
return -ENOMEM;
- r = platform_get_resource(dev, IORESOURCE_MEM, 0);
- rngdev->base = devm_ioremap_resource(&dev->dev, r);
+ rngdev->base = devm_platform_ioremap_resource(dev, 0);
if (IS_ERR(rngdev->base))
return PTR_ERR(rngdev->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH -next 13/13] hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (11 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 12/13] hwrng: tx4939 " YueHaibing
@ 2019-10-16 10:46 ` YueHaibing
2019-10-16 16:44 ` [PATCH -next 00/13] hwrng: " Florian Fainelli
2019-10-25 15:20 ` Herbert Xu
14 siblings, 0 replies; 22+ messages in thread
From: YueHaibing @ 2019-10-16 10:46 UTC (permalink / raw)
To: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/hw_random/xgene-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index 7e568db..d7516a4 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -313,7 +313,6 @@ static struct hwrng xgene_rng_func = {
static int xgene_rng_probe(struct platform_device *pdev)
{
- struct resource *res;
struct xgene_rng_dev *ctx;
int rc = 0;
@@ -324,8 +323,7 @@ static int xgene_rng_probe(struct platform_device *pdev)
ctx->dev = &pdev->dev;
platform_set_drvdata(pdev, ctx);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ctx->csr_base = devm_ioremap_resource(&pdev->dev, res);
+ ctx->csr_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ctx->csr_base))
return PTR_ERR(ctx->csr_base);
--
2.7.4
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH -next 11/13] hwrng: st - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 ` [PATCH -next 11/13] hwrng: st " YueHaibing
@ 2019-10-16 11:29 ` Patrice CHOTARD
0 siblings, 0 replies; 22+ messages in thread
From: Patrice CHOTARD @ 2019-10-16 11:29 UTC (permalink / raw)
To: YueHaibing, herbert, mpm, arnd, gregkh, nicolas.ferre,
alexandre.belloni, ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev
Hi
On 10/16/19 12:46 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/char/hw_random/st-rng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c
> index 8634483..783c24e 100644
> --- a/drivers/char/hw_random/st-rng.c
> +++ b/drivers/char/hw_random/st-rng.c
> @@ -72,7 +72,6 @@ static int st_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
> static int st_rng_probe(struct platform_device *pdev)
> {
> struct st_rng_data *ddata;
> - struct resource *res;
> struct clk *clk;
> void __iomem *base;
> int ret;
> @@ -81,8 +80,7 @@ static int st_rng_probe(struct platform_device *pdev)
> if (!ddata)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 06/13] hwrng: meson - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 ` [PATCH -next 06/13] hwrng: meson " YueHaibing
@ 2019-10-16 16:26 ` Kevin Hilman
0 siblings, 0 replies; 22+ messages in thread
From: Kevin Hilman @ 2019-10-16 16:26 UTC (permalink / raw)
To: YueHaibing, herbert, mpm, arnd, gregkh, nicolas.ferre,
alexandre.belloni, ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev, YueHaibing
YueHaibing <yuehaibing@huawei.com> writes:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 02/13] hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 ` [PATCH -next 02/13] hwrng: bcm2835 " YueHaibing
@ 2019-10-16 16:41 ` Florian Fainelli
0 siblings, 0 replies; 22+ messages in thread
From: Florian Fainelli @ 2019-10-16 16:41 UTC (permalink / raw)
To: YueHaibing, herbert, mpm, arnd, gregkh, nicolas.ferre,
alexandre.belloni, ludovic.desroches, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev
On 10/16/19 3:46 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (12 preceding siblings ...)
2019-10-16 10:46 ` [PATCH -next 13/13] hwrng: xgene " YueHaibing
@ 2019-10-16 16:44 ` Florian Fainelli
2019-10-17 1:27 ` Yuehaibing
2019-10-25 15:20 ` Herbert Xu
14 siblings, 1 reply; 22+ messages in thread
From: Florian Fainelli @ 2019-10-16 16:44 UTC (permalink / raw)
To: YueHaibing, herbert, mpm, arnd, gregkh, nicolas.ferre,
alexandre.belloni, ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev
On 10/16/19 3:46 AM, YueHaibing wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
Did your coccinelle script not cover
drivers/char/hw_random/iproc-rng200.c somehow? Do you mind including it
as a separate patch?
Thanks
>
> YueHaibing (13):
> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
> hwrng: meson - use devm_platform_ioremap_resource() to simplify code
> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
> hwrng: omap - use devm_platform_ioremap_resource() to simplify code
> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
> hwrng: st - use devm_platform_ioremap_resource() to simplify code
> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
>
> drivers/char/hw_random/atmel-rng.c | 4 +---
> drivers/char/hw_random/bcm2835-rng.c | 5 +----
> drivers/char/hw_random/exynos-trng.c | 4 +---
> drivers/char/hw_random/hisi-rng.c | 4 +---
> drivers/char/hw_random/ks-sa-rng.c | 4 +---
> drivers/char/hw_random/meson-rng.c | 4 +---
> drivers/char/hw_random/npcm-rng.c | 4 +---
> drivers/char/hw_random/omap-rng.c | 4 +---
> drivers/char/hw_random/pasemi-rng.c | 4 +---
> drivers/char/hw_random/pic32-rng.c | 4 +---
> drivers/char/hw_random/st-rng.c | 4 +---
> drivers/char/hw_random/tx4939-rng.c | 4 +---
> drivers/char/hw_random/xgene-rng.c | 4 +---
> 13 files changed, 13 insertions(+), 40 deletions(-)
>
--
Florian
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code
2019-10-16 16:44 ` [PATCH -next 00/13] hwrng: " Florian Fainelli
@ 2019-10-17 1:27 ` Yuehaibing
0 siblings, 0 replies; 22+ messages in thread
From: Yuehaibing @ 2019-10-17 1:27 UTC (permalink / raw)
To: Florian Fainelli, herbert, mpm, arnd, gregkh, nicolas.ferre,
alexandre.belloni, ludovic.desroches, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard
Cc: linux-crypto, linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev
On 2019/10/17 0:44, Florian Fainelli wrote:
> On 10/16/19 3:46 AM, YueHaibing wrote:
>> devm_platform_ioremap_resource() internally have platform_get_resource()
>> and devm_ioremap_resource() in it. So instead of calling them separately
>> use devm_platform_ioremap_resource() directly.
>
> Did your coccinelle script not cover
> drivers/char/hw_random/iproc-rng200.c somehow? Do you mind including it
> as a separate patch?
A patch from Markus Elfring has be queued:
commit a68b931932c5574aa5bd459529c766ba577c72b3
Author: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed Sep 18 09:09:22 2019 +0200
hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Thanks
>
>>
>> YueHaibing (13):
>> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
>> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
>> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
>> hwrng: meson - use devm_platform_ioremap_resource() to simplify code
>> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
>> hwrng: omap - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: st - use devm_platform_ioremap_resource() to simplify code
>> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
>>
>> drivers/char/hw_random/atmel-rng.c | 4 +---
>> drivers/char/hw_random/bcm2835-rng.c | 5 +----
>> drivers/char/hw_random/exynos-trng.c | 4 +---
>> drivers/char/hw_random/hisi-rng.c | 4 +---
>> drivers/char/hw_random/ks-sa-rng.c | 4 +---
>> drivers/char/hw_random/meson-rng.c | 4 +---
>> drivers/char/hw_random/npcm-rng.c | 4 +---
>> drivers/char/hw_random/omap-rng.c | 4 +---
>> drivers/char/hw_random/pasemi-rng.c | 4 +---
>> drivers/char/hw_random/pic32-rng.c | 4 +---
>> drivers/char/hw_random/st-rng.c | 4 +---
>> drivers/char/hw_random/tx4939-rng.c | 4 +---
>> drivers/char/hw_random/xgene-rng.c | 4 +---
>> 13 files changed, 13 insertions(+), 40 deletions(-)
>>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 01/13] hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
@ 2019-10-17 9:32 ` Ludovic Desroches
0 siblings, 0 replies; 22+ messages in thread
From: Ludovic Desroches @ 2019-10-17 9:32 UTC (permalink / raw)
To: YueHaibing
Cc: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list, eric,
wahrenst, l.stelmach, kgene, krzk, khilman, dsaxena,
patrice.chotard, linux-crypto, linux-arm-kernel, linux-kernel,
linux-rpi-kernel, linux-samsung-soc, linux-amlogic, linuxppc-dev
On Wed, Oct 16, 2019 at 06:46:09PM +0800, YueHaibing wrote:
> External E-Mail
>
>
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
> drivers/char/hw_random/atmel-rng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
> index e557057..b3138ec2 100644
> --- a/drivers/char/hw_random/atmel-rng.c
> +++ b/drivers/char/hw_random/atmel-rng.c
> @@ -62,15 +62,13 @@ static void atmel_trng_disable(struct atmel_trng *trng)
> static int atmel_trng_probe(struct platform_device *pdev)
> {
> struct atmel_trng *trng;
> - struct resource *res;
> int ret;
>
> trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
> if (!trng)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - trng->base = devm_ioremap_resource(&pdev->dev, res);
> + trng->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(trng->base))
> return PTR_ERR(trng->base);
>
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 03/13] hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
[not found] ` <CGME20191018150543eucas1p1cf4312467597ad7c76f258e924d8184a@eucas1p1.samsung.com>
@ 2019-10-18 15:05 ` Łukasz Stelmach
0 siblings, 0 replies; 22+ messages in thread
From: Łukasz Stelmach @ 2019-10-18 15:05 UTC (permalink / raw)
To: YueHaibing
Cc: herbert, mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, kgene, krzk, khilman,
dsaxena, patrice.chotard, linux-crypto, linux-arm-kernel,
linux-kernel, linux-rpi-kernel, linux-samsung-soc, linux-amlogic,
linuxppc-dev
It was <2019-10-16 śro 12:46>, when YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/char/hw_random/exynos-trng.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index b4b52ab..8e1fe3f 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -109,7 +109,6 @@ static int exynos_trng_init(struct hwrng *rng)
> static int exynos_trng_probe(struct platform_device *pdev)
> {
> struct exynos_trng_dev *trng;
> - struct resource *res;
> int ret = -ENOMEM;
>
> trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL);
> @@ -128,8 +127,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, trng);
> trng->dev = &pdev->dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - trng->mem = devm_ioremap_resource(&pdev->dev, res);
> + trng->mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(trng->mem))
> return PTR_ERR(trng->mem);
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
` (13 preceding siblings ...)
2019-10-16 16:44 ` [PATCH -next 00/13] hwrng: " Florian Fainelli
@ 2019-10-25 15:20 ` Herbert Xu
14 siblings, 0 replies; 22+ messages in thread
From: Herbert Xu @ 2019-10-25 15:20 UTC (permalink / raw)
To: YueHaibing
Cc: mpm, arnd, gregkh, nicolas.ferre, alexandre.belloni,
ludovic.desroches, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list, eric, wahrenst, l.stelmach, kgene,
krzk, khilman, dsaxena, patrice.chotard, linux-crypto,
linux-arm-kernel, linux-kernel, linux-rpi-kernel,
linux-samsung-soc, linux-amlogic, linuxppc-dev
On Wed, Oct 16, 2019 at 06:46:08PM +0800, YueHaibing wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> YueHaibing (13):
> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
> hwrng: meson - use devm_platform_ioremap_resource() to simplify code
> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
> hwrng: omap - use devm_platform_ioremap_resource() to simplify code
> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
> hwrng: st - use devm_platform_ioremap_resource() to simplify code
> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
>
> drivers/char/hw_random/atmel-rng.c | 4 +---
> drivers/char/hw_random/bcm2835-rng.c | 5 +----
> drivers/char/hw_random/exynos-trng.c | 4 +---
> drivers/char/hw_random/hisi-rng.c | 4 +---
> drivers/char/hw_random/ks-sa-rng.c | 4 +---
> drivers/char/hw_random/meson-rng.c | 4 +---
> drivers/char/hw_random/npcm-rng.c | 4 +---
> drivers/char/hw_random/omap-rng.c | 4 +---
> drivers/char/hw_random/pasemi-rng.c | 4 +---
> drivers/char/hw_random/pic32-rng.c | 4 +---
> drivers/char/hw_random/st-rng.c | 4 +---
> drivers/char/hw_random/tx4939-rng.c | 4 +---
> drivers/char/hw_random/xgene-rng.c | 4 +---
> 13 files changed, 13 insertions(+), 40 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-10-25 15:21 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
2019-10-17 9:32 ` Ludovic Desroches
2019-10-16 10:46 ` [PATCH -next 02/13] hwrng: bcm2835 " YueHaibing
2019-10-16 16:41 ` Florian Fainelli
2019-10-16 10:46 ` [PATCH -next 03/13] hwrng: exynos " YueHaibing
[not found] ` <CGME20191018150543eucas1p1cf4312467597ad7c76f258e924d8184a@eucas1p1.samsung.com>
2019-10-18 15:05 ` Łukasz Stelmach
2019-10-16 10:46 ` [PATCH -next 04/13] hwrng: hisi " YueHaibing
2019-10-16 10:46 ` [PATCH -next 05/13] hwrng: ks-sa " YueHaibing
2019-10-16 10:46 ` [PATCH -next 06/13] hwrng: meson " YueHaibing
2019-10-16 16:26 ` Kevin Hilman
2019-10-16 10:46 ` [PATCH -next 07/13] hwrng: npcm " YueHaibing
2019-10-16 10:46 ` [PATCH -next 08/13] hwrng: omap " YueHaibing
2019-10-16 10:46 ` [PATCH -next 09/13] hwrng: pasemi " YueHaibing
2019-10-16 10:46 ` [PATCH -next 10/13] hwrng: pic32 " YueHaibing
2019-10-16 10:46 ` [PATCH -next 11/13] hwrng: st " YueHaibing
2019-10-16 11:29 ` Patrice CHOTARD
2019-10-16 10:46 ` [PATCH -next 12/13] hwrng: tx4939 " YueHaibing
2019-10-16 10:46 ` [PATCH -next 13/13] hwrng: xgene " YueHaibing
2019-10-16 16:44 ` [PATCH -next 00/13] hwrng: " Florian Fainelli
2019-10-17 1:27 ` Yuehaibing
2019-10-25 15:20 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).