* [PATCH] crypto: inside-secure - Add missed clk_disable_unprepare
@ 2019-11-01 14:37 Chuhong Yuan
2019-11-08 15:21 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-01 14:37 UTC (permalink / raw)
Cc: Antoine Tenart, Herbert Xu, David S . Miller, linux-crypto,
linux-kernel, Chuhong Yuan
safexcel_remove misses disabling priv->reg_clk like what is done when
probe fails.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/crypto/inside-secure/safexcel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 4ab1bde8dd9b..24c0f2404ec6 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1623,6 +1623,7 @@ static int safexcel_remove(struct platform_device *pdev)
safexcel_unregister_algorithms(priv);
safexcel_hw_reset_rings(priv);
+ clk_disable_unprepare(priv->reg_clk);
clk_disable_unprepare(priv->clk);
for (i = 0; i < priv->config.rings; i++)
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: inside-secure - Add missed clk_disable_unprepare
2019-11-01 14:37 [PATCH] crypto: inside-secure - Add missed clk_disable_unprepare Chuhong Yuan
@ 2019-11-08 15:21 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-11-08 15:21 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Antoine Tenart, David S . Miller, linux-crypto, linux-kernel
On Fri, Nov 01, 2019 at 10:37:15PM +0800, Chuhong Yuan wrote:
> safexcel_remove misses disabling priv->reg_clk like what is done when
> probe fails.
> Add the missed call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/crypto/inside-secure/safexcel.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-08 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 14:37 [PATCH] crypto: inside-secure - Add missed clk_disable_unprepare Chuhong Yuan
2019-11-08 15:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).