* [PATCH] crypto: essiv: remove redundant null pointer check before kfree
@ 2019-11-16 6:51 Chen Wandun
2019-11-22 11:09 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2019-11-16 6:51 UTC (permalink / raw)
To: herbert, davem, linux-crypto, linux-kernel; +Cc: chenwandun
kfree has taken null pointer check into account. so it is safe to
remove the unnecessary check.
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
crypto/essiv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/crypto/essiv.c b/crypto/essiv.c
index efea5af..75d810d 100644
--- a/crypto/essiv.c
+++ b/crypto/essiv.c
@@ -188,8 +188,7 @@ static void essiv_aead_done(struct crypto_async_request *areq, int err)
struct aead_request *req = areq->data;
struct essiv_aead_request_ctx *rctx = aead_request_ctx(req);
- if (rctx->assoc)
- kfree(rctx->assoc);
+ kfree(rctx->assoc);
aead_request_complete(req, err);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: essiv: remove redundant null pointer check before kfree
2019-11-16 6:51 [PATCH] crypto: essiv: remove redundant null pointer check before kfree Chen Wandun
@ 2019-11-22 11:09 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-11-22 11:09 UTC (permalink / raw)
To: Chen Wandun; +Cc: davem, linux-crypto, linux-kernel
On Sat, Nov 16, 2019 at 02:51:00PM +0800, Chen Wandun wrote:
> kfree has taken null pointer check into account. so it is safe to
> remove the unnecessary check.
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> ---
> crypto/essiv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-22 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-16 6:51 [PATCH] crypto: essiv: remove redundant null pointer check before kfree Chen Wandun
2019-11-22 11:09 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).