* [PATCH] crypto: x86/chacha - only unregister algorithms if registered
@ 2019-11-18 7:21 Eric Biggers
2019-11-18 7:26 ` Ard Biesheuvel
2019-11-22 11:10 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2019-11-18 7:21 UTC (permalink / raw)
To: linux-crypto, Herbert Xu; +Cc: Ard Biesheuvel
From: Eric Biggers <ebiggers@google.com>
It's not valid to call crypto_unregister_skciphers() without a prior
call to crypto_register_skciphers().
Fixes: 84e03fa39fbe ("crypto: x86/chacha - expose SIMD ChaCha routine as library function")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
arch/x86/crypto/chacha_glue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/crypto/chacha_glue.c b/arch/x86/crypto/chacha_glue.c
index b391e13a9e41..a94e30b6f941 100644
--- a/arch/x86/crypto/chacha_glue.c
+++ b/arch/x86/crypto/chacha_glue.c
@@ -304,7 +304,8 @@ static int __init chacha_simd_mod_init(void)
static void __exit chacha_simd_mod_fini(void)
{
- crypto_unregister_skciphers(algs, ARRAY_SIZE(algs));
+ if (boot_cpu_has(X86_FEATURE_SSSE3))
+ crypto_unregister_skciphers(algs, ARRAY_SIZE(algs));
}
module_init(chacha_simd_mod_init);
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: x86/chacha - only unregister algorithms if registered
2019-11-18 7:21 [PATCH] crypto: x86/chacha - only unregister algorithms if registered Eric Biggers
@ 2019-11-18 7:26 ` Ard Biesheuvel
2019-11-22 11:10 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-11-18 7:26 UTC (permalink / raw)
To: Eric Biggers
Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE, Herbert Xu,
Ard Biesheuvel
On Mon, 18 Nov 2019 at 08:22, Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> It's not valid to call crypto_unregister_skciphers() without a prior
> call to crypto_register_skciphers().
>
> Fixes: 84e03fa39fbe ("crypto: x86/chacha - expose SIMD ChaCha routine as library function")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/x86/crypto/chacha_glue.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/crypto/chacha_glue.c b/arch/x86/crypto/chacha_glue.c
> index b391e13a9e41..a94e30b6f941 100644
> --- a/arch/x86/crypto/chacha_glue.c
> +++ b/arch/x86/crypto/chacha_glue.c
> @@ -304,7 +304,8 @@ static int __init chacha_simd_mod_init(void)
>
> static void __exit chacha_simd_mod_fini(void)
> {
> - crypto_unregister_skciphers(algs, ARRAY_SIZE(algs));
> + if (boot_cpu_has(X86_FEATURE_SSSE3))
> + crypto_unregister_skciphers(algs, ARRAY_SIZE(algs));
> }
>
> module_init(chacha_simd_mod_init);
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: x86/chacha - only unregister algorithms if registered
2019-11-18 7:21 [PATCH] crypto: x86/chacha - only unregister algorithms if registered Eric Biggers
2019-11-18 7:26 ` Ard Biesheuvel
@ 2019-11-22 11:10 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-11-22 11:10 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto, Ard Biesheuvel
On Sun, Nov 17, 2019 at 11:21:58PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> It's not valid to call crypto_unregister_skciphers() without a prior
> call to crypto_register_skciphers().
>
> Fixes: 84e03fa39fbe ("crypto: x86/chacha - expose SIMD ChaCha routine as library function")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> arch/x86/crypto/chacha_glue.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-22 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 7:21 [PATCH] crypto: x86/chacha - only unregister algorithms if registered Eric Biggers
2019-11-18 7:26 ` Ard Biesheuvel
2019-11-22 11:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).