* [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 02/10] powerpc: " Mark Brown
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Richard Henderson,
Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
Use the expansion of these macros directly in arch_get_random_*.
These symbols are currently part of the generic archrandom.h
interface, but are currently unused and can be removed.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/x86/include/asm/archrandom.h | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/x86/include/asm/archrandom.h b/arch/x86/include/asm/archrandom.h
index af45e1452f09..feb59461046c 100644
--- a/arch/x86/include/asm/archrandom.h
+++ b/arch/x86/include/asm/archrandom.h
@@ -73,10 +73,6 @@ static inline bool rdseed_int(unsigned int *v)
return ok;
}
-/* Conditional execution based on CPU type */
-#define arch_has_random() static_cpu_has(X86_FEATURE_RDRAND)
-#define arch_has_random_seed() static_cpu_has(X86_FEATURE_RDSEED)
-
/*
* These are the generic interfaces; they must not be declared if the
* stubs in <linux/random.h> are to be invoked,
@@ -86,22 +82,22 @@ static inline bool rdseed_int(unsigned int *v)
static inline bool arch_get_random_long(unsigned long *v)
{
- return arch_has_random() ? rdrand_long(v) : false;
+ return static_cpu_has(X86_FEATURE_RDRAND) ? rdrand_long(v) : false;
}
static inline bool arch_get_random_int(unsigned int *v)
{
- return arch_has_random() ? rdrand_int(v) : false;
+ return static_cpu_has(X86_FEATURE_RDRAND) ? rdrand_int(v) : false;
}
static inline bool arch_get_random_seed_long(unsigned long *v)
{
- return arch_has_random_seed() ? rdseed_long(v) : false;
+ return static_cpu_has(X86_FEATURE_RDSEED) ? rdseed_long(v) : false;
}
static inline bool arch_get_random_seed_int(unsigned int *v)
{
- return arch_has_random_seed() ? rdseed_int(v) : false;
+ return static_cpu_has(X86_FEATURE_RDSEED) ? rdseed_int(v) : false;
}
extern void x86_init_rdrand(struct cpuinfo_x86 *c);
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 02/10] powerpc: Remove arch_has_random, arch_has_random_seed
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
2020-01-10 14:54 ` [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 03/10] s390: " Mark Brown
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Richard Henderson,
Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
These symbols are currently part of the generic archrandom.h
interface, but are currently unused and can be removed.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/powerpc/include/asm/archrandom.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index a09595f00cab..2fa7cdfbba24 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -34,16 +34,6 @@ static inline int arch_get_random_seed_int(unsigned int *v)
return rc;
}
-
-static inline int arch_has_random(void)
-{
- return 0;
-}
-
-static inline int arch_has_random_seed(void)
-{
- return !!ppc_md.get_random_seed;
-}
#endif /* CONFIG_ARCH_RANDOM */
#ifdef CONFIG_PPC_POWERNV
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 03/10] s390: Remove arch_has_random, arch_has_random_seed
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
2020-01-10 14:54 ` [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed Mark Brown
2020-01-10 14:54 ` [PATCH v2 02/10] powerpc: " Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 04/10] linux/random.h: " Mark Brown
` (7 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Richard Henderson,
Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
These symbols are currently part of the generic archrandom.h
interface, but are currently unused and can be removed.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/s390/include/asm/archrandom.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/s390/include/asm/archrandom.h b/arch/s390/include/asm/archrandom.h
index c67b82dfa558..9a6835137a16 100644
--- a/arch/s390/include/asm/archrandom.h
+++ b/arch/s390/include/asm/archrandom.h
@@ -21,18 +21,6 @@ extern atomic64_t s390_arch_random_counter;
bool s390_arch_random_generate(u8 *buf, unsigned int nbytes);
-static inline bool arch_has_random(void)
-{
- return false;
-}
-
-static inline bool arch_has_random_seed(void)
-{
- if (static_branch_likely(&s390_arch_random_available))
- return true;
- return false;
-}
-
static inline bool arch_get_random_long(unsigned long *v)
{
return false;
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 04/10] linux/random.h: Remove arch_has_random, arch_has_random_seed
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (2 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 03/10] s390: " Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 05/10] linux/random.h: Use false with bool Mark Brown
` (6 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Richard Henderson,
Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
The arm64 version of archrandom.h will need to be able to test for
support and read the random number without preemption, so a separate
query predicate is not practical.
Since this part of the generic interface is unused, remove it.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
include/linux/random.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/linux/random.h b/include/linux/random.h
index f189c927fdea..7fd0360908d2 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -175,10 +175,6 @@ static inline bool arch_get_random_int(unsigned int *v)
{
return 0;
}
-static inline bool arch_has_random(void)
-{
- return 0;
-}
static inline bool arch_get_random_seed_long(unsigned long *v)
{
return 0;
@@ -187,10 +183,6 @@ static inline bool arch_get_random_seed_int(unsigned int *v)
{
return 0;
}
-static inline bool arch_has_random_seed(void)
-{
- return 0;
-}
#endif
/* Pseudo random number generator from numerical recipes. */
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 05/10] linux/random.h: Use false with bool
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (3 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 04/10] linux/random.h: " Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check Mark Brown
` (5 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Ard Biesheuvel,
Richard Henderson, Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
Keep the generic fallback versions in sync with the other architecture
specific implementations and use the proper name for false.
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
include/linux/random.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/random.h b/include/linux/random.h
index 7fd0360908d2..ea0e2f5f1ec5 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -169,19 +169,19 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
#else
static inline bool arch_get_random_long(unsigned long *v)
{
- return 0;
+ return false;
}
static inline bool arch_get_random_int(unsigned int *v)
{
- return 0;
+ return false;
}
static inline bool arch_get_random_seed_long(unsigned long *v)
{
- return 0;
+ return false;
}
static inline bool arch_get_random_seed_int(unsigned int *v)
{
- return 0;
+ return false;
}
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (4 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 05/10] linux/random.h: Use false with bool Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 07/10] x86: Mark archrandom.h " Mark Brown
` (4 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Ard Biesheuvel,
Richard Henderson, Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
We must not use the pointer output without validating the
success of the random read.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
include/linux/random.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/random.h b/include/linux/random.h
index ea0e2f5f1ec5..d319f9a1e429 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -167,19 +167,19 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
#ifdef CONFIG_ARCH_RANDOM
# include <asm/archrandom.h>
#else
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
{
return false;
}
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{
return false;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 07/10] x86: Mark archrandom.h functions __must_check
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (5 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 08/10] powerpc: Use bool in archrandom.h Mark Brown
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Ard Biesheuvel,
Richard Henderson, Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
We must not use the pointer output without validating the
success of the random read.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/x86/include/asm/archrandom.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/x86/include/asm/archrandom.h b/arch/x86/include/asm/archrandom.h
index feb59461046c..7a4bb1bd4bdb 100644
--- a/arch/x86/include/asm/archrandom.h
+++ b/arch/x86/include/asm/archrandom.h
@@ -27,7 +27,7 @@
/* Unconditional execution of RDRAND and RDSEED */
-static inline bool rdrand_long(unsigned long *v)
+static inline bool __must_check rdrand_long(unsigned long *v)
{
bool ok;
unsigned int retry = RDRAND_RETRY_LOOPS;
@@ -41,7 +41,7 @@ static inline bool rdrand_long(unsigned long *v)
return false;
}
-static inline bool rdrand_int(unsigned int *v)
+static inline bool __must_check rdrand_int(unsigned int *v)
{
bool ok;
unsigned int retry = RDRAND_RETRY_LOOPS;
@@ -55,7 +55,7 @@ static inline bool rdrand_int(unsigned int *v)
return false;
}
-static inline bool rdseed_long(unsigned long *v)
+static inline bool __must_check rdseed_long(unsigned long *v)
{
bool ok;
asm volatile(RDSEED_LONG
@@ -64,7 +64,7 @@ static inline bool rdseed_long(unsigned long *v)
return ok;
}
-static inline bool rdseed_int(unsigned int *v)
+static inline bool __must_check rdseed_int(unsigned int *v)
{
bool ok;
asm volatile(RDSEED_INT
@@ -80,22 +80,22 @@ static inline bool rdseed_int(unsigned int *v)
*/
#ifdef CONFIG_ARCH_RANDOM
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
{
return static_cpu_has(X86_FEATURE_RDRAND) ? rdrand_long(v) : false;
}
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
{
return static_cpu_has(X86_FEATURE_RDRAND) ? rdrand_int(v) : false;
}
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{
return static_cpu_has(X86_FEATURE_RDSEED) ? rdseed_long(v) : false;
}
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{
return static_cpu_has(X86_FEATURE_RDSEED) ? rdseed_int(v) : false;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 08/10] powerpc: Use bool in archrandom.h
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (6 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 07/10] x86: Mark archrandom.h " Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check Mark Brown
` (2 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Ard Biesheuvel,
Richard Henderson, Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
The generic interface uses bool not int; match that.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/powerpc/include/asm/archrandom.h | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index 2fa7cdfbba24..f0f16b4fc5ea 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -6,27 +6,28 @@
#include <asm/machdep.h>
-static inline int arch_get_random_long(unsigned long *v)
+static inline bool arch_get_random_long(unsigned long *v)
{
- return 0;
+ return false;
}
-static inline int arch_get_random_int(unsigned int *v)
+static inline bool arch_get_random_int(unsigned int *v)
{
- return 0;
+ return false;
}
-static inline int arch_get_random_seed_long(unsigned long *v)
+static inline bool arch_get_random_seed_long(unsigned long *v)
{
if (ppc_md.get_random_seed)
return ppc_md.get_random_seed(v);
- return 0;
+ return false;
}
-static inline int arch_get_random_seed_int(unsigned int *v)
+
+static inline bool arch_get_random_seed_int(unsigned int *v)
{
unsigned long val;
- int rc;
+ bool rc;
rc = arch_get_random_seed_long(&val);
if (rc)
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (7 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 08/10] powerpc: Use bool in archrandom.h Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 10/10] s390x: " Mark Brown
2020-01-10 15:51 ` [PATCH v2 00/10] Impveovements for random.h/archrandom.h Borislav Petkov
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel, Michael Ellerman,
Ard Biesheuvel, Richard Henderson, Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
We must not use the pointer output without validating the
success of the random read.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/powerpc/include/asm/archrandom.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index f0f16b4fc5ea..9a53e29680f4 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -6,17 +6,17 @@
#include <asm/machdep.h>
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
{
return false;
}
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{
if (ppc_md.get_random_seed)
return ppc_md.get_random_seed(v);
@@ -24,7 +24,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v)
return false;
}
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{
unsigned long val;
bool rc;
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 10/10] s390x: Mark archrandom.h functions __must_check
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (8 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check Mark Brown
@ 2020-01-10 14:54 ` Mark Brown
2020-01-10 15:51 ` [PATCH v2 00/10] Impveovements for random.h/archrandom.h Borislav Petkov
10 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
To: linux-arch
Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel,
Harald Freudenberger, Ard Biesheuvel, Richard Henderson,
Mark Brown
From: Richard Henderson <richard.henderson@linaro.org>
We must not use the pointer output without validating the
success of the random read.
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/s390/include/asm/archrandom.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/s390/include/asm/archrandom.h b/arch/s390/include/asm/archrandom.h
index 9a6835137a16..de61ce562052 100644
--- a/arch/s390/include/asm/archrandom.h
+++ b/arch/s390/include/asm/archrandom.h
@@ -21,17 +21,17 @@ extern atomic64_t s390_arch_random_counter;
bool s390_arch_random_generate(u8 *buf, unsigned int nbytes);
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
{
return false;
}
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{
if (static_branch_likely(&s390_arch_random_available)) {
return s390_arch_random_generate((u8 *)v, sizeof(*v));
@@ -39,7 +39,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v)
return false;
}
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{
if (static_branch_likely(&s390_arch_random_available)) {
return s390_arch_random_generate((u8 *)v, sizeof(*v));
--
2.20.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
` (9 preceding siblings ...)
2020-01-10 14:54 ` [PATCH v2 10/10] s390x: " Mark Brown
@ 2020-01-10 15:51 ` Borislav Petkov
2020-01-10 17:05 ` Theodore Y. Ts'o
10 siblings, 1 reply; 17+ messages in thread
From: Borislav Petkov @ 2020-01-10 15:51 UTC (permalink / raw)
To: Mark Brown, Andrew Morton
Cc: linux-arch, Richard Henderson, linux-s390, herbert, x86,
linux-crypto, linuxppc-dev, linux-arm-kernel
On Fri, Jan 10, 2020 at 02:54:12PM +0000, Mark Brown wrote:
> This is a resend of a series from Richard Henderson last posted back in
> November:
>
> https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-rth@twiddle.net/
>
> Back then Borislav said they looked good and asked if he should take
> them through the tip tree but things seem to have got lost since then.
Or, alternatively, akpm could take them. In any case, if someone else
ends up doing that, for the x86 bits:
Reviewed-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
2020-01-10 15:51 ` [PATCH v2 00/10] Impveovements for random.h/archrandom.h Borislav Petkov
@ 2020-01-10 17:05 ` Theodore Y. Ts'o
2020-01-20 17:26 ` Mark Brown
0 siblings, 1 reply; 17+ messages in thread
From: Theodore Y. Ts'o @ 2020-01-10 17:05 UTC (permalink / raw)
To: Borislav Petkov
Cc: Mark Brown, Andrew Morton, linux-arch, Richard Henderson,
linux-s390, herbert, x86, linux-crypto, linuxppc-dev,
linux-arm-kernel
On Fri, Jan 10, 2020 at 04:51:53PM +0100, Borislav Petkov wrote:
> On Fri, Jan 10, 2020 at 02:54:12PM +0000, Mark Brown wrote:
> > This is a resend of a series from Richard Henderson last posted back in
> > November:
> >
> > https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-rth@twiddle.net/
> >
> > Back then Borislav said they looked good and asked if he should take
> > them through the tip tree but things seem to have got lost since then.
>
> Or, alternatively, akpm could take them. In any case, if someone else
> ends up doing that, for the x86 bits:
>
> Reviewed-by: Borislav Petkov <bp@suse.de>
Or I can take them through the random.git tree, since we have a lot of
changes this cycle going to Linus anyway. Any objections?
- Ted
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
2020-01-10 17:05 ` Theodore Y. Ts'o
@ 2020-01-20 17:26 ` Mark Brown
2020-01-20 17:59 ` Borislav Petkov
0 siblings, 1 reply; 17+ messages in thread
From: Mark Brown @ 2020-01-20 17:26 UTC (permalink / raw)
To: Theodore Y. Ts'o
Cc: Borislav Petkov, Andrew Morton, linux-arch, Richard Henderson,
linux-s390, herbert, x86, linux-crypto, linuxppc-dev,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Fri, Jan 10, 2020 at 12:05:59PM -0500, Theodore Y. Ts'o wrote:
> On Fri, Jan 10, 2020 at 04:51:53PM +0100, Borislav Petkov wrote:
> > On Fri, Jan 10, 2020 at 02:54:12PM +0000, Mark Brown wrote:
> > > This is a resend of a series from Richard Henderson last posted back in
> > > November:
> > > https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-rth@twiddle.net/
> > > Back then Borislav said they looked good and asked if he should take
> > > them through the tip tree but things seem to have got lost since then.
> > Or, alternatively, akpm could take them. In any case, if someone else
> > ends up doing that, for the x86 bits:
> Or I can take them through the random.git tree, since we have a lot of
> changes this cycle going to Linus anyway. Any objections?
I think the important thing here is that *someone* takes the patches.
We've now got Ted and Borislav both saying they're OK applying the
patches, an additional proposal that Andrew takes the patches, nobody
saying anything negative about applying the patches and yet the patches
are not applied. The random tree sounds like a sensible enough tree to
take this so if Ted picks them up perhaps that's most sensible?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
2020-01-20 17:26 ` Mark Brown
@ 2020-01-20 17:59 ` Borislav Petkov
2020-01-25 17:46 ` Theodore Y. Ts'o
0 siblings, 1 reply; 17+ messages in thread
From: Borislav Petkov @ 2020-01-20 17:59 UTC (permalink / raw)
To: Mark Brown
Cc: Theodore Y. Ts'o, Andrew Morton, linux-arch,
Richard Henderson, linux-s390, herbert, x86, linux-crypto,
linuxppc-dev, linux-arm-kernel
On Mon, Jan 20, 2020 at 05:26:27PM +0000, Mark Brown wrote:
> I think the important thing here is that *someone* takes the patches.
> We've now got Ted and Borislav both saying they're OK applying the
> patches, an additional proposal that Andrew takes the patches, nobody
> saying anything negative about applying the patches and yet the patches
> are not applied. The random tree sounds like a sensible enough tree to
> take this so if Ted picks them up perhaps that's most sensible?
Yes, Ted, pls pick them up so that we're done with this.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h
2020-01-20 17:59 ` Borislav Petkov
@ 2020-01-25 17:46 ` Theodore Y. Ts'o
0 siblings, 0 replies; 17+ messages in thread
From: Theodore Y. Ts'o @ 2020-01-25 17:46 UTC (permalink / raw)
To: Borislav Petkov
Cc: Mark Brown, Andrew Morton, linux-arch, Richard Henderson,
linux-s390, herbert, x86, linux-crypto, linuxppc-dev,
linux-arm-kernel
On Mon, Jan 20, 2020 at 06:59:01PM +0100, Borislav Petkov wrote:
> On Mon, Jan 20, 2020 at 05:26:27PM +0000, Mark Brown wrote:
> > I think the important thing here is that *someone* takes the patches.
> > We've now got Ted and Borislav both saying they're OK applying the
> > patches, an additional proposal that Andrew takes the patches, nobody
> > saying anything negative about applying the patches and yet the patches
> > are not applied. The random tree sounds like a sensible enough tree to
> > take this so if Ted picks them up perhaps that's most sensible?
>
> Yes, Ted, pls pick them up so that we're done with this.
I've picked them up and pushed them to the random tree.
- Ted
^ permalink raw reply [flat|nested] 17+ messages in thread