* Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee [not found] <20200107143601.105321-1-colin.king@canonical.com> @ 2020-01-08 7:03 ` Thomas, Rijo-john 2020-01-08 7:53 ` Jens Wiklander 2020-01-16 7:05 ` Herbert Xu 0 siblings, 2 replies; 4+ messages in thread From: Thomas, Rijo-john @ 2020-01-08 7:03 UTC (permalink / raw) To: Colin King, Jens Wiklander, Devaraj Rangasamy, Herbert Xu, Gary R Hook, tee-dev, linux-crypto Cc: kernel-janitors, linux-kernel +linux-crypto On 07/01/20 8:06 pm, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the memory allocation failure checks on drv_data and > amdtee are using IS_ERR rather than checking for a null pointer. > Fix these checks to use the conventional null pointer check. > > Addresses-Coverity: ("Dereference null return") > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com> > --- > drivers/tee/amdtee/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c > index 9d0cee1c837f..5fda810c79dc 100644 > --- a/drivers/tee/amdtee/core.c > +++ b/drivers/tee/amdtee/core.c > @@ -444,11 +444,11 @@ static int __init amdtee_driver_init(void) > goto err_fail; > > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL); > - if (IS_ERR(drv_data)) > + if (!drv_data) > return -ENOMEM; > > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL); > - if (IS_ERR(amdtee)) { > + if (!amdtee) { > rc = -ENOMEM; > goto err_kfree_drv_data; > } > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee 2020-01-08 7:03 ` [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee Thomas, Rijo-john @ 2020-01-08 7:53 ` Jens Wiklander 2020-01-16 7:05 ` Herbert Xu 1 sibling, 0 replies; 4+ messages in thread From: Jens Wiklander @ 2020-01-08 7:53 UTC (permalink / raw) To: Thomas, Rijo-john Cc: Colin King, Devaraj Rangasamy, Herbert Xu, Gary R Hook, tee-dev @ lists . linaro . org, linux-crypto, kernel-janitors, Linux Kernel Mailing List On Wed, Jan 8, 2020 at 8:03 AM Thomas, Rijo-john <Rijo-john.Thomas@amd.com> wrote: > > +linux-crypto > > On 07/01/20 8:06 pm, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently the memory allocation failure checks on drv_data and > > amdtee are using IS_ERR rather than checking for a null pointer. > > Fix these checks to use the conventional null pointer check. > > > > Addresses-Coverity: ("Dereference null return") > > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Thanks, Jens > > > --- > > drivers/tee/amdtee/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c > > index 9d0cee1c837f..5fda810c79dc 100644 > > --- a/drivers/tee/amdtee/core.c > > +++ b/drivers/tee/amdtee/core.c > > @@ -444,11 +444,11 @@ static int __init amdtee_driver_init(void) > > goto err_fail; > > > > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL); > > - if (IS_ERR(drv_data)) > > + if (!drv_data) > > return -ENOMEM; > > > > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL); > > - if (IS_ERR(amdtee)) { > > + if (!amdtee) { > > rc = -ENOMEM; > > goto err_kfree_drv_data; > > } > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee 2020-01-08 7:03 ` [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee Thomas, Rijo-john 2020-01-08 7:53 ` Jens Wiklander @ 2020-01-16 7:05 ` Herbert Xu 2020-01-16 8:07 ` Thomas, Rijo-john 1 sibling, 1 reply; 4+ messages in thread From: Herbert Xu @ 2020-01-16 7:05 UTC (permalink / raw) To: Thomas, Rijo-john Cc: Colin King, Jens Wiklander, Devaraj Rangasamy, Gary R Hook, tee-dev, linux-crypto, kernel-janitors, linux-kernel On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote: > +linux-crypto > > On 07/01/20 8:06 pm, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently the memory allocation failure checks on drv_data and > > amdtee are using IS_ERR rather than checking for a null pointer. > > Fix these checks to use the conventional null pointer check. > > > > Addresses-Coverity: ("Dereference null return") > > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com> This patch needs to be resubmitted to the linux-crypto list for it to be picked up by patchwork. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee 2020-01-16 7:05 ` Herbert Xu @ 2020-01-16 8:07 ` Thomas, Rijo-john 0 siblings, 0 replies; 4+ messages in thread From: Thomas, Rijo-john @ 2020-01-16 8:07 UTC (permalink / raw) To: Colin King Cc: Herbert Xu, Jens Wiklander, Devaraj Rangasamy, Gary R Hook, tee-dev, linux-crypto, kernel-janitors, linux-kernel Hi Colin, On 16/01/20 12:35 pm, Herbert Xu wrote: > On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote: >> +linux-crypto >> >> On 07/01/20 8:06 pm, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> Currently the memory allocation failure checks on drv_data and >>> amdtee are using IS_ERR rather than checking for a null pointer. >>> Fix these checks to use the conventional null pointer check. >>> >>> Addresses-Coverity: ("Dereference null return") >>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver") >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> >> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com> > > This patch needs to be resubmitted to the linux-crypto list for > it to be picked up by patchwork. Can you please resubmit this patch to linux-crypto list? Thanks, Rijo > > Thanks, > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-16 8:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200107143601.105321-1-colin.king@canonical.com>
2020-01-08 7:03 ` [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee Thomas, Rijo-john
2020-01-08 7:53 ` Jens Wiklander
2020-01-16 7:05 ` Herbert Xu
2020-01-16 8:07 ` Thomas, Rijo-john
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).